From: Sterling Augustine <saugustine@google.com>
To: Cary Coutant <ccoutant@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, reply@codereview.appspotmail.com
Subject: Re: [Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)
Date: Fri, 18 Jan 2013 21:50:00 -0000 [thread overview]
Message-ID: <CAEG7qUzzieDyupshWS4UyM0HAkncMgzdfeG_3AT6jv0juPeo9g@mail.gmail.com> (raw)
In-Reply-To: <CAHACq4pAU7AdkRMkUVppeGET8ofGKPimXU6LnOW7HWkyzcL19g@mail.gmail.com>
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant <ccoutant@google.com> wrote:
>> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
>> Author: Sterling Augustine <saugustine@google.com>
>> Date: Fri Jan 18 10:38:30 2013 -0800
>>
>> Fix for Google Ref: b/8028506
>>
>> Calling find_AT_string can resize the debug_str hash table, even if the
>> string is already present in the hash table--go figure. So after indices
>> have been assigned, and the hash table is exactly three-quarters full,
>> calling find_AT_string is verboten.
>>
>> This change moves some calls around such that the above scenario never
>> happens, all strings will be found and assigned prior to indices being
>> assigned.
>>
>> M gcc/dwarf2out.c
>
> OK for google/gcc-4_7.
>
> I'll be filing an upstream bug for this problem, and I'd like to get
> this fix into 4.8 as well.
>
> -cary
Committed as posted. Thanks. These do need to go into trunk, as they
complicate using fission.
Sterling
prev parent reply other threads:[~2013-01-18 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 18:45 Sterling Augustine
2013-01-18 19:04 ` Cary Coutant
2013-01-18 21:50 ` Sterling Augustine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEG7qUzzieDyupshWS4UyM0HAkncMgzdfeG_3AT6jv0juPeo9g@mail.gmail.com \
--to=saugustine@google.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).