From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126805 invoked by alias); 11 Aug 2017 06:09:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126788 invoked by uid 89); 11 Aug 2017 06:09:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f181.google.com Received: from mail-qk0-f181.google.com (HELO mail-qk0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Aug 2017 06:09:38 +0000 Received: by mail-qk0-f181.google.com with SMTP id d136so15699369qkg.3 for ; Thu, 10 Aug 2017 23:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=wCPjzG+EUWyuc4N1ZbxK6rqDnwMRzCYPEzMCmh7FSoY=; b=jBJteP9UsO/XHfrQ6cl/8BRyg6VF8D1+X1c/CyqEJnY5C3yGARGN2py1y0g00TqHox kGUXQJHLf4jBAc6o8PCj+RsDAA1/Doq0ZAYJMfEvvAgNsWx50QQNXjmynaLQUCfNLXpf x77T/M6JFhntdJkHXOFmft9xjpaxlvb64CrBziGQf6jlKaXY6+Nt99/SUvZvppg9OWxF aJyJ1fWCLV7GAxIKSZQ2MhD5ke+OsfdsFoLo67m5EL7g7LN2I1KkotWJ+nsxcVFvMIFN hUvFEJxLUSKWEcE9H2EbHWDLZTtILL9J0zHWm92LCzvX3EBF29cBXV+IPl6xxDFfvp/v WmKg== X-Gm-Message-State: AHYfb5hLGCPcnMfbJvMnqP45hC55UbSsvpvrHNc/mc10J/869fTZkuom XoZzd4FkgOOHKxZ0k5/DAbcCNx7xG9RtcXs= X-Received: by 10.55.157.135 with SMTP id g129mr19325836qke.241.1502431776768; Thu, 10 Aug 2017 23:09:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.51.42 with HTTP; Thu, 10 Aug 2017 23:09:36 -0700 (PDT) In-Reply-To: References: From: Kugan Vivekanandarajah Date: Fri, 11 Aug 2017 10:34:00 -0000 Message-ID: Subject: Re: [AARCH64] Disable pc relative literal load irrespective of TARGET_FIX_ERR_A53_84341 To: "gcc-patches@gcc.gnu.org" , James Greenhalgh , Richard Earnshaw Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00784.txt.bz2 Ping^2? Thanks, Kugan On 21 July 2017 at 20:12, Kugan Vivekanandarajah wrote: > Ping ? > > Thanks, > Kugan > > On 27 June 2017 at 11:20, Kugan Vivekanandarajah > wrote: >> https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00614.html added this >> workaround to get kernel building with when TARGET_FIX_ERR_A53_843419 >> is enabled. >> >> This was added to support building kernel loadable modules. In kernel, >> when CONFIG_ARM64_ERRATUM_843419 is selected, the relocation needed >> for ADRP/LDR (R_AARCH64_ADR_PREL_PG_HI21 and >> R_AARCH64_ADR_PREL_PG_HI21_NC are removed from the kernel to avoid >> loading objects with possibly offending sequence). Thus, it could only >> support pc relative literal loads. >> >> However, the following patch was posted to kernel to add >> -mpc-relative-literal-loads >> http://www.spinics.net/lists/arm-kernel/msg476149.html >> >> -mpc-relative-literal-loads is unconditionally added to the kernel >> build as can be seen from: >> https://github.com/torvalds/linux/blob/master/arch/arm64/Makefile >> >> Therefore this patch removes the hunk so that applications like >> SPECcpu2017's 521/621.wrf can be built (with LTO in this case) without >> -mno-pc-relative-literal-loads >> >> Bootstrapped and regression tested on aarch64-linux-gnu with no new regressions. >> >> Is this OK for trunk? >> >> Thanks, >> Kugan >> >> gcc/testsuite/ChangeLog: >> >> 2017-06-27 Kugan Vivekanandarajah >> >> * gcc.target/aarch64/pr63304_1.c: Remove-mno-fix-cortex-a53-843419. >> >> gcc/ChangeLog: >> >> 2017-06-27 Kugan Vivekanandarajah >> >> * config/aarch64/aarch64.c (aarch64_override_options_after_change_1): >> Disable pc relative literal load irrespective of TARGET_FIX_ERR_A53_84341 >> for default.