From: Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <richard.guenther@gmail.com>
Subject: [PATCH] Fix PR tree-optimization/71179
Date: Fri, 20 May 2016 02:13:00 -0000 [thread overview]
Message-ID: <CAELXzTNUpht9CMJaYnZUftG6bFe-EAuB=Oo9YK7B6Fd7=E8uaQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
Hi,
We don’t allow vector type for integer. Likewise I am also disallowing
the floating point vector type in transforming repeated addition to
multiplication.
This can be relaxed. I will send a separate patch to allow integer and
floating point vectorization later.
Bootstrapped and regression tested on x86-64-linux-gnu with no new regressions.
Is this OK for trunk?
Thanks,
Kugan
gcc/testsuite/ChangeLog:
2016-05-20 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
* gcc.dg/tree-ssa/pr71179.c: New test.
gcc/ChangeLog:
2016-05-20 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
* tree-ssa-reassoc.c (transform_add_to_multiply): Disallow float
VECTOR type.
[-- Attachment #2: pr71179.txt --]
[-- Type: text/plain, Size: 949 bytes --]
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr71179.c b/gcc/testsuite/gcc.dg/tree-ssa/pr71179.c
index e69de29..885c643 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/pr71179.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr71179.c
@@ -0,0 +1,10 @@
+
+/* { dg-do compile } */
+/* { dg-options "-O3 -ffast-math" } */
+
+typedef float __m128 __attribute__ ((__vector_size__ (16), __may_alias__));
+
+__m128 foo (__m128 a)
+{
+ return a + a;
+}
diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c
index 3b5f36b..0c25a8c 100644
--- a/gcc/tree-ssa-reassoc.c
+++ b/gcc/tree-ssa-reassoc.c
@@ -1769,7 +1769,8 @@ transform_add_to_multiply (gimple *stmt, vec<operand_entry *> *ops)
bool changed = false;
if (!INTEGRAL_TYPE_P (TREE_TYPE ((*ops)[0]->op))
- && !flag_unsafe_math_optimizations)
+ && (!SCALAR_FLOAT_TYPE_P (TREE_TYPE ((*ops)[0]->op))
+ || !flag_unsafe_math_optimizations))
return false;
/* Look for repeated operands. */
next reply other threads:[~2016-05-20 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 2:13 Kugan Vivekanandarajah [this message]
2016-05-20 9:30 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELXzTNUpht9CMJaYnZUftG6bFe-EAuB=Oo9YK7B6Fd7=E8uaQ@mail.gmail.com' \
--to=kugan.vivekanandarajah@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).