From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23087 invoked by alias); 29 Aug 2017 03:57:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23072 invoked by uid 89); 29 Aug 2017 03:57:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f178.google.com Received: from mail-qk0-f178.google.com (HELO mail-qk0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Aug 2017 03:57:01 +0000 Received: by mail-qk0-f178.google.com with SMTP id a77so10489479qkb.1 for ; Mon, 28 Aug 2017 20:57:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=3YzEP5AwqMq8p//DXTPzQcL4Ed4BE+t66dPnTjZKOOg=; b=laCUxQSfr1HVLwv4H+S8p42dVCDBrxAtHb1+fkUj3sOv8t83GAbvOabbaePNCI8pDF se9NubBxat6/RBbtYt+3P55CqzF/i2FOtcd6l8z8xIs8r6A7bsi6unhVjvmntwe9OCkz bFdeF8MFsJTuIbeGuVfqUv0dK6e3O7W4i3CLUzFoswnySPWRUDKeDVCJJbJ1xZokLpbS aqD4F1GRYahCaU1SrdSgOj+dvu9jDeze1l9rgOJ4YJskTenvuEPXqARacMDn51rgc+8b F12WUfvnX8nNnxyxHcvmtqoatBjo1DxClaR/RigYgLvfrn48g8SuZuqwBsYlvuIE44lW 8fEg== X-Gm-Message-State: AHYfb5iLJNyaog/5kC8O/Ti7Ah7WARPuuJksPcp6IjJgn93hE3X0m0nd bi5YRjjsOJ+Iz0FmmRKoFWi83NRPhnW7PWc= X-Received: by 10.55.104.214 with SMTP id d205mr3591249qkc.37.1503979019299; Mon, 28 Aug 2017 20:56:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.49.6 with HTTP; Mon, 28 Aug 2017 20:56:58 -0700 (PDT) In-Reply-To: References: From: Kugan Vivekanandarajah Date: Tue, 29 Aug 2017 08:32:00 -0000 Message-ID: Subject: Re: [AARCH64] Disable pc relative literal load irrespective of TARGET_FIX_ERR_A53_84341 To: "gcc-patches@gcc.gnu.org" , James Greenhalgh , Richard Earnshaw Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01622.txt.bz2 ping^3 Thanks, Kugan On 11 August 2017 at 16:09, Kugan Vivekanandarajah wrote: > Ping^2? > > Thanks, > Kugan > > On 21 July 2017 at 20:12, Kugan Vivekanandarajah > wrote: >> Ping ? >> >> Thanks, >> Kugan >> >> On 27 June 2017 at 11:20, Kugan Vivekanandarajah >> wrote: >>> https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00614.html added this >>> workaround to get kernel building with when TARGET_FIX_ERR_A53_843419 >>> is enabled. >>> >>> This was added to support building kernel loadable modules. In kernel, >>> when CONFIG_ARM64_ERRATUM_843419 is selected, the relocation needed >>> for ADRP/LDR (R_AARCH64_ADR_PREL_PG_HI21 and >>> R_AARCH64_ADR_PREL_PG_HI21_NC are removed from the kernel to avoid >>> loading objects with possibly offending sequence). Thus, it could only >>> support pc relative literal loads. >>> >>> However, the following patch was posted to kernel to add >>> -mpc-relative-literal-loads >>> http://www.spinics.net/lists/arm-kernel/msg476149.html >>> >>> -mpc-relative-literal-loads is unconditionally added to the kernel >>> build as can be seen from: >>> https://github.com/torvalds/linux/blob/master/arch/arm64/Makefile >>> >>> Therefore this patch removes the hunk so that applications like >>> SPECcpu2017's 521/621.wrf can be built (with LTO in this case) without >>> -mno-pc-relative-literal-loads >>> >>> Bootstrapped and regression tested on aarch64-linux-gnu with no new regressions. >>> >>> Is this OK for trunk? >>> >>> Thanks, >>> Kugan >>> >>> gcc/testsuite/ChangeLog: >>> >>> 2017-06-27 Kugan Vivekanandarajah >>> >>> * gcc.target/aarch64/pr63304_1.c: Remove-mno-fix-cortex-a53-843419. >>> >>> gcc/ChangeLog: >>> >>> 2017-06-27 Kugan Vivekanandarajah >>> >>> * config/aarch64/aarch64.c (aarch64_override_options_after_change_1): >>> Disable pc relative literal load irrespective of TARGET_FIX_ERR_A53_84341 >>> for default.