From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8236 invoked by alias); 15 Jan 2013 16:31:07 -0000 Received: (qmail 8130 invoked by uid 22791); 15 Jan 2013 16:31:05 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f44.google.com (HELO mail-vb0-f44.google.com) (209.85.212.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 16:31:02 +0000 Received: by mail-vb0-f44.google.com with SMTP id fc26so316621vbb.3 for ; Tue, 15 Jan 2013 08:31:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.239.143 with SMTP id kw15mr103688952vcb.62.1358267461655; Tue, 15 Jan 2013 08:31:01 -0800 (PST) Received: by 10.220.150.82 with HTTP; Tue, 15 Jan 2013 08:31:01 -0800 (PST) Date: Tue, 15 Jan 2013 16:31:00 -0000 Message-ID: Subject: dg-extract-results.sh truncates logs containing "Running " From: David Blaikie To: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=14dae9ccd4ee8fde4304d35649a9 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00790.txt.bz2 --14dae9ccd4ee8fde4304d35649a9 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 959 The regex to detect the beginning of a test file execution was too broad, matching any line beginning with "Running ". This caused dg-extract-results.sh to truncate some test logs, including gdb.base/help.exp in the GDB test suite (which tests "help running", printing "Running the program.") The attached patch makes the match a little more precise to avoid this. With this the exact count of PASS/FAIL/etc lines in the dg-extract-results.sh output matches the counts in the computed summary exactly for all cases I've seen. I encountered this in the GDB test suite but was asked to submit the change upstream to GCC as GDB would prefer to avoid unnecessary local changes to the script & this change seems general enough to go in to GCC. I'm still a little fuzzy on the specifics of ChangeLog lines, but here's my attempt at one for this change: * dg-extract-results.sh: constrain the start-of-log pattern to avoid accidentally matching test content --14dae9ccd4ee8fde4304d35649a9 Content-Type: application/octet-stream; name="extract-running.diff" Content-Disposition: attachment; filename="extract-running.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hby171t80 Content-length: 574 ZGlmZiAtLWdpdCBnZGIvdGVzdHN1aXRlL2RnLWV4dHJhY3QtcmVzdWx0cy5z aCBnZGIvdGVzdHN1aXRlL2RnLWV4dHJhY3QtcmVzdWx0cy5zaAppbmRleCA1 NzQ4MzNlLi5jNjdiNWNhIDEwMDc1NQotLS0gZ2RiL3Rlc3RzdWl0ZS9kZy1l eHRyYWN0LXJlc3VsdHMuc2gKKysrIGdkYi90ZXN0c3VpdGUvZGctZXh0cmFj dC1yZXN1bHRzLnNoCkBAIC0yODYsNyArMjg2LDcgQEAgQkVHSU4gewogL15V c2luZyAvIHsKICAgaWYgKHZhcmlhbnQgPT0gY3VydmFyICYmIHByaW50X3Vz aW5nKSB7IHByaW50OyBuZXh0IH0KIH0KLS9eUnVubmluZyAvIHsKKy9eUnVu bmluZyAuKlxcLmV4cCBcXC5cXC5cXC4vIHsKICAgcHJpbnRfdXNpbmc9MAog ICBpZiAodmFyaWFudCA9PSBjdXJ2YXIpIHsKICAgICBpZiAobmVlZF9jbG9z ZSkgY2xvc2UoY3VyZmlsZSkK --14dae9ccd4ee8fde4304d35649a9--