* Fwd: summarize kfails in dg-extract-results.sh
[not found] <CAENS6EsZS0tt1CboNDZQ--mgU9rySZfChRkUQJz4ZYq8ob0v+Q@mail.gmail.com>
@ 2013-01-15 17:24 ` David Blaikie
2013-01-15 20:20 ` Janis Johnson
0 siblings, 1 reply; 3+ messages in thread
From: David Blaikie @ 2013-01-15 17:24 UTC (permalink / raw)
To: gcc-patches, dje
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
For some reason KFAILs weren't being summarized by
dg-extract-results.sh. I assume this was just an oversight, so here's
a patch to add it alongside all the other result types.
I encountered this in the GDB test suite but was asked to submit the
change upstream to GCC as GDB would prefer to avoid unnecessary local
changes to the script & this change seems general enough to go in to
GCC.
(As was pointed out by Pedro Alves on the gdb-patches list, KFAIL
support was recently added by Doug Evans (
http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00996.html ), so KPASS
support seems like a natural complement)
I'm still a little fuzzy on the specifics of ChangeLog lines, but
here's my attempt at one for this change:
* dg-extract-results.sh: Handle KPASSes.
[-- Attachment #2: gcc-extract-kpass.diff --]
[-- Type: application/octet-stream, Size: 2519 bytes --]
Index: contrib/dg-extract-results.sh
===================================================================
--- contrib/dg-extract-results.sh (revision 195208)
+++ contrib/dg-extract-results.sh (working copy)
@@ -345,7 +345,7 @@
BEGIN {
variant="$VAR"
tool="$TOOL"
- passcnt=0; failcnt=0; untstcnt=0; xpasscnt=0; xfailcnt=0; kfailcnt=0; unsupcnt=0; unrescnt=0;
+ passcnt=0; failcnt=0; untstcnt=0; xpasscnt=0; xfailcnt=0; kpasscnt=0; kfailcnt=0; unsupcnt=0; unrescnt=0;
curvar=""; insummary=0
}
/^Running target / { curvar = \$3; next }
@@ -354,6 +354,7 @@
/^# of unexpected successes/ { if (insummary == 1) xpasscnt += \$5; next; }
/^# of unexpected failures/ { if (insummary == 1) failcnt += \$5; next; }
/^# of expected failures/ { if (insummary == 1) xfailcnt += \$5; next; }
+/^# of unknown successes/ { if (insummary == 1) kpasscnt += \$5; next; }
/^# of known failures/ { if (insummary == 1) kfailcnt += \$5; next; }
/^# of untested testcases/ { if (insummary == 1) untstcnt += \$5; next; }
/^# of unresolved testcases/ { if (insummary == 1) unrescnt += \$5; next; }
@@ -369,6 +370,7 @@
if (failcnt != 0) printf ("# of unexpected failures\t%d\n", failcnt)
if (xpasscnt != 0) printf ("# of unexpected successes\t%d\n", xpasscnt)
if (xfailcnt != 0) printf ("# of expected failures\t\t%d\n", xfailcnt)
+ if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kfailcnt)
if (kfailcnt != 0) printf ("# of known failures\t\t%d\n", kfailcnt)
if (untstcnt != 0) printf ("# of untested testcases\t\t%d\n", untstcnt)
if (unrescnt != 0) printf ("# of unresolved testcases\t%d\n", unrescnt)
@@ -399,6 +401,7 @@
/^# of unexpected failures/ { failcnt += \$5 }
/^# of unexpected successes/ { xpasscnt += \$5 }
/^# of expected failures/ { xfailcnt += \$5 }
+/^# of unknown successes/ { kpasscnt += \$5 }
/^# of known failures/ { kfailcnt += \$5 }
/^# of untested testcases/ { untstcnt += \$5 }
/^# of unresolved testcases/ { unrescnt += \$5 }
@@ -409,6 +412,7 @@
if (failcnt != 0) printf ("# of unexpected failures\t%d\n", failcnt)
if (xpasscnt != 0) printf ("# of unexpected successes\t%d\n", xpasscnt)
if (xfailcnt != 0) printf ("# of expected failures\t\t%d\n", xfailcnt)
+ if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kfailcnt)
if (kfailcnt != 0) printf ("# of known failures\t\t%d\n", kfailcnt)
if (untstcnt != 0) printf ("# of untested testcases\t\t%d\n", untstcnt)
if (unrescnt != 0) printf ("# of unresolved testcases\t%d\n", unrescnt)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fwd: summarize kfails in dg-extract-results.sh
2013-01-15 17:24 ` Fwd: summarize kfails in dg-extract-results.sh David Blaikie
@ 2013-01-15 20:20 ` Janis Johnson
2013-01-15 22:42 ` David Blaikie
0 siblings, 1 reply; 3+ messages in thread
From: Janis Johnson @ 2013-01-15 20:20 UTC (permalink / raw)
To: David Blaikie; +Cc: gcc-patches, dje
On 01/15/2013 09:24 AM, David Blaikie wrote:
> For some reason KFAILs weren't being summarized by
> dg-extract-results.sh. I assume this was just an oversight, so here's
> a patch to add it alongside all the other result types.
>
> I encountered this in the GDB test suite but was asked to submit the
> change upstream to GCC as GDB would prefer to avoid unnecessary local
> changes to the script & this change seems general enough to go in to
> GCC.
>
> (As was pointed out by Pedro Alves on the gdb-patches list, KFAIL
> support was recently added by Doug Evans (
> http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00996.html ), so KPASS
> support seems like a natural complement)
>
> I'm still a little fuzzy on the specifics of ChangeLog lines, but
> here's my attempt at one for this change:
>
> * dg-extract-results.sh: Handle KPASSes.
OK. I checked it in.
Janis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fwd: summarize kfails in dg-extract-results.sh
2013-01-15 20:20 ` Janis Johnson
@ 2013-01-15 22:42 ` David Blaikie
0 siblings, 0 replies; 3+ messages in thread
From: David Blaikie @ 2013-01-15 22:42 UTC (permalink / raw)
To: janisjo; +Cc: gcc-patches, dje
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
On Tue, Jan 15, 2013 at 12:22 PM, Janis Johnson
<janis_johnson@mentor.com> wrote:
> On 01/15/2013 09:24 AM, David Blaikie wrote:
>> For some reason KFAILs weren't being summarized by
>> dg-extract-results.sh. I assume this was just an oversight, so here's
>> a patch to add it alongside all the other result types.
>>
>> I encountered this in the GDB test suite but was asked to submit the
>> change upstream to GCC as GDB would prefer to avoid unnecessary local
>> changes to the script & this change seems general enough to go in to
>> GCC.
>>
>> (As was pointed out by Pedro Alves on the gdb-patches list, KFAIL
>> support was recently added by Doug Evans (
>> http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00996.html ), so KPASS
>> support seems like a natural complement)
>>
>> I'm still a little fuzzy on the specifics of ChangeLog lines, but
>> here's my attempt at one for this change:
>>
>> * dg-extract-results.sh: Handle KPASSes.
>
> OK. I checked it in.
Thanks - though while reviewing this I realize I'd made a mistake
(even in such a trivial patch - got muddled up somewhere along the way
from GDB 7.5 to GDB ToT to GCC ToT). It was accidentally printing out
the kfail count on the kpass line. Fix attached.
2013-01-15 David Blaikie <dblaikie@gmail.com>
* dg-extract-results.sh: Print KPASS count correctly.
[-- Attachment #2: gcc-extract-kpass.diff --]
[-- Type: application/octet-stream, Size: 1426 bytes --]
Index: contrib/dg-extract-results.sh
===================================================================
--- contrib/dg-extract-results.sh (revision 195219)
+++ contrib/dg-extract-results.sh (working copy)
@@ -370,7 +370,7 @@
if (failcnt != 0) printf ("# of unexpected failures\t%d\n", failcnt)
if (xpasscnt != 0) printf ("# of unexpected successes\t%d\n", xpasscnt)
if (xfailcnt != 0) printf ("# of expected failures\t\t%d\n", xfailcnt)
- if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kfailcnt)
+ if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kpasscnt)
if (kfailcnt != 0) printf ("# of known failures\t\t%d\n", kfailcnt)
if (untstcnt != 0) printf ("# of untested testcases\t\t%d\n", untstcnt)
if (unrescnt != 0) printf ("# of unresolved testcases\t%d\n", unrescnt)
@@ -412,7 +412,7 @@
if (failcnt != 0) printf ("# of unexpected failures\t%d\n", failcnt)
if (xpasscnt != 0) printf ("# of unexpected successes\t%d\n", xpasscnt)
if (xfailcnt != 0) printf ("# of expected failures\t\t%d\n", xfailcnt)
- if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kfailcnt)
+ if (kpasscnt != 0) printf ("# of unknown successes\t\t%d\n", kpasscnt)
if (kfailcnt != 0) printf ("# of known failures\t\t%d\n", kfailcnt)
if (untstcnt != 0) printf ("# of untested testcases\t\t%d\n", untstcnt)
if (unrescnt != 0) printf ("# of unresolved testcases\t%d\n", unrescnt)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-15 22:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAENS6EsZS0tt1CboNDZQ--mgU9rySZfChRkUQJz4ZYq8ob0v+Q@mail.gmail.com>
2013-01-15 17:24 ` Fwd: summarize kfails in dg-extract-results.sh David Blaikie
2013-01-15 20:20 ` Janis Johnson
2013-01-15 22:42 ` David Blaikie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).