From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17509 invoked by alias); 15 Jan 2013 22:42:48 -0000 Received: (qmail 17500 invoked by uid 22791); 15 Jan 2013 22:42:47 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 22:42:01 +0000 Received: by mail-vb0-f41.google.com with SMTP id l22so710075vbn.28 for ; Tue, 15 Jan 2013 14:42:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.115.72 with SMTP id h8mr106024776vcq.43.1358289720278; Tue, 15 Jan 2013 14:42:00 -0800 (PST) Received: by 10.220.150.82 with HTTP; Tue, 15 Jan 2013 14:41:59 -0800 (PST) In-Reply-To: <50F5BA68.7060702@mentor.com> References: <50F5BA68.7060702@mentor.com> Date: Tue, 15 Jan 2013 22:42:00 -0000 Message-ID: Subject: Re: Fwd: summarize kfails in dg-extract-results.sh From: David Blaikie To: janisjo@codesourcery.com Cc: gcc-patches , dje Content-Type: multipart/mixed; boundary=f46d04389455477dc204d35b78a6 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00817.txt.bz2 --f46d04389455477dc204d35b78a6 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1338 On Tue, Jan 15, 2013 at 12:22 PM, Janis Johnson wrote: > On 01/15/2013 09:24 AM, David Blaikie wrote: >> For some reason KFAILs weren't being summarized by >> dg-extract-results.sh. I assume this was just an oversight, so here's >> a patch to add it alongside all the other result types. >> >> I encountered this in the GDB test suite but was asked to submit the >> change upstream to GCC as GDB would prefer to avoid unnecessary local >> changes to the script & this change seems general enough to go in to >> GCC. >> >> (As was pointed out by Pedro Alves on the gdb-patches list, KFAIL >> support was recently added by Doug Evans ( >> http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00996.html ), so KPASS >> support seems like a natural complement) >> >> I'm still a little fuzzy on the specifics of ChangeLog lines, but >> here's my attempt at one for this change: >> >> * dg-extract-results.sh: Handle KPASSes. > > OK. I checked it in. Thanks - though while reviewing this I realize I'd made a mistake (even in such a trivial patch - got muddled up somewhere along the way from GDB 7.5 to GDB ToT to GCC ToT). It was accidentally printing out the kfail count on the kpass line. Fix attached. 2013-01-15 David Blaikie * dg-extract-results.sh: Print KPASS count correctly. --f46d04389455477dc204d35b78a6 Content-Type: application/octet-stream; name="gcc-extract-kpass.diff" Content-Disposition: attachment; filename="gcc-extract-kpass.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hbzmjf6v0 Content-length: 1936 SW5kZXg6IGNvbnRyaWIvZGctZXh0cmFjdC1yZXN1bHRzLnNoCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGNvbnRyaWIvZGctZXh0cmFjdC1yZXN1bHRz LnNoCShyZXZpc2lvbiAxOTUyMTkpCisrKyBjb250cmliL2RnLWV4dHJhY3Qt cmVzdWx0cy5zaAkod29ya2luZyBjb3B5KQpAQCAtMzcwLDcgKzM3MCw3IEBA CiAgIGlmIChmYWlsY250ICE9IDApIHByaW50ZiAoIiMgb2YgdW5leHBlY3Rl ZCBmYWlsdXJlc1x0JWRcbiIsIGZhaWxjbnQpCiAgIGlmICh4cGFzc2NudCAh PSAwKSBwcmludGYgKCIjIG9mIHVuZXhwZWN0ZWQgc3VjY2Vzc2VzXHQlZFxu IiwgeHBhc3NjbnQpCiAgIGlmICh4ZmFpbGNudCAhPSAwKSBwcmludGYgKCIj IG9mIGV4cGVjdGVkIGZhaWx1cmVzXHRcdCVkXG4iLCB4ZmFpbGNudCkKLSAg aWYgKGtwYXNzY250ICE9IDApIHByaW50ZiAoIiMgb2YgdW5rbm93biBzdWNj ZXNzZXNcdFx0JWRcbiIsIGtmYWlsY250KQorICBpZiAoa3Bhc3NjbnQgIT0g MCkgcHJpbnRmICgiIyBvZiB1bmtub3duIHN1Y2Nlc3Nlc1x0XHQlZFxuIiwg a3Bhc3NjbnQpCiAgIGlmIChrZmFpbGNudCAhPSAwKSBwcmludGYgKCIjIG9m IGtub3duIGZhaWx1cmVzXHRcdCVkXG4iLCBrZmFpbGNudCkKICAgaWYgKHVu dHN0Y250ICE9IDApIHByaW50ZiAoIiMgb2YgdW50ZXN0ZWQgdGVzdGNhc2Vz XHRcdCVkXG4iLCB1bnRzdGNudCkKICAgaWYgKHVucmVzY250ICE9IDApIHBy aW50ZiAoIiMgb2YgdW5yZXNvbHZlZCB0ZXN0Y2FzZXNcdCVkXG4iLCB1bnJl c2NudCkKQEAgLTQxMiw3ICs0MTIsNyBAQAogICBpZiAoZmFpbGNudCAhPSAw KSBwcmludGYgKCIjIG9mIHVuZXhwZWN0ZWQgZmFpbHVyZXNcdCVkXG4iLCBm YWlsY250KQogICBpZiAoeHBhc3NjbnQgIT0gMCkgcHJpbnRmICgiIyBvZiB1 bmV4cGVjdGVkIHN1Y2Nlc3Nlc1x0JWRcbiIsIHhwYXNzY250KQogICBpZiAo eGZhaWxjbnQgIT0gMCkgcHJpbnRmICgiIyBvZiBleHBlY3RlZCBmYWlsdXJl c1x0XHQlZFxuIiwgeGZhaWxjbnQpCi0gIGlmIChrcGFzc2NudCAhPSAwKSBw cmludGYgKCIjIG9mIHVua25vd24gc3VjY2Vzc2VzXHRcdCVkXG4iLCBrZmFp bGNudCkKKyAgaWYgKGtwYXNzY250ICE9IDApIHByaW50ZiAoIiMgb2YgdW5r bm93biBzdWNjZXNzZXNcdFx0JWRcbiIsIGtwYXNzY250KQogICBpZiAoa2Zh aWxjbnQgIT0gMCkgcHJpbnRmICgiIyBvZiBrbm93biBmYWlsdXJlc1x0XHQl ZFxuIiwga2ZhaWxjbnQpCiAgIGlmICh1bnRzdGNudCAhPSAwKSBwcmludGYg KCIjIG9mIHVudGVzdGVkIHRlc3RjYXNlc1x0XHQlZFxuIiwgdW50c3RjbnQp CiAgIGlmICh1bnJlc2NudCAhPSAwKSBwcmludGYgKCIjIG9mIHVucmVzb2x2 ZWQgdGVzdGNhc2VzXHQlZFxuIiwgdW5yZXNjbnQpCg== --f46d04389455477dc204d35b78a6--