From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 7FF913857C65; Mon, 15 Aug 2022 14:08:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FF913857C65 Received: by mail-ej1-x62e.google.com with SMTP id qn6so13681703ejc.11; Mon, 15 Aug 2022 07:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=kqbPpjYXPfqK5bbr+XNuVN/uYVJyeKhcaVvYNa3GrgQ=; b=ZPtivRsDX95SFIruQ0eaIcnnsAczgg36psgDMR3+oiaPPUiizuV3QD9f4cTxAKytnf E7SaH3WbD5qQ/DKV5DVvtl7QCdmPGf74gVcQMqtc4BvRXXKBrgW8x8TnNoj6a9D+p//B 3AD0s6rFSfIk+8frkPR4AbiJLDcfdaRjehx2TUM/KMuxBjdIyjvfsuJP1HvhxiaqjXkr OyufIQZ20iij3QO+jrfIEV5CP5H5bLLGLUb4SjXMH20bNMwOIeYWqRw4rzlaITweibPA XrqS9XtaF/9JBxfMWUQbCXYY9pyiPw+kh5c9C4a2kvCnXSSA7NQC+ogSNLxHGGNpO/sr zAcw== X-Gm-Message-State: ACgBeo2mBHmaXI/tcn9jsG/F2/xgkSjUzdEPTMj+L9FOYE5sJTZRObSw dM90qltqA9Mcv65baJvtgd2sH4mR3FL+QulGQjI= X-Google-Smtp-Source: AA6agR5l8s4r+IWnwr5rcGjfn41iAOHmI2U2mY7EGPJmFvblUqNQZhRrGOhYjUkO0yTCGWxg0SgXKl3Cz51C3gABYVM= X-Received: by 2002:a17:907:69b0:b0:730:c511:c856 with SMTP id ra48-20020a17090769b000b00730c511c856mr10502872ejc.240.1660572504106; Mon, 15 Aug 2022 07:08:24 -0700 (PDT) MIME-Version: 1.0 References: <20220727134040.843750-1-philip.herron@embecosm.com> <52031efabcd85759ff3bf3a4d0c6a4ff0b47128e.camel@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= Date: Mon, 15 Aug 2022 16:07:47 +0200 Message-ID: Subject: Re: Rust frontend patches v1 To: Philip Herron Cc: Gcc Patch List , =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 14:08:27 -0000 Dear Philip, Another thing to pay attention to is the move to Sphinx for documentation: https://gcc.gnu.org/pipermail/gcc/2022-August/239233.html Best, Manuel. On Wed, 10 Aug 2022 at 20:57, Philip Herron wrote: > Hi everyone > > For my v2 of the patches, I've been spending a lot of time ensuring > each patch is buildable. It would end up being simpler if it was > possible if each patch did not have to be like this so I could split > up the front-end in more patches. Does this make sense? In theory, > when everything goes well, does this still mean that we can merge in > one commit, or should it follow a series of buildable patches? I've > received feedback that it might be possible to ignore making each > patch an independent chunk and just focus on splitting it up as small > as possible even if they don't build. > > I hope this makes sense. > > Thanks > > --Phil > > On Thu, 28 Jul 2022 at 10:39, Philip Herron > wrote: > > > > Thanks, for confirming David. I think it was too big in the end. I was > > trying to figure out how to actually split that up but it seems > > reasonable that I can split up the front-end patches into patches for > > each separate pass in the compiler seems like a reasonable approach > > for now. > > > > --Phil > > > > On Wed, 27 Jul 2022 at 17:45, David Malcolm wrote: > > > > > > On Wed, 2022-07-27 at 14:40 +0100, herron.philip--- via Gcc-patches > > > wrote: > > > > This is the initial version 1 patch set for the Rust front-end. There > > > > are more changes that need to be extracted out for all the target > > > > hooks we have implemented. The goal is to see if we are implementing > > > > the target hooks information for x86 and arm. We have more patches > > > > for the other targets I can add in here but they all follow the > > > > pattern established here. > > > > > > > > Each patch is buildable on its own and rebased ontop of > > > > 718cf8d0bd32689192200d2156722167fd21a647. As for ensuring we keep > > > > attribution for all the patches we have received in the front-end > > > > should we create a CONTRIBUTOR's file inside the front-end folder? > > > > > > > > Note thanks to Thomas Schwinge and Mark Wielaard, we are keeping a > > > > branch up to date with our code on: > > > > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master > > > > but this is not rebased ontop of gcc head. > > > > > > > > Let me know if I have sent these patches correctly or not, this is a > > > > learning experience with git send-email. > > > > > > > > [PATCH Rust front-end v1 1/4] Add skeleton Rust front-end folder > > > > [PATCH Rust front-end v1 2/4] Add Rust lang TargetHooks for i386 and > > > > [PATCH Rust front-end v1 3/4] Add Rust target hooks to ARM > > > > [PATCH Rust front-end v1 4/4] Add Rust front-end and associated > > > > > > FWIW it looks like patch 4 of the kit didn't make it (I didn't get a > > > copy and I don't see it in the archives). > > > > > > Maybe it exceeded a size limit? If so, maybe try splitting it up into > > > more patches. > > > > > > Dave > > > >