From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-407870-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4800 invoked by alias); 20 Sep 2015 18:25:15 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 4783 invoked by uid 89); 20 Sep 2015 18:25:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-wi0-f179.google.com
Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 20 Sep 2015 18:25:13 +0000
Received: by wicfx3 with SMTP id fx3so119139299wic.1;        Sun, 20 Sep 2015 11:25:11 -0700 (PDT)
X-Received: by 10.180.206.45 with SMTP id ll13mr9008348wic.6.1442773510939; Sun, 20 Sep 2015 11:25:10 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.28.186.214 with HTTP; Sun, 20 Sep 2015 11:24:31 -0700 (PDT)
In-Reply-To: <CAESRpQBH_-vymM7ugmvLG7BWptVpup9i7Sm9t2L71_aSTq==vA@mail.gmail.com>
References: <CAESRpQBH_-vymM7ugmvLG7BWptVpup9i7Sm9t2L71_aSTq==vA@mail.gmail.com>
From: =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= <lopezibanez@gmail.com>
Date: Sun, 20 Sep 2015 19:14:00 -0000
Message-ID: <CAESRpQAPYKZv04r7OvNebWGouzNQiRDaU3bg41QsutBdRf=NNg@mail.gmail.com>
Subject: Re: PR pretty-print/67567 do not pass NULL as a string
To: Gcc Patch List <gcc-patches@gcc.gnu.org>, 	"fortran@gcc.gnu.org List" <fortran@gcc.gnu.org>, "Joseph S. Myers" <joseph@codesourcery.com>, 	Dodji Seketeli <dodji@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2015-09/txt/msg01495.txt.bz2

PING: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01219.html

On 16 September 2015 at 19:45, Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez
<lopezibanez@gmail.com> wrote:
> Fortran passes NULL where a non-null string is expected by the pretty-pri=
nter,
> which causes a sanitizer warning. This could have been found earlier by u=
sing
> gcc_checking_assert. Even if the assertion is false, the result is just an
> incomplete diagnostic, thus it seems more user-friendly to assert only wh=
en
> checking. I do not have any idea how to properly fix the Fortran bug, thu=
s this
> patch simply works-around it.
>
> Bootstrapped & regtested on x86_64-linux-gnu.
>
> OK?
>
> gcc/fortran/ChangeLog:
>
> 2015-09-15  Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez  <manu@gcc.gnu.org>
>
>     PR pretty-print/67567
>     * resolve.c (resolve_fl_procedure): Work-around when iface->module
>     =3D=3D NULL.
>
> gcc/ChangeLog:
>
> 2015-09-15  Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez  <manu@gcc.gnu.org>
>
>     PR pretty-print/67567
>     * pretty-print.c (pp_string): Add gcc_checking_assert.
>     * pretty-print.h (output_buffer_append_r): Likewise.