From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: Jason Merrill <jason@redhat.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
"fortran@gcc.gnu.org List" <fortran@gcc.gnu.org>,
Dodji Seketeli <dodji@redhat.com>,
Tobias Burnus <burnus@net-b.de>, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C (try 2)
Date: Tue, 11 Nov 2014 23:10:00 -0000 [thread overview]
Message-ID: <CAESRpQBhZwO_-br+WMEteBwyvsfU4jNQgFm+G+WP83-yanVquw@mail.gmail.com> (raw)
In-Reply-To: <54623509.7080408@redhat.com>
On 11 November 2014 17:10, Jason Merrill <jason@redhat.com> wrote:
> On 10/31/2014 10:01 PM, Manuel López-Ibáñez wrote:
>>
>> + sense. So let's live the location intact in that case. */
>
>
> s/live/leave/
>
>> + /* If MAP is not the last line map of its set, then the new location
>> + (loc + offset) should be less than the first location encoded by
>> + the next line map of the set. */
>
>
>> + linemap_assert (MAP_START_LOCATION (&map[1]) < loc + offset);
>
>
> This comparison looks backwards from the comment.
Copy-paste error. In any case, this check is currently pointless,
since Fortran only has one map per set. I fixed this and tested
Fortran again just in case. No failures, thus I committed the whole
thing as http://gcc.gnu.org/r217383.
Cheers,
Manuel.
prev parent reply other threads:[~2014-11-11 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 2:02 Manuel López-Ibáñez
2014-11-11 16:25 ` Jason Merrill
2014-11-11 23:10 ` Manuel López-Ibáñez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAESRpQBhZwO_-br+WMEteBwyvsfU4jNQgFm+G+WP83-yanVquw@mail.gmail.com \
--to=lopezibanez@gmail.com \
--cc=burnus@net-b.de \
--cc=dodji@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).