From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-381009-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 2811 invoked by alias); 17 Oct 2014 18:40:12 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 2799 invoked by uid 89); 17 Oct 2014 18:40:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wi0-f172.google.com
Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 17 Oct 2014 18:40:10 +0000
Received: by mail-wi0-f172.google.com with SMTP id n3so2813286wiv.5        for <gcc-patches@gcc.gnu.org>; Fri, 17 Oct 2014 11:40:07 -0700 (PDT)
X-Received: by 10.194.23.104 with SMTP id l8mr12353047wjf.26.1413571207705; Fri, 17 Oct 2014 11:40:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.217.80.73 with HTTP; Fri, 17 Oct 2014 11:39:47 -0700 (PDT)
In-Reply-To: <CAESRpQCFoyY3OUkCz0Va1nd2gDStKikJF-nLanCL9+_J=TZniw@mail.gmail.com>
References: <CAESRpQD_o8FQ2KBVp0JbygZC9-95TdoUi3w=6He7KY_TAEtd2g@mail.gmail.com> <Pine.LNX.4.64.1410171733100.22473@digraph.polyomino.org.uk> <CAESRpQCFoyY3OUkCz0Va1nd2gDStKikJF-nLanCL9+_J=TZniw@mail.gmail.com>
From: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= <lopezibanez@gmail.com>
Date: Fri, 17 Oct 2014 19:26:00 -0000
Message-ID: <CAESRpQBuxPhAenanpjwwXQm5DvevE+Vvh31wiavUsSpa=2NKRg@mail.gmail.com>
Subject: Re: C/C++ diagnostics guidelines (was: Re: [C PATCH] Enable initializing statics with COMPOUND_LITERAL_EXPR in C99 (PR c/63567))
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>, Marek Polacek <polacek@redhat.com>, 	Paolo Carlini <paolo.carlini@oracle.com>, Jason Merrill <jason@redhat.com>, 	Dodji Seketeli <dodji@redhat.com>, Jonathan Wakely <jwakely.gcc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2014-10/txt/msg01784.txt.bz2

On 17 October 2014 20:04, Manuel L=F3pez-Ib=E1=F1ez <lopezibanez@gmail.com>=
 wrote:
> On 17 October 2014 19:33, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> On Fri, 17 Oct 2014, Manuel L=F3pez-Ib=E1=F1ez wrote:
>>
>>> Thus, I drafted some guidelines
>>> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines
>>>
>>> Please, could you take a look and comment whether I got it right/wrong?
>>
>> Yes, that looks right to me.
>
> Thanks!
>
> I added guidelines also about locations and warning options.

I believe there are also some rules about when to use some special
line-map functions that arise when warning about macros like NULL, but
I am not aware of the specifics. It would be useful if someone added
those.

Dodji, Paolo? Do you know what I'm talking about?

Cheers,

Manuel.