public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "Gcc Patch List" <gcc-patches@gcc.gnu.org>,
	"Jeff Law" <law@redhat.com>,
	"Илья Энкович" <enkovich.gnu@gmail.com>
Subject: Re: [PATCH opt*.awk/middle-end] Detect wrong arguments to EnabledBy
Date: Sun, 09 Aug 2015 19:32:00 -0000	[thread overview]
Message-ID: <CAESRpQC20SZ3-ZOAVc2cis3CFja=1mSK29ZrKd-7GwBWS-hRfQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1508091429130.17217@digraph.polyomino.org.uk>

On 9 August 2015 at 16:29, Joseph Myers <joseph@codesourcery.com> wrote:
> On Sat, 8 Aug 2015, Manuel López-Ibáñez wrote:
>
>> The argument to EnabledBy() must be one or more options with the
>> Common flag, otherwise the setting is silently ignored. This patch
>> detects this case when generating the options.c file and gives an
>> appropriate error. There were two options suffering from this: -Wchkp
>> is fixed by using LangEnabledBy instead, but -Wnull-dereference cannot
>> be enabled by -Wall or -Wextra because it triggers false positives
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351#c35)
>>
>> Bootstrapped and regression tested on x86_64-linux-gnu.
>>
>> OK?
>
> OK with the requirement that the options have the Common flag being added
> to the documentation of EnabledBy in options.texi.

Done. Committed as https://gcc.gnu.org/r226751

Cheers,

Manuel.

      reply	other threads:[~2015-08-09 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-08  9:00 Manuel López-Ibáñez
2015-08-09 14:30 ` Joseph Myers
2015-08-09 19:32   ` Manuel López-Ibáñez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAESRpQC20SZ3-ZOAVc2cis3CFja=1mSK29ZrKd-7GwBWS-hRfQ@mail.gmail.com' \
    --to=lopezibanez@gmail.com \
    --cc=enkovich.gnu@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).