From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Bernd Schmidt <bschmidt@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix -Werror= handling for Joined warnings, add a few missing Warning keywords (PRs c/48088, c/68657)
Date: Fri, 04 Dec 2015 18:20:00 -0000 [thread overview]
Message-ID: <CAESRpQD+QSoNQXBKqtJAtX91khmsbyR7OWH+gV2n6PGmh3rmng@mail.gmail.com> (raw)
In-Reply-To: <20151204175343.GR5675@tucnak.redhat.com>
On 4 December 2015 at 17:53, Jakub Jelinek <jakub@redhat.com> wrote:
> +
> + if (e->unknown_error)
> + error_at (loc, e->unknown_error, option->opt_text);
> + else
> + error_at (loc, "unrecognized argument in option %qs",
> + option->opt_text);
The same code that handles command-line options has:
if (e->unknown_error)
error_at (loc, e->unknown_error, decoded->arg);
else
error_at (loc, "unrecognized argument in option %qs", opt);
My guess is that the first error_at should use arg instead of
option->opt_text to be equivalent. Of course, ideally, this code would
not be duplicated, but rather merged "somehow".
Cheers,
Manuel.
next prev parent reply other threads:[~2015-12-04 18:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 16:37 Jakub Jelinek
2015-12-04 17:02 ` Bernd Schmidt
2015-12-04 17:53 ` Jakub Jelinek
2015-12-04 18:20 ` Manuel López-Ibáñez [this message]
2015-12-04 19:37 ` Jakub Jelinek
2015-12-07 10:24 ` Bernd Schmidt
2015-12-07 13:45 ` Jakub Jelinek
2015-12-07 15:11 ` Bernd Schmidt
2015-12-07 22:42 ` Jakub Jelinek
2015-12-08 11:56 ` Bernd Schmidt
2015-12-11 20:18 ` [PATCH] Fix -Werror= handling with aliases (PR c/68833) Jakub Jelinek
2015-12-14 16:22 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAESRpQD+QSoNQXBKqtJAtX91khmsbyR7OWH+gV2n6PGmh3rmng@mail.gmail.com \
--to=lopezibanez@gmail.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).