From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17721 invoked by alias); 13 Oct 2014 21:02:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17683 invoked by uid 89); 13 Oct 2014 21:02:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 13 Oct 2014 21:02:27 +0000 Received: by mail-wi0-f175.google.com with SMTP id d1so8436215wiv.8 for ; Mon, 13 Oct 2014 14:02:24 -0700 (PDT) X-Received: by 10.180.188.66 with SMTP id fy2mr1266519wic.27.1413234144146; Mon, 13 Oct 2014 14:02:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.217.80.73 with HTTP; Mon, 13 Oct 2014 14:02:03 -0700 (PDT) In-Reply-To: <543C1F7E.9080001@redhat.com> References: <044D8CC4-A3A3-4B5A-9D9A-FB01FB845131@gmail.com> <543C1F7E.9080001@redhat.com> From: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= Date: Mon, 13 Oct 2014 21:05:00 -0000 Message-ID: Subject: Re: [PATCH] cleanup in c-parser To: Jeff Law Cc: Anthony Brandon , "gcc-patches@gcc.gnu.org" , =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2014-10/txt/msg01195.txt.bz2 On 13 October 2014 20:52, Jeff Law wrote: > On 10/13/14 05:11, Anthony Brandon wrote: >> >> I updated the patch with a comment. Actually, Manuel handed me this >> patch just to help me get familiar with the process of submitting and >> testing. >> Generating this one with git diff looks different so I'm not sure if >> that's a problem or not. > > This version is fine. Please install on the trunk. Committed as revision https://gcc.gnu.org/r216165 Congratulations Anthony, you cleared the tutorial level! Have you decided what are you going to fix next? Cheers, Manuel.