From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 3B6B33898519 for ; Sat, 26 Nov 2022 08:27:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B6B33898519 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id x102so9161401ede.0 for ; Sat, 26 Nov 2022 00:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=emba5hSgywe4HvLlb5Tf7xriut69L0eTdweersqazTA=; b=lJnoDNnKXTVrcGMKTGYMNe0XU5pRNMQnTEWVwM/1zP1/TDwk4a2pGpFV1DgjY4IVoO OwpJRLlFden+xhVa1JdIhn4HQbNtBBSq9E/zsMCGra403aLFumZJOmrKzB0IbLqRdQ/n pl/jErx1gWw7nL/D8M7fkPuUoJFjEtEnmtPHrCcHbUU0bVZITsO+LyuKbfG8CZZgQp8T MrCwYKCiPV8ouUVLYfWFLKIm8SgSlf06z0BPPZm82MrKujt8fuRmldI5RCX+SpPNJo6u gXLZ+o6W+U5ztmx0SpWCXZW21vJIDgNM2Y6Q6fT2thNCaQ7ylF03XDte9oWS8lpI40Df SFMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=emba5hSgywe4HvLlb5Tf7xriut69L0eTdweersqazTA=; b=dk80uWtMLrCvUltcz2v4ozHpbKJYQBxHLJK7xkEuvjtVCKsDtWhoc+kcfBZllqdgb+ lybqLnCnlMNpJHE+RkvvIEq5Mj8PEi6vH/+bJGsz5uwaqi5NZ0o4QmSa3p6MUCwWhgpd Q7LfbPG3lDRgg/HJHd/i1x1DDQPrQIBdSnKKDf0inC17Q4l3gYADtXILdVJdxS76R2he CBxtWkm9A9xhl11WrmjlDBz+PaVR1j7dkIqLtwSR4iXueT+7UN1oRpIXkFjCVYhNC7gY Y/7PN4e9rSiZ8OpIEsGXs6FtVeFjSd6AK/ctlHdqOJ1wpKNeceTPDzPQyxoQNbtvjd1X Vhrg== X-Gm-Message-State: ANoB5pme45M0+Y8V2NfU+nL/GI+PzUN7SucetyNGCPyFN7J2Y7TPaKk8 qACnNVAu4eUgRT9vkv6HuGtON77RBQy2N65FEOM= X-Google-Smtp-Source: AA0mqf6fQCc4bnVgRVHtFf//Mhhmh8B/XwetaAQy1+9ZWdy0JKsIQdjOimdJLOJDGBPSshZ344SoAGbguF3mGvhs/dc= X-Received: by 2002:a05:6402:1a:b0:467:30ad:c4ca with SMTP id d26-20020a056402001a00b0046730adc4camr39471891edu.285.1669451221817; Sat, 26 Nov 2022 00:27:01 -0800 (PST) MIME-Version: 1.0 References: <9b5cdf691510b783f42d3de6099c5bbe9b931236.camel@xry111.site> In-Reply-To: <9b5cdf691510b783f42d3de6099c5bbe9b931236.camel@xry111.site> From: Zopolis0 Date: Sat, 26 Nov 2022 19:26:50 +1100 Message-ID: Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS. To: Xi Ruoyao Cc: Richard Biener , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > No. Java was removed to reduce the maintenance burden, you can't just > reintroduce the burden and say "hey, I don't want to pay for the burden > so you please do it". There were two sentences there. You appear to only have read the first one. I just took on 6 years of that maintenance burden in 4 months while teaching myself the gcc tree. I can confirm with absolute certainty that the burden would have been pitiful had java been in the tree. Many of the changes were just idiomatic find and replaces that I had to do myself, tracking down the commit that removed or renamed something, in some cases just silently breaking things so I had to bisect 6 years of changes. If Java had been in the tree, it would have introduced a pitiful additional burden. I can think of around 5 changes that I made that would have required something more than just a sed script, and even then those were very simple changes. I am not suggesting that I wish to shift the overall burden of maintenance away from myself, rather that it would be nice if I did not have to track down breaking commits every 3 months, when the author could have very easily included Java in the changes if it was in the tree. > And we are in stage 3 now so it's not possible to merge 50+ patches > (completely not reviewed in stage 1) until GCC 14 stage 1 opens. On a lighter note, this is fair. I was hoping to make the stage 1 window, but with 2 front-ends already in contention I thought my odds of making it in regardless were poor, and I just didn't have the time to fix the last issues. I've sent these patches now so they can get reviewed now, so that they aren't waiting in review limbo when merging is open again.