From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id A720B3898399 for ; Sat, 26 Nov 2022 07:30:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A720B3898399 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id fy37so14564186ejc.11 for ; Fri, 25 Nov 2022 23:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=q62OsHXXXXxhbYch1UxwOCPVEZ32PJg88156lee3pgs=; b=pZYT4wqS9ZVY/5NC3c4EYApHEdQZMdR+XqNO0NFCw5yaMkH+MjLGxMk9pvAbQLNn1T CroU9itvVCV+UsAZi3eIJL9lE15PYc8On7uABuzzv76UEkLz5EppLLqm3fuvyyEcBkwD 08s2FocRYYhxa7f1ZpwnEHY9pRZP0BCo7P/CF6Upq0/VQP09jKjuAKI6faCkp3MJpjD7 i6JMcT7O9pjXHHroAM7WNPZVesLD9t9MM3Di3zAUNSw1Zh3NabP+9oT5UeQh+fu/df2p bR7wGlXsud/JgW1+UsGB9ua+IdGP1KedXLYGss5m8Y8CJPpRPZjL91kbrapGsq3rGOuH K3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q62OsHXXXXxhbYch1UxwOCPVEZ32PJg88156lee3pgs=; b=gFRpkoflgaPEinsMcVRe/OkZfIy/ofScp/VQG8k7QCn3qF2A07zAv3NholASvXAlHP BUCg6Npkl4e8ds9EgxUyGTR5xi94GqyK+ImB/3zpd6Qp+PU5zxkmvoe4naSHKJVTSZnT UmVDKGpmRM5R4ygt6ddqxqbMhzwK4HJDEIpcG3Qm6CwPH7izQyCY2CR1WBFMc2N2jSVl MlQUADOauYX3sQnCxvKpwaXSqL3+h7978B6AJzp+YP1Trjmi/6S9NS6O9RqFJxA0Ftbf v36EE9QQQNj0zMxIeIkvG/JxF0xZh+sMrAKn5+ciUYSISPsj6VlNbkZ7dXqfztYvD7IT ZeYg== X-Gm-Message-State: ANoB5pmEspq3WASCBQqaz3prRhHbWB+bnQQgGp9ZmJWzj+KF/ADG/gqB Jp08k1gDuRaCTdjXlUs1KMnNFT5AbJkX+wNok+Q= X-Google-Smtp-Source: AA0mqf7yK49wDhaknovCYJYNm8j3UOTvaiVV1wMWkwXzoqi/WviL36m05PgCmEziIn3N6dFoVX0FsWGW6inpTktdIDg= X-Received: by 2002:a17:906:6093:b0:78d:b37c:83d9 with SMTP id t19-20020a170906609300b0078db37c83d9mr19652725ejj.637.1669447844158; Fri, 25 Nov 2022 23:30:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Zopolis0 Date: Sat, 26 Nov 2022 18:30:32 +1100 Message-ID: Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS. To: Richard Biener Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > TYPE_METHODS uses the field used by TYPE_BINFO so the patches are related. As the person who wrote the patches, I can confirm that they are not in fact related. Or, at least, they fix different issues and have no reliance upon each other. If you mean related as in they both contain RECORD_OR_UNION_CHECK, sure, but even then they are two very different patches, with one being a temporary stopgap and the other being a thought-through change that solves a large issue with minimal addition and leaves existing functionality intact. > Re-adding a field to all types is a no-go To be entirely honest, my current priority is simply to get this merged so I can spend less time keeping up with upstream changes breaking everything and spend more time actually improving things. The additional labour cost for the maintainer who is making the change and understands it deeply is much less than what it takes for me to bisect the issue, find the commit, understand it and fix the issue. >From my point of view, temporarily re-adding a grand total of two lines is worth that goal. If you consider this a large enough issue that you won't accept that, then let me know so we don't dance around the issue and I can get on with solving the issue.