From: Zopolis0 <creatorsmithmdt@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)
Date: Thu, 15 Dec 2022 10:00:39 +1100 [thread overview]
Message-ID: <CAEYL+X8OonzrvWX35dzmjAwGqqSu+VzEnZv85iCWcbgcje15Cw@mail.gmail.com> (raw)
In-Reply-To: <CAEYL+X9REHFOcg7vjSB34zCQ62dqRdFC_X_sLUD5N3A_wnOrfw@mail.gmail.com>
I had a look-- issue fixed, rough patch below. Full patch will be part of v2.
From b0d93d8212328fabcbdb32c266c265a4eed49e00 Mon Sep 17 00:00:00 2001
From: Maximilian Downey Twiss <creatorsmithmdt@gmail.com>
Date: Thu, 15 Dec 2022 09:54:36 +1100
Subject: [PATCH] java: Adjustments to end_params_node and void_list_node.
gcc/java/ChangeLog:
* builtins.cc (initialize_builtins): Do not set void_list_node to
end_params_node.
* decl.cc (java_init_decl_processing): Set end_params_node to void_list_node.
---
gcc/java/builtins.cc | 2 --
gcc/java/decl.cc | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/gcc/java/builtins.cc b/gcc/java/builtins.cc
index 45d736a0d7b8..a882a5c4d521 100644
--- a/gcc/java/builtins.cc
+++ b/gcc/java/builtins.cc
@@ -499,8 +499,6 @@ initialize_builtins (void)
java_builtins[i].method_name.t = m;
}
- void_list_node = end_params_node;
-
float_ftype_float_float
= build_function_type_list (float_type_node,
float_type_node, float_type_node, NULL_TREE);
diff --git a/gcc/java/decl.cc b/gcc/java/decl.cc
index 6319d1ce18a0..018003104ced 100644
--- a/gcc/java/decl.cc
+++ b/gcc/java/decl.cc
@@ -957,7 +957,7 @@ java_init_decl_processing (void)
build_decl (BUILTINS_LOCATION,
TYPE_DECL, get_identifier ("Method"), method_type_node);
- end_params_node = tree_cons (NULL_TREE, void_type_node, NULL_TREE);
+ end_params_node = void_list_node;
t = build_function_type_list (ptr_type_node, class_ptr_type, NULL_TREE);
alloc_object_node = add_builtin_function ("_Jv_AllocObject", t,
prev parent reply other threads:[~2022-12-14 23:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:40 Zopolis0
2022-11-25 20:17 ` Richard Biener
2022-11-26 1:40 ` Zopolis0
2022-11-26 7:17 ` Richard Biener
2022-11-26 7:35 ` Zopolis0
2022-11-26 7:48 ` Andrew Pinski
2022-11-26 8:41 ` Zopolis0
2022-11-28 8:27 ` Richard Biener
2022-12-02 0:22 ` Zopolis0
2022-12-02 7:43 ` Richard Biener
2022-12-02 7:48 ` Richard Biener
2022-12-02 10:38 ` Zopolis0
2022-12-14 23:00 ` Zopolis0 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYL+X8OonzrvWX35dzmjAwGqqSu+VzEnZv85iCWcbgcje15Cw@mail.gmail.com \
--to=creatorsmithmdt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).