From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YdYP=4A=gmail.com=creatorsmithmdt@sourceware.org>
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b])
	by sourceware.org (Postfix) with ESMTPS id 2AAB33858D32
	for <gcc-patches@gcc.gnu.org>; Fri,  2 Dec 2022 00:23:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AAB33858D32
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ed1-x52b.google.com with SMTP id b8so4463813edf.11
        for <gcc-patches@gcc.gnu.org>; Thu, 01 Dec 2022 16:23:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=Nsq2iHEzpQBeiKL288dFelf7mRuFtihp1vknROekduU=;
        b=ZNC+jyK5AE6+NwpN5ymzPSL6sXt8K2mrgx0oTCk4xapCjqfzcKBAcXJl9p6j+Z4Nmo
         AymQvtXA+gxnj+4YHKcdcz0PURFA1bsXlCQLHP9+kyHZEL4B2S+EfU08FkYH0jxQzVtk
         5YR6oUH6TGFwDbelx0kdhvmMa7cKR/3xJV8qvhgL2jdRcP9bs6T8QpA7ue6M4cV59nCM
         g8X/TX14sOy2AhiIVkVKFJK1QrwjrHpn80TAMzYgFvipf1NrPkJSmscM8gw3rkgZ4MUi
         JBZWUtdewFsiVybQ00mIDXVyknJVQGjx/bRPwgm5NS8/K9OP6t8x5yoMV+pkwISO+dxX
         fFrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=Nsq2iHEzpQBeiKL288dFelf7mRuFtihp1vknROekduU=;
        b=OGkuR+Pot1MOhLZZnZg4phlck2+1UqDPyCUjMPvaksNawe+3AevZMGxOppQB3CvKQu
         o/wYZhjDufnSTv2S0ndKVhioilWIVF3pVNCy/PLuCCfZxlZnS0miFUkE5vY/HzGG0vHp
         +ehfWJ+J/yOZXYbyBdVkaKIWg8p0DhhkksakHREBC9/Q3xlH+QP9gCKpNwBHZdT+f3PE
         w+Ksqt7uVaJfNEHagpmmUoFiEZgm18tzeW6xbxiR0Un6qCQeroQBNDLr9cMEXvij45vA
         m+tY+W5iAKTyaOku8nuJMd3q3CqUaj5ke1iqlxZEb1Y/V3NS4TFbAqYu9rhSnY5D0FOT
         4kbQ==
X-Gm-Message-State: ANoB5pkhP8bdQr5JgcjT6PEuabrFwVz0YJUMUuoHoebvdS1DmyHlU8iN
	9VfggdbjMRCgUyFrA/6NRJKXd0eCNqHtHXSGDrs=
X-Google-Smtp-Source: AA0mqf6CjujMcBtLSAhmtidxgpnSNnuQyz+nLxj2FxafoQJ22U2vXBq9M2nvw257T6NZg1LtT+1RccMhh+q5ZpzjRrE=
X-Received: by 2002:a05:6402:5307:b0:461:e3e1:bc3b with SMTP id
 eo7-20020a056402530700b00461e3e1bc3bmr47853927edb.145.1669940585765; Thu, 01
 Dec 2022 16:23:05 -0800 (PST)
MIME-Version: 1.0
References: <CAEYL+X_ta9=7wKrWZT7TArBiOi79S2WzTtsqOwueUf8Vm2cjvw@mail.gmail.com>
 <8FF347A1-0569-4A57-B0AE-9760A70AA010@gmail.com> <CAEYL+X9rNbOHanPNrYmtGHXMD2NhCWRiyTXkzG=YxOPRZBAUvA@mail.gmail.com>
 <CA+=Sn1njXotzb_bkfZOOhd9MDUEqvLwLS2KCVyFsQ4thWwZTtA@mail.gmail.com>
 <CAEYL+X_dJfJ4gRjUgKnx3TdaqZEWSRV+GBvS4jYeO4Tntya9tg@mail.gmail.com> <CAFiYyc0b9YXc4smF9Vkzqb2qVBiM2DWCnTRj7P6FYy5RHYhq4Q@mail.gmail.com>
In-Reply-To: <CAFiYyc0b9YXc4smF9Vkzqb2qVBiM2DWCnTRj7P6FYy5RHYhq4Q@mail.gmail.com>
From: Zopolis0 <creatorsmithmdt@gmail.com>
Date: Fri, 2 Dec 2022 11:22:56 +1100
Message-ID: <CAEYL+X9mQNwWUr1k8g2LTxG3_NfgMFa-fz3NMcVNeMqARpSv1w@mail.gmail.com>
Subject: Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)
To: Richard Biener <richard.guenther@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

> But that looks like the correct thing to do.

It's not. The patch I reverted changes it so that no matter what,
void_list_node = build_tree_list (NULL_TREE, void_type_node);.

Before, each front-end set it in their own way, but they all set it
via void_list_node = build_tree_list (NULL_TREE, void_type_node); or a
synonym anyway. So while the patch made sense in a java-free context,
given that java sets it a different way, I can't see a world in which
this commit stays active and Java works, unless we find a way to set
it in tree.cc for every language except Java.