From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id A01C4384519F for ; Sat, 26 Nov 2022 01:55:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A01C4384519F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x535.google.com with SMTP id z63so8449770ede.1 for ; Fri, 25 Nov 2022 17:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eB55ANXnlVXHfZZ0bmAvaB/sINbtAH7ncMWE6rMBRPc=; b=RYTKm2NI0Syl7IAixXMda3uXhz/g4xkSS4qggQdCfWg5fNoACJeVlIoFq0nGG2+Jzz 0+RFl7GQZoGDhyQJ2JX2Kos5eBW8yR4iPUfNFU4dwOrF5YxCoZRk6P+x+3rJ1s9QJWH9 YaTg00BKQQSdj1mN1eyS1coFGzcAmsHPRLDFu8Jlr2A2H/02/+hCl3DauyL20tjWwmya havpZMFqQn49GGpjtCyZXHCJ8FnLddKvWIegwR9Hr41Jw9HxLUOUYRFpZGUGVtKiYfyX 9QsygCzys7mYrLUrSx9CFCzoQPTRsgVDv9jE+5n4ugvK1ntFuZzG0WvkHnfhC+WEsKxg amgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eB55ANXnlVXHfZZ0bmAvaB/sINbtAH7ncMWE6rMBRPc=; b=5wS9iyn6bGVLmq89tFkOTQR3dvgBr4f9N2380dRFTpdb3ZCl82ttY0HEtrod/ZFZ+b wrp9UM9tHMtpagPSutRpTP6GuPPdsS7jyqBgBkhlx8IzEyBOnn5rNSLqWxiLdO5xb8P+ DXdG0/CG9OqxU5rrynRxjMXOpkQOY7f/7Y4OiUObzBWnY2vP+l7cAqyIDeQgLSGERagr QUcpX6v5SWDsfj5QQZ9/0U57ol8i2SWP1CnRwPTmq1aKn3a8u1Qu2VUS42dZEQRkl4o+ yCgrPASJlijjK15PjjGXZYn9aH1IyVc16QRSyBeQnOBY99/2FgjFjAQtWpSHnWj0N/dd /G2w== X-Gm-Message-State: ANoB5pl9hHOl1vX/keUmxArJvJL/NDm5DOkNSHv9vnH1RmDS5ClcBhCu tiCL70JeQCXklIOruxYhsgFpKWSlEctmLd4vpeU= X-Google-Smtp-Source: AA0mqf74bXpAH3fsTy2BotMN0Cxtmx07ASJdlaUAe0JuAtMn+JR7lD8L83FpCETLX+f13qw3IZsk2maJhsUkVuqe/D0= X-Received: by 2002:a05:6402:360b:b0:468:f365:dca with SMTP id el11-20020a056402360b00b00468f3650dcamr1731812edb.41.1669427705180; Fri, 25 Nov 2022 17:55:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Zopolis0 Date: Sat, 26 Nov 2022 12:54:54 +1100 Message-ID: Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS. To: Richard Biener Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Oh wait wrong patch. You talking about binfo confused me. Anyways, I re-added this because replacing Java's usage of TYPE_METHODS with TYPE_FIELDS even when I properly checked for different types of functions still broke things, so I added this as a stopgap. No idea what you are talking about with binfo though, I added binfo for the reasons you can see in the email above, nothing to do with TYPE_METHODS. On Sat, Nov 26, 2022 at 11:16 AM Zopolis0 wrote: > > Because the frontend uses TYPE_BINFO specifically. It expects a TYPE_BINFO that writes to this value, and will break with replacements. I have tried a number of alternatives, and this is what works. > > I can't use lang_1 because other frontends use it in ways that java doesn't expect and I can't create a replacement for TYPE_BINFO because then it won't have the regular checks that TYPE_BINFO has. > > I couldn't find a better solution because I'm not particularly versed with the internal workings of gcc, if you can think of a better idea feel free to let me know. > > On Sat, 26 Nov 2022 at 07:20, Richard Biener wrote: >> >> On Fri, Nov 25, 2022 at 9:55 AM Zopolis0 via Gcc-patches >> wrote: >> > >> >> Why add this when nothing uses it and you need to re-add binfo because >> of this? If the frontend uses >> it then add it to lang_type.