From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 2B9303858D1E for ; Mon, 17 Jul 2023 08:11:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B9303858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso4021279f8f.0 for ; Mon, 17 Jul 2023 01:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1689581505; x=1692173505; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=adVyGdx3yewLos1vAQdyEpzXPpVKlp541Pj48IFMcT4=; b=ggUW4wJiaGaYk7ebNJvLmUeN1QOsAKL177qKmleyA3MsrerlpT3rmv8OBUOwBR4Yfs IwuhjIZQt3wKGJ3Pus+ngDywZhsf11hPCVsgQB+mWDNHx6zkkSrEpLLs/kafJJ9rnAk6 sn80l5FC9BbYTsG3JGwDmVklVAcYDpfJOGjk2D3IT3iHqGqTErwZh5wwARFz4SK89Tfq RAIE+3X04YQUZQIpDib+KmRJzFw6D55rhlTplslGCxClbvCiMm1nyMkT/GGY/GrrUmfn 9UQXCN8obG6rmvMt8v12lhsWY5SQACYBpsH2vn3iliU5plv/CSBSw6W8kH0kY1RxZZ6f 5/Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689581505; x=1692173505; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=adVyGdx3yewLos1vAQdyEpzXPpVKlp541Pj48IFMcT4=; b=NBM84I4kNH0GuZxnOFnxjJzJbKAniCGV2nH8z33weDIpJErpfFZ1AvnaNODMWb2tk3 g1Dl1J7LpFZtjlO7oMCL8Xdip6T0PqRpC+NXWPKJ2EgOomfaMJS6vxAmH+5sZ6bL/8Sy 68pg0v2O3oQcsbUpxNvb/brjKzxX+m4ZhQXDqWoEOYeJuep5BPN2pUiUAYQ+U3lHW8YD plD1QS0/1Fqhk8Aqo9pmTL+q9Vmao08quvuv7pGTjhT4HBrjxCE94kgeJ7l4tERAZYBt bfKh+RJkTSdVOUScdlkdIybwxqgeuDcBZozNEf9XBPdhluwjAQM6Vk113WhGxsWh2Ak5 7ihw== X-Gm-Message-State: ABy/qLbpmPRS/BFT0gH7BK5KQIMuLc3xTHLFYW1TjioSSjGVapurVW6z 2Tq4eniugpKx8Arr3PX++6QGzizxc3NgaUlQEp285Q== X-Google-Smtp-Source: APBJJlHxziHYHHm7Wa/FUd/X8YexjkEOWqz3rxMVHo1+V3aKhn6EemCT7nKi841BV4twQKkwTTwHpSCQlYu6+zAhBJ0= X-Received: by 2002:a5d:5088:0:b0:314:53b5:92d5 with SMTP id a8-20020a5d5088000000b0031453b592d5mr9191369wrt.36.1689581504792; Mon, 17 Jul 2023 01:11:44 -0700 (PDT) MIME-Version: 1.0 References: <20230712081314.F1263385800C@sourceware.org> <87351qpz1c.fsf@igel.home> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Mon, 17 Jul 2023 10:11:32 +0200 Message-ID: Subject: Re: [gcc r14-2455] riscv: Prepare backend for index registers To: Andrew Pinski Cc: Andreas Schwab , Kito Cheng , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 17, 2023 at 9:31=E2=80=AFAM Andrew Pinski w= rote: > > On Sun, Jul 16, 2023 at 11:49=E2=80=AFPM Christoph M=C3=BCllner > wrote: > > > > On Fri, Jul 14, 2023 at 12:28=E2=80=AFPM Andreas Schwab wrote: > > > > > > Why didn't you test that? > > > > Thanks for reporting, and sorry for introducing this warning. > > > > I test all patches before sending them. > > In the case of RISC-V backend patches, I build a 2-stage > > cross-toolchain and run all regression tests for RV32 and RV64 (using > > QEMU). > > Testing is done with and without patches applied to identify regression= s. > > > > The build process shows a lot of warnings. Therefore I did not > > investigate finding a way to use -Werror. > > This means that looking for compiler warnings is a manual step, and I > > might miss one while scrolling through the logs. > > If you are building a cross compiler, and want to clean up warnings, > first build a native compiler and then build the cross using that. Ok, will adjust my workflow accordingly. > Also maybe it is finding a way to do native bootstraps on riscv to do > testing of patches rather than doing just cross builds when testing > backend patches. > Especially when I have found the GCC testsuite but the bootstrap is > more likely to find backend issues and such. Yes, using the patch-under-testing to build a toolchain can identify issues that the testsuite can't find. I did that a couple of times in a QEMU environment, but I prefer the cross-toolchain approach because it is faster. For patches that have a bigger impact, I test the toolchain with SPEC CPU 2017. Thanks, Christoph > > Thanks, > Andrew > > > > > Sorry for the inconvenience, > > Christoph > > > > > > > > > > ../../gcc/config/riscv/riscv.cc: In function 'int riscv_regno_ok_for_= index_p(int)': > > > ../../gcc/config/riscv/riscv.cc:864:33: error: unused parameter 'regn= o' [-Werror=3Dunused-parameter] > > > 864 | riscv_regno_ok_for_index_p (int regno) > > > | ~~~~^~~~~ > > > cc1plus: all warnings being treated as errors > > > make[3]: *** [Makefile:2499: riscv.o] Error 1 > > > > > > -- > > > Andreas Schwab, schwab@linux-m68k.org > > > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA= AEC1 > > > "And now for something completely different."