From: "Christoph Müllner" <christoph.muellner@vrull.eu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Kito Cheng" <kito.cheng@gmail.com>,
"Jin Ma" <jinma@linux.alibaba.com>,
"GCC Patches" <gcc-patches@gcc.gnu.org>,
"Jeff Law" <jeffreyalaw@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"richard.sandiford" <richard.sandiford@arm.com>,
"Robin Dapp" <rdapp.gcc@gmail.com>, 钟居哲 <juzhe.zhong@rivai.ai>,
"jinma.contrib" <jinma.contrib@gmail.com>
Subject: Re: [PATCH v2] RISC-V: THEAD: Fix improper immediate value for MODIFY_DISP instruction on 32-bit systems.
Date: Mon, 5 Feb 2024 13:00:20 +0100 [thread overview]
Message-ID: <CAEg0e7gKE0N3AA-6cmN5a3zbvWjQvC4VLHDo2VpeJjLwuv_6mA@mail.gmail.com> (raw)
In-Reply-To: <87il35itf2.fsf@igel.home>
On Sat, Feb 3, 2024 at 2:11 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Jan 30 2024, Christoph Müllner wrote:
>
> > retested
>
> Nope.
Sorry for this.
I tested for no regressions in the test suite with a cross-build and
QEMU and did not do a Werror bootstrap build.
I'll provide a fix for this later today (also breaking the line as it
is longer than needed).
>
> ../../gcc/config/riscv/thead.cc:1144:22: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
> 1144 | fprintf (file, "(%s),"HOST_WIDE_INT_PRINT_DEC",%u", reg_names[REGNO (addr.reg)],
> | ^
> cc1plus: all warnings being treated as errors
> make[3]: *** [../../gcc/config/riscv/t-riscv:127: thead.o] Error 1
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
next prev parent reply other threads:[~2024-02-05 12:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 9:20 [PATCH] " Jin Ma
2024-01-29 9:23 ` Andrew Pinski
2024-01-29 9:36 ` Jin Ma
2024-01-29 9:57 ` [PATCH v2] " Jin Ma
2024-01-29 12:32 ` Kito Cheng
2024-01-30 6:40 ` Christoph Müllner
2024-02-03 13:11 ` Andreas Schwab
2024-02-05 12:00 ` Christoph Müllner [this message]
2024-02-05 14:56 ` Jeff Law
2024-02-05 15:08 ` Andreas Schwab
2024-02-05 15:34 ` Jeff Law
2024-02-05 15:39 ` Andreas Schwab
2024-02-05 23:23 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEg0e7gKE0N3AA-6cmN5a3zbvWjQvC4VLHDo2VpeJjLwuv_6mA@mail.gmail.com \
--to=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jinma.contrib@gmail.com \
--cc=jinma@linux.alibaba.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=rdapp.gcc@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).