From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 4A2843830B04 for ; Mon, 14 Nov 2022 19:07:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A2843830B04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-pl1-x62d.google.com with SMTP id d20so10914012plr.10 for ; Mon, 14 Nov 2022 11:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sYa9D+mgjBW8npU4Rn+VnYrrCJbjYLzDSPX0+E9V7CU=; b=olhThd50Q7TQKFvHBKc1BaWjxpZmze+6Wn3lWYPFd+E+PlyU6Y5fAqH+HS2IsZGEOm yTwgzopdfzs3rlpVFY59DCcM6SqN3YdZdnGpnIdt3QzmDN2iH0AmtbpvuaxR7mElpGd9 mSUze5FpRHJACkd/xtVgP2oK8oJmJR4/kR0MrTp7GhIzQe9vpWCafGgf5N5fSZWbGYJ9 MzZRlEBihhOY4UdhF/0GwNOT/WhicJFZbITakmKIOQru58jQ3P/wbPhwH6AIN3Cjk0qb j8VennUPgZzJci/MHISr65QffBFnhFHcN9sCD2myM/42KEqh/k6QiOop6hSZncaPXmaT ymSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sYa9D+mgjBW8npU4Rn+VnYrrCJbjYLzDSPX0+E9V7CU=; b=XvraEknmK74kWkPMxJvD0wX1zZeh3z3uw3UOxaArrF8XnqqfEeowtESnbldzs2uw65 Min545A1yrjhTJPtoDSNjJhEumzbd8fZaujxru2zRicunSFUSm3IHFH95271bIOpV770 j2NuW8PJC9Pntehewfe6okzRTTFcL06VQWlirJOIzS903o8a9+2VAY6fDQBUZnmC3dfY 5aUgX+ZnQu7SIGIPFoDrMglXL5tpM0pja7c0yUXl2bynxyny76l3EX7XiGTLWCXOmlA9 98qJvKXN7HmCW92RJfyJ+vsXy7RtFfRUethuwz+1OSwgQl4oP+k9hrwwYZN0vU51jQqT vMAg== X-Gm-Message-State: ANoB5pl8OBNlSuWrA5Nxex8Eb6+c0OUMS9sbO5y4O9hfWOwH7XNKCmGR kbvZ7D844lEPUchuh4CsEd79XOxlM2Yp1ZcayNYSOg== X-Google-Smtp-Source: AA0mqf7ck7P0BH+YIr1KjO69/asgCgI6jZaHzffocVRGbPImY0AxYrQnwP+5fE7TGBhpsUxjF8STHUeDhC28oZGoTU8= X-Received: by 2002:a17:902:db0a:b0:17c:7aaa:c67d with SMTP id m10-20020a170902db0a00b0017c7aaac67dmr481918plx.171.1668452864297; Mon, 14 Nov 2022 11:07:44 -0800 (PST) MIME-Version: 1.0 References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-4-christoph.muellner@vrull.eu> <72925543-48c1-12df-f65f-618c38179835@rivosinc.com> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Mon, 14 Nov 2022 20:07:30 +0100 Message-ID: Subject: Re: [PATCH 3/7] riscv: Enable overlap-by-pieces via tune param To: Jeff Law Cc: Philipp Tomsich , Vineet Gupta , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman Content-Type: multipart/alternative; boundary="0000000000004d26fe05ed72f458" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004d26fe05ed72f458 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 14, 2022 at 8:04 PM Jeff Law wrote: > > On 11/14/22 01:29, Christoph M=C3=BCllner wrote: > > > > On Mon, Nov 14, 2022 at 8:59 AM Philipp Tomsich > wrote: > >> On Mon, 14 Nov 2022 at 03:48, Vineet Gupta wrote: >> > >> > >> > >> > On 11/13/22 15:05, Christoph Muellner wrote: >> > > >> > > +static bool >> > > +riscv_overlap_op_by_pieces (void) >> > > +{ >> > > + return tune_param->overlap_op_by_pieces; >> > >> > Does this not need to be gated on unaligned access enabled as well. >> >> I assume you mean "&& !STRICT_ALIGNMENT"? >> > > I think the case that slow_unaligned_access and overlap_op_by_pieces will > both be set will not occur (we can defer the discussion about that until > then). > Gating overlap_op_by_pieces with !TARGET_STRICT_ALIGN is a good idea. > It will be fixed for a v2. > > OK with that change. > > > I'm still working through 7/7. I may not have enough left in my tank to > get through that one today. > No worries! Thank you very much for the fast reviews! > > jeff > > --0000000000004d26fe05ed72f458--