From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 4AE54385C301 for ; Mon, 14 Nov 2022 08:30:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AE54385C301 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-pj1-x1031.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso9913541pjc.5 for ; Mon, 14 Nov 2022 00:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=G3G7D5h2HdhrtzdqRELDWblkJrDkCCZeMmnz/dkT07A=; b=QOjTSp/Rnya1+u/2FuW80hGjHT1g4pNyr7oLp6H+5wl8t/gO9AuiunyQKlWzLTdhib KKYoYjzPckq9EjbK1CWlpf+Uq258N++C6hNJCc/suYPIt26EB+b+74qemfv3cbdEE5Gd iNlBMxxFgyMD5m90oN7Woaui6YyiWVsdv0KCQISBNAOzpdmAyCpgnMTL38XGeDKqe56M /suZhs60Xy5jEC3zQkrARWOvt5lO+RGaURE6nctlYypiPYzSiHXiyW9WqLIBc5fs/YHe iSN7F6cfX5F3OiyHV2tZE0ra4sd4L52TG3WhdIZGWstet9euoV8NRAbyY1Cy88S8cDvu jHYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G3G7D5h2HdhrtzdqRELDWblkJrDkCCZeMmnz/dkT07A=; b=NtLv1ctZ/xwFllrlfemHCz1nDJ1Hoep3OPofyanY986ZS6AadQ7b6wGvbwwBkuCF+E bZiaCkvirYjkO48szKq5QkYQ6xYtj87iKV4nckP4cw/dQGQHo6V5OJm4r0dFBO/nJt3d 546vnM0CeJTNCEFTbBu924XdZzakfWpUVk9or4GoPrdbJotntcEqoNUsybEjOhSgwTsN KfjEkfgNB4IuVYgKhB0neC1AQr71dS30k6B1V0QM7k2DmWUbQZMcmo9grqS72elN58ui nHyAqUk6brZn/3mGTtKqyWUIeZQBTBppg4VBBNUjDjntVh2P/TBFmqDcKH9xh0TnHbMq bYoA== X-Gm-Message-State: ANoB5pmrJKTF9jtjFVxeC5naBmfK4zpp6OoxbUjU9q5UDdhx7Yu/JrqA gihhQa73qwIxQsKoJp2Z6PGWpHTn+m557sjmVPTOBQ== X-Google-Smtp-Source: AA0mqf5JncHQAf6OOHfm59FslElGLkTYoEVSVJal+Da+tXsfbaBkVYpMsVUa5DuoTva+N4kd22Bc/dHtoge9Nk7W5N4= X-Received: by 2002:a17:90a:7084:b0:213:fbf3:fd with SMTP id g4-20020a17090a708400b00213fbf300fdmr12101863pjk.223.1668414599346; Mon, 14 Nov 2022 00:29:59 -0800 (PST) MIME-Version: 1.0 References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-4-christoph.muellner@vrull.eu> <72925543-48c1-12df-f65f-618c38179835@rivosinc.com> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Mon, 14 Nov 2022 09:29:45 +0100 Message-ID: Subject: Re: [PATCH 3/7] riscv: Enable overlap-by-pieces via tune param To: Philipp Tomsich Cc: Vineet Gupta , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Jeff Law Content-Type: multipart/alternative; boundary="0000000000008856f205ed6a0b39" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000008856f205ed6a0b39 Content-Type: text/plain; charset="UTF-8" On Mon, Nov 14, 2022 at 8:59 AM Philipp Tomsich wrote: > On Mon, 14 Nov 2022 at 03:48, Vineet Gupta wrote: > > > > > > > > On 11/13/22 15:05, Christoph Muellner wrote: > > > > > > +static bool > > > +riscv_overlap_op_by_pieces (void) > > > +{ > > > + return tune_param->overlap_op_by_pieces; > > > > Does this not need to be gated on unaligned access enabled as well. > > I assume you mean "&& !STRICT_ALIGNMENT"? > I think the case that slow_unaligned_access and overlap_op_by_pieces will both be set will not occur (we can defer the discussion about that until then). Gating overlap_op_by_pieces with !TARGET_STRICT_ALIGN is a good idea. It will be fixed for a v2. Thanks, Christoph > > Philipp. > --0000000000008856f205ed6a0b39--