From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 356F83858D20 for ; Wed, 15 May 2024 13:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 356F83858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 356F83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715780034; cv=none; b=DGtUlTWfmnCBcuFm8y0Bic91Rk2fLASODzeMrWk4vH3GrHl4cAYnekxNpCdM6REJ1B7ojGidh5uuS4cxM07W4zFR81D6hI2QtXRWd9yQ+688eoXmN6Bpv05gOaFULTbS8LLjTxPT49pmRyejMDR2350eWT4v47Y/ad/qSguesYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715780034; c=relaxed/simple; bh=Gb6gWawxAWVDZ8ExCQVB07JMbZYEd5rfMSilpDjyad0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UkY2lv7xoiz4yFNugtPmlK7t3wb0uhTtGXlrpUtp+R5xBFm1MqS0rC3cC7+UwuW2Zj6Egau1fZUHRPM1agCngtw6+eKyNO4qMQjDCn5wJguccQaKjgpk6hQomfU2cLyD8RXqKa4uaugG715NRnwiAZ2bcFDwJt3IuwWJAZF5R0o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-61eba9f9c5dso5123855a12.0 for ; Wed, 15 May 2024 06:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1715780024; x=1716384824; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a3d90HuWmbTHPk2wHDeMo7Tk9GZ3L0UA45ztVr+Suf8=; b=CJKhE1Q3oY9iWZEOc0ieh7SACeCc0K9gLlcC7nL4ulm8/zjukXq6TOx/mJDf9Njno0 jnGXGILvnqj6PO8MrlY5m1dwE25lHBbFkM5bUaHFqrwP6ANvvoZ+wby65bw0eepgm2Jn +sFO37tKKvDcCno3ejYo2lYlLcKB4hBD4hVynSv5CwX2Wx1Rgu8xwSicBcjw5fmwNWhN 1vVuqKIj09275izMR3BmGpPUJBaaD1dr+xK+j2IBa031dgts/hutIREkH7Xihx2k3PkA xbvJqZ10fvfBYJMwKcD5NVJGFiTJbfw3ufRzMemxms5IoG3EeeQg0ZOHwxJ/nMkwjiD8 rk/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715780024; x=1716384824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a3d90HuWmbTHPk2wHDeMo7Tk9GZ3L0UA45ztVr+Suf8=; b=iiEqg8e93kD3qsWZlLvih+4EvKNxkBIzG5HNRVltSzkSwo+jdlzGwsHAw0DPXbP3sC 4FncLLO9MxOSUnmb/U+U1Imaslp+xAMqFuWEzZeOjwjL8WjWCynf6BU4e96p9MXBjOhO CaW3qi7uqELVhdqEO7YgtSXwadxiV3uW/Y9r63i2jQ0ZCTjhHwU/FYz5bd3Qp6s1Z7hU J/I9+fDEXz16R8wRuWrUIXZLdB9MbXpXFey8Eq0XrzVcbFztopvtJoVfuhpzHzCsBk5D mBKb6LZSI4+LJovo8ldcoIE9hZRopyb3E1LQYQ93GIrImjT754HpkiTyxZ6ITV+1Pwz3 KGRA== X-Gm-Message-State: AOJu0YxKKU+HNn5NvpVFTxA4ApsOc9f8676RurizGTcSKU5vHfWodaRB JO1llJlv80Glj+uvAjYPhDLrcxuMmXItqokc9o8O41UssHsmgeIhuwKmVrGGxEpvKiVEp4SKu2U tRSddlxjd9iYNx+xzmacQmJiwmExuGj2230nrGA== X-Google-Smtp-Source: AGHT+IEQZM56MFCqSzUYJx7QbcAUWjwr4xpFvUpquKGjpKuw6x0IKl+P+6AHVNgpw4XADNmXDsEV6GXD7JtojK460Fg= X-Received: by 2002:a17:90b:1953:b0:2a2:4135:5310 with SMTP id 98e67ed59e1d1-2b992cdd45fmr3911948a91.12.1715780024152; Wed, 15 May 2024 06:33:44 -0700 (PDT) MIME-Version: 1.0 References: <20240515064841.2441351-1-christoph.muellner@vrull.eu> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Wed, 15 May 2024 15:33:32 +0200 Message-ID: Subject: Re: [PATCH] RISC-V: Fix cbo.zero expansion for rv32 To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Vineet Gupta Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 15, 2024 at 3:05=E2=80=AFPM Jeff Law wr= ote: > > > > On 5/15/24 12:48 AM, Christoph M=C3=BCllner wrote: > > Emitting a DI pattern won't find a match for rv32 and manifests in > > the failing test case gcc.target/riscv/cmo-zicboz-zic64-1.c. > > Let's fix this in the expansion and also address the different > > code that gets generated for rv32/rv64. > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-string.cc (riscv_expand_block_clear_zicboz_z= ic64b): > > Fix expansion for rv32. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/cmo-zicboz-zic64-1.c: Fix for rv32. > The exact change I made yesterday for the code generator. Glad to see I > didn't muck it up :-) And thanks for fixing the test to have some > coverage on rv32. I prepared this patch a few weeks ago. And I was convinced that I did a multilib-test back then (as I usually do), so I just rebased and executed the rv64 tests before sending them last week= . I was quite surprised to find this failing while working on the cmpmem expansion, since this was still in my queue to rebase/retest. Whatever, sorry for not testing earlier and thanks for fixing it!