From: "Christoph Müllner" <christoph.muellner@vrull.eu>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Liao Shihua" <shihua@iscas.ac.cn>,
"Kito Cheng" <kito.cheng@gmail.com>, 陈嘉炜 <jiawei@iscas.ac.cn>
Subject: Re: [PR target/110201] Fix operand types for various scalar crypto insns
Date: Thu, 14 Dec 2023 10:46:35 +0100 [thread overview]
Message-ID: <CAEg0e7iAA28d_wMcJUoWGsTcoryzNrMXOSie35Utitu8TNxnkQ@mail.gmail.com> (raw)
In-Reply-To: <f7505008-3132-20e0-da7b-00ec1ee66cc3@gmail.com>
On Tue, Jun 20, 2023 at 12:34 AM Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> A handful of the scalar crypto instructions are supposed to take a
> constant integer argument 0..3 inclusive. A suitable constraint was
> created and used for this purpose (D03), but the operand's predicate is
> "register_operand". That's just wrong.
>
> This patch adds a new predicate "const_0_3_operand" and fixes the
> relevant insns to use it. One could argue the constraint is redundant
> now (and you'd be correct). I wouldn't lose sleep if someone wanted
> that removed, in which case I'll spin up a V2.
>
> The testsuite was broken in a way that made it consistent with the
> compiler, so the tests passed, when they really should have been issuing
> errors all along.
>
> This patch adjusts the existing tests so that they all expect a
> diagnostic on the invalid operand usage (including out of range
> constants). It adds new tests with proper constants, testing the
> extremes of valid values.
>
> OK for the trunk, or should we remove the D03 constraint?
Reviewed-by: Christoph Muellner <christoph.muellner@vrull.eu>
The patch does not apply cleanly anymore, because there were some
small changes in crypto.md.
next prev parent reply other threads:[~2023-12-14 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 22:34 Jeff Law
2023-06-25 13:13 ` [PING][RISCV] " Jeff Law
2023-12-14 9:46 ` Christoph Müllner [this message]
2023-12-14 23:36 ` Jeff Law
2023-12-15 0:14 ` Christoph Müllner
2023-12-15 21:29 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEg0e7iAA28d_wMcJUoWGsTcoryzNrMXOSie35Utitu8TNxnkQ@mail.gmail.com \
--to=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@gmail.com \
--cc=shihua@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).