public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Christoph Müllner" <christoph.muellner@vrull.eu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Kito Cheng <kito@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [gcc r14-2455] riscv: Prepare backend for index registers
Date: Mon, 17 Jul 2023 09:33:07 +0200	[thread overview]
Message-ID: <CAEg0e7ipeXjhaKJX9SOU0NTeyX8SS7HRPTK3Jik8uep2WbbHVw@mail.gmail.com> (raw)
In-Reply-To: <mvmttu3dmqx.fsf@linux-m68k.org>

On Mon, Jul 17, 2023 at 9:24 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Jul 17 2023, Christoph Müllner wrote:
>
> > The build process shows a lot of warnings.
>
> Then you are using a bad compiler.  The build is 100% -Werror clean.

My host compiler is: gcc version 13.1.1 20230614 (Red Hat 13.1.1-4) (GCC)

Some examples:

> /home/cm/src/gcc/riscv-mainline/gcc/text-art/table.cc: In member function ‘int text_art::table_geometry::table_x_to_canvas_x(int) const’:
> /home/cm/src/gcc/riscv-mainline/gcc/text-art/table.cc:561:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
>   561 |   if (table_x == m_col_start_x.size ())
>       |       ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

> /home/cm/src/gcc/riscv-mainline/gcc/text-art/table.cc: In function ‘void selftest::test_spans_3()’:
> /home/cm/src/gcc/riscv-mainline/gcc/text-art/table.cc:947:62: warning: unquoted keyword ‘char’ in format [-Wformat-diag]
>  947 |                                                      "'buf' (char[%i])",
>       |                                                              ^~~~

> /home/cm/src/gcc/riscv-mainline/gcc/gengtype-lex.l: In function ‘int yylex(const char**)’:
> gengtype-lex.cc:356:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   356 |  */
>       |  ~~           ^

> In file included from /home/cm/src/gcc/riscv-mainline/libgcc/unwind-dw2.c:410:
> ./md-unwind-support.h: In function 'riscv_fallback_frame_state':
> ./md-unwind-support.h:67:6: warning: assignment to 'struct sigcontext *' from incompatible pointer type 'mcontext_t *' [-Wincompatible-pointer-types]
>   67 |   sc = &rt_->uc.uc_mcontext;
>      |      ^

> /home/cm/src/gcc/riscv-mainline/libgcc/config/riscv/atomic.c:36:8: warning: conflicting types for built-in function '__sync_fetch_and_add_1'; expected 'unsigned char(volatile void *, unsigned char)' [-Wbuiltin-declaration-mismatch]
>    36 |   type __sync_fetch_and_ ## opname ## _ ## size (type *p, type v)       \
>       |        ^~~~~~~~~~~~~~~~~

Please let me know if I am doing something wrong.

BR
Christoph


>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."

  reply	other threads:[~2023-07-17  7:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230712081314.F1263385800C@sourceware.org>
2023-07-14 10:28 ` Andreas Schwab
2023-07-17  6:48   ` Christoph Müllner
2023-07-17  7:24     ` Andreas Schwab
2023-07-17  7:33       ` Christoph Müllner [this message]
2023-07-17  7:44         ` Andreas Schwab
2023-07-17  8:11           ` Christoph Müllner
2023-07-17  7:31     ` Andrew Pinski
2023-07-17  8:11       ` Christoph Müllner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEg0e7ipeXjhaKJX9SOU0NTeyX8SS7HRPTK3Jik8uep2WbbHVw@mail.gmail.com \
    --to=christoph.muellner@vrull.eu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kito@gcc.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).