From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id A25B73858C30 for ; Tue, 30 Jan 2024 06:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A25B73858C30 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A25B73858C30 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706596816; cv=none; b=BZ3/qDwDrbeFDSxDQRR/WcPUxRdQp8foVGDMgpC80rwcaADG/6p5qPJR4UVFKlIWkmbihtH7UCPeMpUC1Snkpml1y/yINJ2IU0e8zuoQTV7OSkO1n5ufxVtGAlBmfNFEUWbBM/oCsycJDQ7piQnETOV5m1/gz64uFPFNeC21Plc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706596816; c=relaxed/simple; bh=m/+GG6UELeNkyWOYLQUlPyQSVWVXEzDJ0u0mO6dBw1c=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=L24fO04hjGo1WCHC7h7kHGTZ0ugCSqgq6AlMzb3KZSWkZLHsF59bfr7r1qHRORpQfzftgGYwfMeLVh13fR2HJT1zml4ixGq+KTPmKrWEnBayfSfR0g7EnnkcfM10EiL0DZEbx0K0i3n8gq1jkZR8f3ECtkNpklg5aZkW8kYctIw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2957f76fa1fso1127826a91.0 for ; Mon, 29 Jan 2024 22:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1706596813; x=1707201613; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nstZ9byX37xcxU2uxDyROBWCvcUVR+/w1hSiiHq9Svo=; b=fUqqBiA99JmhLt1DOJpqrqhk9rcm4IBtLNZPubJGU8N4U2q2Ww0YOG+j5tAX0DO1TB xupfqF/qzJPgxYk+K7LnLeIi38u9TVK+jefoez/LrNQNqBpjLEJEMTOtxWUxNROJmb3c U4/ZzwSeWeAowo2MQ+M+0tXr4bZyRpLuMWcIDNMHMJ9U8NUVmt3rplhc64wZ3jfceUIj TCW9ZE9hW4GNEcke+aFAw9gNh4AR1VMWKy3dk43j3ysteaKCCAa9mARjanudw8uk6TiN AugKBdDAMWkrmnahzNx7YaSqyarP6O2BC2Veye08z9DExG/ibp6yPI//IMLFL/g0FJPB UGTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706596813; x=1707201613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nstZ9byX37xcxU2uxDyROBWCvcUVR+/w1hSiiHq9Svo=; b=FRa14IfTVMgb2A//mB5D30d9WU4pQM6X9Oz009VFwD9l4xM+4tj/Kc3fsXjIvwtHHi wzh2xJwqOylpxRrcTCVfiVPc8oWYJDIY10Av0p/f+2CY5Lop1NVUQykvt2pRXm5u81lp +Eme+eoCDSm+yhkD7h7HWonSBFEhN2h9OQpkt5dmmr/aU6ToYwOh0M0G1v55tyKUoph7 nRPIJWoT2In8PTRpuHoar24tAFc9AlkMIo1h5231SrQ2OvXCnCJBaTmGG/kiNguJAcHC KeZHopfClDL6oDW7ZiYN8ikxyTBGdmiNLspg0QhpoHg5LviZf0XMvDlnSG+wd55fn5jm x+Ig== X-Gm-Message-State: AOJu0YwVLqvvT7n00fnxyHSvSez0D79j6h+JPJH64PpgDlWJwR5RvrGL FXodTlx7AA7LBXUB/q0S206z+qJ/vahlzuBDhZCSih+8SfJ2yiFuC2e+liEGzFCJ7h+/Uz00BsJ FsVJBlwTNwT2eVlnyuxxN46uaSdwpJ2ghJw72wQ== X-Google-Smtp-Source: AGHT+IFrazfWfWeUhmQaXqhkIrsUPhZRHIAOJVVQzoaFJrfIbLlbySYuCaZjGK6zowE0wtxaDd/qsgq8ho6hY6kt1Ro= X-Received: by 2002:a17:90a:4683:b0:290:4c4e:2496 with SMTP id z3-20020a17090a468300b002904c4e2496mr800859pjf.29.1706596813634; Mon, 29 Jan 2024 22:40:13 -0800 (PST) MIME-Version: 1.0 References: <20240129092016.1176-1-jinma@linux.alibaba.com> <20240129095700.1245-1-jinma@linux.alibaba.com> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Tue, 30 Jan 2024 07:40:02 +0100 Message-ID: Subject: Re: [PATCH v2] RISC-V: THEAD: Fix improper immediate value for MODIFY_DISP instruction on 32-bit systems. To: Kito Cheng Cc: Jin Ma , GCC Patches , Jeff Law , Palmer Dabbelt , "richard.sandiford" , Robin Dapp , =?UTF-8?B?6ZKf5bGF5ZOy?= , "jinma.contrib" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 29, 2024 at 1:32=E2=80=AFPM Kito Cheng w= rote: > > LGTM I've rebased, retested (rv64+rv32) and merged this patch. Thanks! > > Jin Ma =E6=96=BC 2024=E5=B9=B41=E6=9C=8829=E6= =97=A5 =E9=80=B1=E4=B8=80 17:57 =E5=AF=AB=E9=81=93=EF=BC=9A >> >> When using '%ld' to print 'long long int' variable, 'fprintf' will >> produce messy output on a 32-bit system, in an incorrect instruction >> being generated, such as 'th.lwib a1,(a0),-16,4294967295'. And the >> following error occurred during compilation: >> >> Assembler messages: >> Error: improper immediate value (18446744073709551615) >> >> gcc/ChangeLog: >> >> * config/riscv/thead.cc (th_print_operand_address): Change %ld >> to %lld. >> --- >> gcc/config/riscv/thead.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/config/riscv/thead.cc b/gcc/config/riscv/thead.cc >> index 2955bc5f8a9..e4b8c37bc28 100644 >> --- a/gcc/config/riscv/thead.cc >> +++ b/gcc/config/riscv/thead.cc >> @@ -1141,7 +1141,7 @@ th_print_operand_address (FILE *file, machine_mode= mode, rtx x) >> return true; >> >> case ADDRESS_REG_WB: >> - fprintf (file, "(%s),%ld,%u", reg_names[REGNO (addr.reg)], >> + fprintf (file, "(%s),"HOST_WIDE_INT_PRINT_DEC",%u", reg_names[REG= NO (addr.reg)], >> INTVAL (addr.offset) >> addr.shift, addr.shift); >> return true; >> >> -- >> 2.17.1 >>