From: Quentin Neill <quentin.neill.gnu@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH: Add capability to contrib/compare_tests to handle directories
Date: Wed, 02 Nov 2011 17:45:00 -0000 [thread overview]
Message-ID: <CAEhygDpR0R8hw903LCys0m3AW0kvW+Egjjzbj=-7aWHgM-Q4xA@mail.gmail.com> (raw)
In-Reply-To: <4CD2433B-1994-4834-A595-131242428431@comcast.net>
On Tue, Oct 4, 2011 at 4:57 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Oct 4, 2011, at 2:37 PM, Quentin Neill wrote:
>> Ping?
>
> The problem with this patch is it reorders the listing so that lower priority things are after higher priority things. The entire point of the routine is to list the high priority things first, so that a casual user can read the first line or two and not immediately if there is something they care about.
>
> Now, this property can be preserved simply by concatenating all the .sum files found in a directory into an all.sum file, and then running the script on those two files. If one does that, then the priority order is preserved.
Hi Mike,
Thanks for the feedback. From the comments, I assumed the usage was
to compare two .log files not .sum files.
Maybe it is a new scenario I'm imagining - comparing two builds to see
if ANY test results changed, regardless of order.
In any case, I will work on your changes when I get time (after stage1 probably)
--
Quentin
next prev parent reply other threads:[~2011-11-02 17:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 17:29 Quentin Neill
2011-10-04 21:45 ` Quentin Neill
2011-10-04 22:08 ` Mike Stump
2011-11-02 17:45 ` Quentin Neill [this message]
2011-11-05 4:33 ` Quentin Neill
2011-11-05 21:39 ` Mike Stump
2011-11-08 16:11 ` Quentin Neill
2011-11-08 16:48 ` Mike Stump
2012-02-11 14:15 ` Mike Stump
2012-02-14 16:41 ` Quentin Neill
2012-02-14 16:47 ` Quentin Neill
2012-02-15 7:23 ` Mike Stump
[not found] ` <CAEhygDrP-ywsm8ZZ79YF6modV-GzLtpRpkT9DRC507QLjnSb8Q@mail.gmail.com>
2012-02-16 15:34 ` Quentin Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEhygDpR0R8hw903LCys0m3AW0kvW+Egjjzbj=-7aWHgM-Q4xA@mail.gmail.com' \
--to=quentin.neill.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).