From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20277 invoked by alias); 2 Nov 2011 17:33:07 -0000 Received: (qmail 20258 invoked by uid 22791); 2 Nov 2011 17:33:05 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 17:32:51 +0000 Received: by ggnj1 with SMTP id j1so412059ggn.20 for ; Wed, 02 Nov 2011 10:32:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.100.18 with SMTP id x18mr6489453ybb.75.1320255170135; Wed, 02 Nov 2011 10:32:50 -0700 (PDT) Received: by 10.150.137.5 with HTTP; Wed, 2 Nov 2011 10:32:49 -0700 (PDT) In-Reply-To: <4CD2433B-1994-4834-A595-131242428431@comcast.net> References: <4CD2433B-1994-4834-A595-131242428431@comcast.net> Date: Wed, 02 Nov 2011 17:45:00 -0000 Message-ID: Subject: Re: PATCH: Add capability to contrib/compare_tests to handle directories From: Quentin Neill To: Mike Stump Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00185.txt.bz2 On Tue, Oct 4, 2011 at 4:57 PM, Mike Stump wrote: > On Oct 4, 2011, at 2:37 PM, Quentin Neill wrote: >> Ping? > > The problem with this patch is it reorders the listing so that lower prio= rity things are after higher priority things. =A0The entire point of the ro= utine is to list the high priority things first, so that a casual user can = read the first line or two and not immediately if there is something they c= are about. > > Now, this property can be preserved simply by concatenating all the .sum = files found in a directory into an all.sum file, and then running the scrip= t on those two files. =A0If one does that, then the priority order is prese= rved. Hi Mike, Thanks for the feedback. From the comments, I assumed the usage was to compare two .log files not .sum files. Maybe it is a new scenario I'm imagining - comparing two builds to see if ANY test results changed, regardless of order. In any case, I will work on your changes when I get time (after stage1 prob= ably) --=20 Quentin