From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4612 invoked by alias); 14 Jan 2015 10:32:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4597 invoked by uid 89); 14 Jan 2015 10:32:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f171.google.com Received: from mail-wi0-f171.google.com (HELO mail-wi0-f171.google.com) (209.85.212.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 14 Jan 2015 10:32:16 +0000 Received: by mail-wi0-f171.google.com with SMTP id bs8so27108129wib.4 for ; Wed, 14 Jan 2015 02:32:13 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.181.8.66 with SMTP id di2mr47851406wid.49.1421231533333; Wed, 14 Jan 2015 02:32:13 -0800 (PST) Received: by 10.217.120.199 with HTTP; Wed, 14 Jan 2015 02:32:13 -0800 (PST) In-Reply-To: <20150114102338.GL1405@tucnak.redhat.com> References: <20150114102338.GL1405@tucnak.redhat.com> Date: Wed, 14 Jan 2015 10:40:00 -0000 Message-ID: Subject: Re: [PATCH PR64434] From: Yuri Rumyantsev To: Jakub Jelinek Cc: gcc-patches , Richard Biener , Igor Zamyatin Content-Type: multipart/mixed; boundary=001a1134d67eb113ca050c9a40df X-SW-Source: 2015-01/txt/msg01003.txt.bz2 --001a1134d67eb113ca050c9a40df Content-Type: text/plain; charset=UTF-8 Content-length: 856 Sorry, I resend correct patch. Yuri. 2015-01-14 13:23 GMT+03:00 Jakub Jelinek : > On Wed, Jan 14, 2015 at 01:12:20PM +0300, Yuri Rumyantsev wrote: >> Hi All, >> >> Here is updated patch which was redesigned accordingly to Richard review. >> It performs swapping operands of commutative operations to expand the >> expensive one first. >> >> Bootstrap and regression testing did not show any new failures. >> >> Is it OK for trunk? > > Haven't you just reposted the patch from December? I don't see any changes > from then... > >> gcc/ChangeLog >> 2015-01-14 Yuri Rumyantsev >> >> PR tree-optimization/64434 >> * cfgexpand.c (reorder_operands): New function. >> (expand_gimple_basic_block): Insert call of reorder_operands. >> >> gcc/testsuite/ChangeLog >> * gcc.dg/torture/pr64434.c: New test. > > Jakub --001a1134d67eb113ca050c9a40df Content-Type: application/octet-stream; name=patch Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4wkjoah0 Content-length: 5194 SW5kZXg6IGNmZ2V4cGFuZC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGNmZ2V4cGFuZC5jCShyZXZpc2lvbiAyMTk0MzkpCisrKyBjZmdleHBhbmQu Ywkod29ya2luZyBjb3B5KQpAQCAtNDk2NCw2ICs0OTY0LDg5IEBACiAgIGZs YWdfc3RyaWN0X2FsaWFzaW5nID0gc2F2ZV9zdHJpY3RfYWxpYXM7CiB9CiAK Ky8qIFBlcmZvcm1zIHN3YXBwaW5nIG9wZXJhbmRzIG9mIGNvbW11dGF0aXZl IG9wZXJhdGlvbnMgdG8gZXhwYW5kCisgICB0aGUgZXhwZW5zaXZlIG9uZSBm aXJzdC4gICovCisKK3N0YXRpYyB2b2lkCityZW9yZGVyX29wZXJhbmRzIChi YXNpY19ibG9jayBiYikKK3sKKyAgdW5zaWduZWQgaW50ICpsYXR0aWNlOyAg LyogSG9sZCBjb3N0IG9mIGVhY2ggc3RhdGVtZW50LiAgKi8KKyAgdW5zaWdu ZWQgaW50IGkgPSAwLCBuID0gMDsKKyAgZ2ltcGxlX3N0bXRfaXRlcmF0b3Ig Z3NpOworICBnaW1wbGVfc2VxIHN0bXRzOworICBnaW1wbGUgc3RtdDsKKyAg Ym9vbCBzd2FwOworICB0cmVlIG9wMCwgb3AxOworICBzc2Ffb3BfaXRlciBp dGVyOworICB1c2Vfb3BlcmFuZF9wIHVzZV9wOworICBlbnVtIHRyZWVfY29k ZSBjb2RlOworICBnaW1wbGUgZGVmMCwgZGVmMTsKKworICBpZiAoIW9wdGlt aXplKQorICAgIHJldHVybjsKKworICAvKiBDb21wdXRlIGNvc3Qgb2YgZWFj aCBzdGF0ZW1lbnQgdXNpbmcgZXN0aW1hdGVfbnVtX2luc25zLiAgKi8KKyAg c3RtdHMgPSBiYl9zZXEgKGJiKTsKKyAgZm9yIChnc2kgPSBnc2lfc3RhcnQg KHN0bXRzKTsgIWdzaV9lbmRfcCAoZ3NpKTsgZ3NpX25leHQgKCZnc2kpKQor ICAgIHsKKyAgICAgIHN0bXQgPSBnc2lfc3RtdCAoZ3NpKTsKKyAgICAgIGdp bXBsZV9zZXRfdWlkIChzdG10LCBuKyspOworICAgIH0KKyAgbGF0dGljZSA9 IFhBTExPQ0FWRUMgKHVuc2lnbmVkLCBuKTsKKyAgZm9yIChnc2kgPSBnc2lf c3RhcnQgKHN0bXRzKTsgIWdzaV9lbmRfcCAoZ3NpKTsgZ3NpX25leHQgKCZn c2kpKQorICAgIHsKKyAgICAgIHVuc2lnbmVkIGNvc3Q7CisgICAgICBzdG10 ID0gZ3NpX3N0bXQgKGdzaSk7CisgICAgICBjb3N0ID0gZXN0aW1hdGVfbnVt X2luc25zIChzdG10LCAmZW5pX3NpemVfd2VpZ2h0cyk7CisgICAgICBsYXR0 aWNlW2ldID0gY29zdDsKKyAgICAgIEZPUl9FQUNIX1NTQV9VU0VfT1BFUkFO RCAodXNlX3AsIHN0bXQsIGl0ZXIsIFNTQV9PUF9VU0UgfCBTU0FfT1BfVlVT RSkKKwl7CisJICB0cmVlIHVzZSA9IFVTRV9GUk9NX1BUUiAodXNlX3ApOwor CSAgZ2ltcGxlIGRlZl9zdG10OworCSAgaWYgKFRSRUVfQ09ERSAodXNlKSAh PSBTU0FfTkFNRSkKKwkgICAgY29udGludWU7CisJICBkZWZfc3RtdCA9IGdl dF9naW1wbGVfZm9yX3NzYV9uYW1lICh1c2UpOworCSAgaWYgKCFkZWZfc3Rt dCB8fCBnaW1wbGVfYmIgKGRlZl9zdG10KSAhPSBiYikKKwkgICAgY29udGlu dWU7CisJICBsYXR0aWNlW2ldICs9IGxhdHRpY2VbZ2ltcGxlX3VpZCAoZGVm X3N0bXQpXTsKKwl9CisgICAgICBpKys7CisgICAgICBpZiAoZ2ltcGxlX2Nv ZGUgKHN0bXQpICE9IEdJTVBMRV9BU1NJR04KKwkgIHx8IGdpbXBsZV9oYXNf dm9sYXRpbGVfb3BzIChzdG10KSkKKwljb250aW51ZTsKKyAgICAgIGNvZGUg PSBnaW1wbGVfYXNzaWduX3Joc19jb2RlIChzdG10KTsKKyAgICAgIGlmICgh Y29tbXV0YXRpdmVfdHJlZV9jb2RlIChjb2RlKSkKKwljb250aW51ZTsKKyAg ICAgIGdjY19hc3NlcnQgKGdpbXBsZV9udW1fb3BzIChzdG10KSA9PSAzKTsK KyAgICAgIG9wMCA9IGdpbXBsZV9vcCAoc3RtdCwgMSk7CisgICAgICBvcDEg PSBnaW1wbGVfb3AgKHN0bXQsIDIpOworICAgICAgaWYgKG9wMCA9PU5VTExf VFJFRSB8fCBvcDEgPT0gTlVMTF9UUkVFCisJICB8fCBUUkVFX0NPREUgKG9w MCkgIT0gU1NBX05BTUUKKwkgIHx8IFRSRUVfQ09ERSAob3AxKSAhPSBTU0Ff TkFNRSkKKwljb250aW51ZTsKKyAgICAgIC8qIFN3YXAgb3BlcmFuZHMgaWYg dGhlIHNlY29uZCBvbmUgaXMgbW9yZSBleHBlbnNpdmUuICAqLworICAgICAg ZGVmMCA9IGdldF9naW1wbGVfZm9yX3NzYV9uYW1lIChvcDApOworICAgICAg aWYgKCFkZWYwKQorCWNvbnRpbnVlOworICAgICAgZGVmMSA9IGdldF9naW1w bGVfZm9yX3NzYV9uYW1lIChvcDEpOworICAgICAgaWYgKCFkZWYxKQorCWNv bnRpbnVlOworICAgICAgc3dhcCA9IGZhbHNlOworICAgICAgaWYgKGxhdHRp Y2VbZ2ltcGxlX3VpZCAoZGVmMSldID4gbGF0dGljZVtnaW1wbGVfdWlkIChk ZWYwKV0pCisJc3dhcCA9IHRydWU7CisgICAgICBpZiAoc3dhcCkKKwl7CisJ ICBpZiAoZHVtcF9maWxlICYmIChkdW1wX2ZsYWdzICYgVERGX0RFVEFJTFMp KQorCSAgICB7CisJICAgICAgZnByaW50ZiAoZHVtcF9maWxlLCAiU3dhcCBv cGVyYW5kcyBpbiBzdG10OlxuIik7CisJICAgICAgcHJpbnRfZ2ltcGxlX3N0 bXQgKGR1bXBfZmlsZSwgc3RtdCwgMCwgVERGX1NMSU0pOworCSAgICB9CisJ ICBnaW1wbGVfc2V0X29wIChzdG10LCAxLCBvcDEpOworCSAgZ2ltcGxlX3Nl dF9vcCAoc3RtdCwgMiwgb3AwKTsKKwl9CisgICAgfQorfQorCiAvKiBFeHBh bmQgYmFzaWMgYmxvY2sgQkIgZnJvbSBHSU1QTEUgdHJlZXMgdG8gUlRMLiAg Ki8KIAogc3RhdGljIGJhc2ljX2Jsb2NrCkBAIC00OTg1LDYgKzUwNjgsNyBA QAogICAgICBjYW5ub3QgdXNlIHRoZSBnc2lfKl9iYigpIHJvdXRpbmVzIGJl Y2F1c2UgdGhleSBleHBlY3QgdGhlIGJhc2ljCiAgICAgIGJsb2NrIHRvIGJl IGluIEdJTVBMRSwgaW5zdGVhZCBvZiBSVEwuICBUaGVyZWZvcmUsIHdlIG5l ZWQgdG8KICAgICAgYWNjZXNzIHRoZSBCQiBzZXF1ZW5jZSBkaXJlY3RseS4g ICovCisgIHJlb3JkZXJfb3BlcmFuZHMgKGJiKTsKICAgc3RtdHMgPSBiYl9z ZXEgKGJiKTsKICAgYmItPmlsLmdpbXBsZS5zZXEgPSBOVUxMOwogICBiYi0+ aWwuZ2ltcGxlLnBoaV9ub2RlcyA9IE5VTEw7CkluZGV4OiB0ZXN0c3VpdGUv Z2NjLmRnL3RvcnR1cmUvcHI2NDQzNC5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHRlc3RzdWl0ZS9nY2MuZGcvdG9ydHVyZS9wcjY0NDM0LmMJKHJl dmlzaW9uIDApCisrKyB0ZXN0c3VpdGUvZ2NjLmRnL3RvcnR1cmUvcHI2NDQz NC5jCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTkgQEAKKy8qIHsgZGct ZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1PMSAtZmR1bXAt cnRsLWV4cGFuZC1kZXRhaWxzIiB9ICovCisKKyNkZWZpbmUgTiAyNTYKK2lu dCBhMVtOXSwgYTJbTl0sIGEzW05dLCBhNFtOXTsKKwordm9pZCBmb28gKCkK K3sKKyAgaW50IGk7CisgIGZvciAoaT0wOyBpPE47IGkrKykgeworICAgIGlu dCBjOworICAgIGMgPSBhM1tpXSArIChhMVtpXSAqIGEyW2ldKTsKKyAgICBh NFtpXSA9IGMgKyAxOworICAgIGExW2ldID0gYTJbaV0gLSAxOworICB9Cit9 CisKKy8qIHsgZGctZmluYWwgeyBzY2FuLXJ0bC1kdW1wLXRpbWVzICJTd2Fw IG9wZXJhbmRzIiAxICJleHBhbmQiIH0gfSAqLworLyogeyBkZy1maW5hbCB7 IGNsZWFudXAtcnRsLWR1bXAgImV4cGFuZCIgfSB9ICovCgpQcm9wZXJ0eSBj aGFuZ2VzIG9uOiB0ZXN0c3VpdGUvZ2NjLmRnL3RvcnR1cmUvcHI2NDQzNC5j Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjpleGVjdXRhYmxl CiMjIC0wLDAgKzEgIyMKKyoKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9w ZXJ0eQo= --001a1134d67eb113ca050c9a40df--