From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90765 invoked by alias); 13 Oct 2015 12:49:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 90754 invoked by uid 89); 13 Oct 2015 12:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f180.google.com Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 13 Oct 2015 12:49:48 +0000 Received: by obbbh8 with SMTP id bh8so12485520obb.0 for ; Tue, 13 Oct 2015 05:49:46 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.125.131 with SMTP id mq3mr18553317oeb.8.1444740586673; Tue, 13 Oct 2015 05:49:46 -0700 (PDT) Received: by 10.202.191.6 with HTTP; Tue, 13 Oct 2015 05:49:46 -0700 (PDT) In-Reply-To: References: Date: Tue, 13 Oct 2015 12:49:00 -0000 Message-ID: Subject: Re: [PATCH PR67909 PR67947] From: Yuri Rumyantsev To: "H.J. Lu" Cc: gcc-patches , Richard Biener , Igor Zamyatin Content-Type: multipart/mixed; boundary=047d7b33c6a676998b0521fbe1eb X-SW-Source: 2015-10/txt/msg01234.txt.bz2 --047d7b33c6a676998b0521fbe1eb Content-Type: text/plain; charset=UTF-8 Content-length: 1149 Here is updated patch with splitting long line. The patch is attached. Yuri. 2015-10-13 15:38 GMT+03:00 H.J. Lu : > On Tue, Oct 13, 2015 at 4:57 AM, Yuri Rumyantsev wrote: >> Hi All, >> >> Here is a simple patch for unswitching outer loop through guard-edge >> hoisting. The check that guard-edge is around the inner loop was >> missed. >> >> Bootstrapping and regression testing did not show new failures. >> >> Is it OK for trunk? >> >> ChangeLog: >> 2014-10-13 Yuri Rumyantsev >> >> PR tree-optimization/67909, 67947 >> * tree-ssa-loop-unswitch.c (find_loop_guard): Add check that GUARD_EDGE >> really skip the inner loop. >> >> gcc/testsuite/ChangeLog >> * gcc.dg/torture/pr67947.c: New test. > > + /* Guard edge must skip inner loop. */ > + if (!dominated_by_p (CDI_DOMINATORS, loop->inner->header, > + guard_edge == fe ? te->dest : fe->dest)) > ^^^^ It should line up with "CDI_DOMINATORS". > > + fprintf (dump_file, "Guard edge %d --> %d is not around the > loop!\n",guard_edge->src->index,guard_edge->dest->index); > > Please break lone line. > > -- > H.J. --047d7b33c6a676998b0521fbe1eb Content-Type: application/octet-stream; name=patch1 Content-Disposition: attachment; filename=patch1 Content-Transfer-Encoding: base64 X-Attachment-Id: f_ifpd8o5n0 Content-length: 2184 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3RvcnR1cmUvcHI2 Nzk0Ny5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdG9ydHVyZS9wcjY3OTQ3 LmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTY2NGM0 OAotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3Rv cnR1cmUvcHI2Nzk0Ny5jCkBAIC0wLDAgKzEsMzAgQEAKKy8qIHsgZGctYWRk aXRpb25hbC1vcHRpb25zICItTzMiIH0gKi8KKworI2luY2x1ZGUgPHN0ZGxp Yi5oPgorCitpbnQgYTsKK2ludCBjOworX19hdHRyaWJ1dGVfXygobm9pbmxp bmUsIG5vY2xvbmUpKSB2b2lkIGZvbyAoaW50IHgpCit7CisgIGlmICh4ID09 IDApCisgICAgYysrOworfQorCitpbnQKK21haW4gKGludCBhcmdjLCBjaGFy KiBhcmd2W10pCit7CisgIGludCBqLCBrLCBiID0gMDsKKyAgaWYgKGFyZ2Mg PT0gMCkKKyAgICBiID0gMTsKKyAgZm9yIChqID0gMDsgaiA8IDM7IGorKykK KyAgICBmb3IgKGsgPSAwOyBrIDwgMTsgaysrKQorICAgICAgeworCWZvbyAo MCk7CisJaWYgKGIpCisJICBmb3IgKGsgPSAtMTsgYTspCisJICAgIDsKKyAg ICAgIH0KKyAgaWYgKGMgIT0gMykKKyAgICBhYm9ydCAoKTsKKyAgcmV0dXJu IDA7Cit9CmRpZmYgLS1naXQgYS9nY2MvdHJlZS1zc2EtbG9vcC11bnN3aXRj aC5jIGIvZ2NjL3RyZWUtc3NhLWxvb3AtdW5zd2l0Y2guYwppbmRleCA0MzI4 ZDZhLi5iNjliOTk1IDEwMDY0NAotLS0gYS9nY2MvdHJlZS1zc2EtbG9vcC11 bnN3aXRjaC5jCisrKyBiL2djYy90cmVlLXNzYS1sb29wLXVuc3dpdGNoLmMK QEAgLTQ2Niw3ICs0NjYsNiBAQCBmaW5kX2xvb3BfZ3VhcmQgKHN0cnVjdCBs b29wICpsb29wKQogewogICBiYXNpY19ibG9jayBoZWFkZXIgPSBsb29wLT5o ZWFkZXI7CiAgIGVkZ2UgZ3VhcmRfZWRnZSwgdGUsIGZlOwotICAvKiBiaXRt YXAgcHJvY2Vzc2VkLCBrbm93bl9pbnZhcmlhbnRzOyovCiAgIGJhc2ljX2Js b2NrICpib2R5ID0gTlVMTDsKICAgdW5zaWduZWQgaTsKICAgdHJlZSB1c2U7 CkBAIC01MjQsNiArNTIzLDE2IEBAIGZpbmRfbG9vcF9ndWFyZCAoc3RydWN0 IGxvb3AgKmxvb3ApCiAgIGVsc2UKICAgICByZXR1cm4gTlVMTDsKIAorICAv KiBHdWFyZCBlZGdlIG11c3Qgc2tpcCBpbm5lciBsb29wLiAgKi8KKyAgaWYg KCFkb21pbmF0ZWRfYnlfcCAoQ0RJX0RPTUlOQVRPUlMsIGxvb3AtPmlubmVy LT5oZWFkZXIsCisgICAgICBndWFyZF9lZGdlID09IGZlID8gdGUtPmRlc3Qg OiBmZS0+ZGVzdCkpCisgICAgeworICAgICAgaWYgKGR1bXBfZmlsZSAmJiAo ZHVtcF9mbGFncyAmIFRERl9ERVRBSUxTKSkKKwlmcHJpbnRmIChkdW1wX2Zp bGUsICJHdWFyZCBlZGdlICVkIC0tPiAlZCBpcyBub3QgYXJvdW5kIHRoZSBs b29wIVxuIiwKKwkJIGd1YXJkX2VkZ2UtPnNyYy0+aW5kZXgsIGd1YXJkX2Vk Z2UtPmRlc3QtPmluZGV4KTsKKyAgICAgIHJldHVybiBOVUxMOworICAgIH0K KwogICBpZiAoZHVtcF9maWxlICYmIChkdW1wX2ZsYWdzICYgVERGX0RFVEFJ TFMpKQogICAgIGZwcmludGYgKGR1bXBfZmlsZSwKIAkgICAgICJDb25zaWRl cmluZyBndWFyZCAlZCAtPiAlZCBpbiBsb29wICVkXG4iLAo= --047d7b33c6a676998b0521fbe1eb--