From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 38894385AF88 for ; Wed, 26 Jul 2023 13:37:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38894385AF88 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690378638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=elID4eobmgY+9H5iCE8+rh+DhxYjYTtTTFLnZgtL3n4=; b=EjDikMRVwMYpi6UAmi80867weJGq2S//pL+OfasEZlRQhxXjzwiuSQxtWdWoZ/je21vfDN 6RHd7eGAm6LSgU0KEgxV9i2WChi2v1RH4T5CMmyBWU06myUGaPW+cTtED/C+RWsiI4fL88 Fp+PfQE+rHycZJfngO1aRZP8tb+OOU8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-lmG1MsxHM2OPFds1iUIHKg-1; Wed, 26 Jul 2023 09:37:16 -0400 X-MC-Unique: lmG1MsxHM2OPFds1iUIHKg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4f3932e595dso6235873e87.1 for ; Wed, 26 Jul 2023 06:37:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378635; x=1690983435; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=elID4eobmgY+9H5iCE8+rh+DhxYjYTtTTFLnZgtL3n4=; b=A4/XHwgY12+Kx5kkUliBVgVtB7Dk/6RHvap/FhJX9AVnPYkqgjkGFrj87z3zsAoAbF VGX1k6emzxhJuDLljjKE3bc4IZn+It6bY8wsiMWU8zgr2G4uX5o7yvB8hoWo/c8vash+ Jf9WdFOilOWkJfkALzYZqzjpzAl9pnYqeFpXkB7UZS/FFOAE1n/nP66Re8OJSl18wEPw 4aPEA2j2mw92AVNY+hMtpaNKP8SedGBurYXkM2qdpeYm94HSD8c0OifEiWZzlBEcV2K6 JYNfbT5X3PalOwDJ5/+POadF144ZSi9bfYp6l38yQst8aFSZxpZK3wnlRIT7tqG13b7o osuw== X-Gm-Message-State: ABy/qLarnYvJcdRz4Si4WuU3ZwxA5ZjtnYQx4PqiDPCww7XQeoyNo0Qb PVv2ivHMJKwWkyzMRNja2gCmWOs0U8cZbksDNzuwAQRWHI9Ivj+AmmnFWrpiPkvJppfts+y/M6i QFluAdYfYX/xFDgT10sXAd0ik/1ss10AYFw== X-Received: by 2002:a05:6512:3705:b0:4f9:5ca5:f1a6 with SMTP id z5-20020a056512370500b004f95ca5f1a6mr1503920lfr.17.1690378635136; Wed, 26 Jul 2023 06:37:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHITvj2uhbyyU7VDcxV9HMwtACqVwguz2Fp3icr4fVXduFfdN1uvl+NfQPOPFxwGjOHXNiL8giNAcPEluruZfs= X-Received: by 2002:a05:6512:3705:b0:4f9:5ca5:f1a6 with SMTP id z5-20020a056512370500b004f95ca5f1a6mr1503910lfr.17.1690378634843; Wed, 26 Jul 2023 06:37:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Drew Ross Date: Wed, 26 Jul 2023 09:37:03 -0400 Message-ID: Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986] To: Andrew Pinski Cc: Jakub Jelinek , David Edelsohn , GCC Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000010ea93060163f2e5" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000010ea93060163f2e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for catching and fixing David and Andrew. Drew On Tue, Jul 25, 2023 at 5:59=E2=80=AFPM Andrew Pinski w= rote: > On Tue, Jul 25, 2023 at 1:54=E2=80=AFPM Andrew Pinski = wrote: > > > > On Tue, Jul 25, 2023 at 12:45=E2=80=AFPM Jakub Jelinek via Gcc-patches > > wrote: > > > > > > On Tue, Jul 25, 2023 at 03:42:21PM -0400, David Edelsohn via > Gcc-patches wrote: > > > > Hi, Drew > > > > > > > > Thanks for addressing this missed optimization. > > > > > > > > The testcase includes an incorrect assumption: signed char, which > > > > causes the testcase to fail on PowerPC. > > > > > > > > Should the testcase be updated to specify signed char in the functi= on > > > > signatures or should -fsigned-char be added to the command line > > > > options? > > > > > > I think we should use signed char instead of char in the testcase. > > > > I also think it should be `signed char` instead as I mentioned in > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110803 . > > Committed the testsuite fix as r14-2767-g67357270772b91 . > > Thanks, > Andrew > > > > > Thanks, > > Andrew > > > > > > > > Jakub > > > > > --00000000000010ea93060163f2e5--