public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets
@ 2013-03-08 12:19 Kai Tietz
  2013-03-08 12:23 ` Rainer Orth
  0 siblings, 1 reply; 3+ messages in thread
From: Kai Tietz @ 2013-03-08 12:19 UTC (permalink / raw)
  To: GCC Patches

Hello,

this patch fixes 23 regressions about LTO and double-defined symbols for
memcpy/memset.  Issue is that for mingw-targets the C-runtime functions aren't
weak and not necessarily overridable.

ChangeLog

2013-03-08  Kai Tietz  <ktietz@redhat.com>

	* gcc.c-torture/execute/builtins/builtins.exp: Add for mingw
	targets linker option --allow-multiple-definition.

Ok for apply ?

Regards,
Kai

Index: builtins.exp
===================================================================
--- builtins.exp        (Revision 196543)
+++ builtins.exp        (Arbeitskopie)
@@ -42,6 +42,7 @@ if [istarget "powerpc-*-darwin*"] {
    lappend additional_flags "-Wl,-multiply_defined,suppress"
 }
 if { [istarget *-*-eabi*]
+     || [istarget *-*-mingw*]
      || [istarget *-*-elf] } {
    lappend additional_flags "-Wl,--allow-multiple-definition"
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets
  2013-03-08 12:19 [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets Kai Tietz
@ 2013-03-08 12:23 ` Rainer Orth
  2013-03-08 13:11   ` Kai Tietz
  0 siblings, 1 reply; 3+ messages in thread
From: Rainer Orth @ 2013-03-08 12:23 UTC (permalink / raw)
  To: Kai Tietz; +Cc: GCC Patches

Hi Kai,

> Index: builtins.exp
> ===================================================================
> --- builtins.exp        (Revision 196543)
> +++ builtins.exp        (Arbeitskopie)
> @@ -42,6 +42,7 @@ if [istarget "powerpc-*-darwin*"] {
>     lappend additional_flags "-Wl,-multiply_defined,suppress"
>  }
>  if { [istarget *-*-eabi*]
> +     || [istarget *-*-mingw*]
>       || [istarget *-*-elf] } {

please keep the list sorted.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets
  2013-03-08 12:23 ` Rainer Orth
@ 2013-03-08 13:11   ` Kai Tietz
  0 siblings, 0 replies; 3+ messages in thread
From: Kai Tietz @ 2013-03-08 13:11 UTC (permalink / raw)
  To: Rainer Orth; +Cc: GCC Patches

2013/3/8 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> Hi Kai,
>
>> Index: builtins.exp
>> ===================================================================
>> --- builtins.exp        (Revision 196543)
>> +++ builtins.exp        (Arbeitskopie)
>> @@ -42,6 +42,7 @@ if [istarget "powerpc-*-darwin*"] {
>>     lappend additional_flags "-Wl,-multiply_defined,suppress"
>>  }
>>  if { [istarget *-*-eabi*]
>> +     || [istarget *-*-mingw*]
>>       || [istarget *-*-elf] } {
>
> please keep the list sorted.
>
> Thanks.
>         Rainer

Applied after adjusting.

Thanks,
Kai

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-08 13:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-08 12:19 [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets Kai Tietz
2013-03-08 12:23 ` Rainer Orth
2013-03-08 13:11   ` Kai Tietz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).