bootstrap failure for cygwin, mingw targets due recent changes to hash_table

bootstrap failure for cygwin, mingw targets due recent changes to hash_table

[Kai Tietz]

Hi Trevor,

your recent commits have broken bootstrap for cygwin/mingw i386 targets with:

../../gcc/gcc/config/i386/winnt.c: In Funktion »unsigned int
i386_pe_section_type_flags(tree, const char*, int)«:
../../gcc/gcc/config/i386/winnt.c:503:61: Fehler: keine passende
Funktion für Aufruf von »hash_table<pointer_hash<unsigned int>
>::find_slot(const unsigned int*, insert_option)«
   slot = htab->find_slot ((const unsigned int *)name, INSERT);
                                                             ^
../../gcc/gcc/config/i386/winnt.c:503:61: Anmerkung: Kandidat ist:
In file included from ../../gcc/gcc/config/i386/winnt.c:35:0:
../../gcc/gcc/hash-table.h:1030:15: Anmerkung: hash_table<Descriptor,
Allocator, true>::value_type* hash_table<Descriptor, Allocator,
true>::find_slot(const val
ue_type&, insert_option) [with Descriptor = pointer_hash<unsigned
int>; Allocator = xcallocator; hash_table<Descriptor, Allocator,
true>::value_type = unsigned int*] <nahe Übereinstimmung>
   value_type *find_slot (const value_type &value, insert_option insert)
               ^
../../gcc/gcc/hash-table.h:1030:15: Anmerkung:   keine bekannte Umwandlung für A
rgument 1 von »const unsigned int*« nach »unsigned int* const&«
../../gcc/gcc/config/i386/t-cygming:26: recipe for target 'winnt.o' failed
make[1]: *** [winnt.o] Error 1
make[1]: Leaving directory '/home/ktietz/source/gcc-head/buildw64/gcc'
Makefile:4006: recipe for target 'all-gcc' failed
make: *** [all-gcc] Error 2

Please fix that or revert.

Thanks,
Kai

Re: bootstrap failure for cygwin, mingw targets due recent changes to hash_table

[Trevor Saunders]

On Tue, Jun 24, 2014 at 11:06:33PM +0200, Kai Tietz wrote:
> Hi Trevor,
> 
> your recent commits have broken bootstrap for cygwin/mingw i386 targets with:

should be fixed in r211962.  Sorry I didn't realize the const
qualification thing matter in other places, it didn't show up in core
gcc so I didn't think to test for it other places.  I supose it might be
argued that changing the qualification of the hash table entry is more
appropriate, but this code seems to be pretty fishey on the strong
typing front much less the const correctness one so I just did what
seemed safest.

btw it seems like the TARGET_SECTION_TYPE_FLAGS  macro is totally unused
at this point.

Trev

> 
> ../../gcc/gcc/config/i386/winnt.c: In Funktion »unsigned int
> i386_pe_section_type_flags(tree, const char*, int)«:
> ../../gcc/gcc/config/i386/winnt.c:503:61: Fehler: keine passende
> Funktion für Aufruf von »hash_table<pointer_hash<unsigned int>
> >::find_slot(const unsigned int*, insert_option)«
>    slot = htab->find_slot ((const unsigned int *)name, INSERT);
>                                                              ^
> ../../gcc/gcc/config/i386/winnt.c:503:61: Anmerkung: Kandidat ist:
> In file included from ../../gcc/gcc/config/i386/winnt.c:35:0:
> ../../gcc/gcc/hash-table.h:1030:15: Anmerkung: hash_table<Descriptor,
> Allocator, true>::value_type* hash_table<Descriptor, Allocator,
> true>::find_slot(const val
> ue_type&, insert_option) [with Descriptor = pointer_hash<unsigned
> int>; Allocator = xcallocator; hash_table<Descriptor, Allocator,
> true>::value_type = unsigned int*] <nahe Ãœbereinstimmung>
>    value_type *find_slot (const value_type &value, insert_option insert)
>                ^
> ../../gcc/gcc/hash-table.h:1030:15: Anmerkung:   keine bekannte Umwandlung für A
> rgument 1 von »const unsigned int*« nach »unsigned int* const&«
> ../../gcc/gcc/config/i386/t-cygming:26: recipe for target 'winnt.o' failed
> make[1]: *** [winnt.o] Error 1
> make[1]: Leaving directory '/home/ktietz/source/gcc-head/buildw64/gcc'
> Makefile:4006: recipe for target 'all-gcc' failed
> make: *** [all-gcc] Error 2
> 
> Please fix that or revert.
> 
> Thanks,
> Kai