From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74078 invoked by alias); 31 Jul 2015 16:26:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74061 invoked by uid 89); 31 Jul 2015 16:26:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 31 Jul 2015 16:26:00 +0000 Received: by wibud3 with SMTP id ud3so38652148wib.0 for ; Fri, 31 Jul 2015 09:25:57 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.97.129 with SMTP id ea1mr8752234wib.24.1438359957253; Fri, 31 Jul 2015 09:25:57 -0700 (PDT) Received: by 10.27.176.72 with HTTP; Fri, 31 Jul 2015 09:25:57 -0700 (PDT) In-Reply-To: <55BB9EDB.8030305@redhat.com> References: <557A5214.7060106@redhat.com> <1424811417.1214725.1434125493982.JavaMail.zimbra@redhat.com> <557BAE5A.7030309@redhat.com> <55B661A1.6090308@redhat.com> <55B911DD.30105@redhat.com> <55BA5667.9040200@redhat.com> <55BAE20A.1070400@redhat.com> <55BB9EDB.8030305@redhat.com> Date: Fri, 31 Jul 2015 16:43:00 -0000 Message-ID: Subject: Re: C++ delayed folding branch review From: Kai Tietz To: Jason Merrill Cc: Jeff Law , Kai Tietz , gcc-patches List Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02687.txt.bz2 2015-07-31 18:14 GMT+02:00 Jason Merrill : > On 07/30/2015 10:48 PM, Jeff Law wrote: >> >> Note, anything outside of the C/C++ front-ends depending on that >> canonicalization done by shorten_compare is, IMHO, broken. > > > I think the OMP code isn't relying on it being done by shorten_compare; it's > trying to do it itself in c_finish_omp_for but is somehow thwarted by > delayed folding. > > Jason > Well, this seems to be reasoned by finish_omp_for (), which gets invoked in parser.c cp_parser_omp_for_loop, and/or pt.c: tsubst_expr. In all those cases arguments aren't folded anymore. So c_finish_omp_for's patterns don't match anymore. I guess we might want to do this cannonical form in genericize-pass? Kai