* [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32
@ 2012-11-29 12:09 Kai Tietz
2012-11-29 18:18 ` Ian Lance Taylor
0 siblings, 1 reply; 4+ messages in thread
From: Kai Tietz @ 2012-11-29 12:09 UTC (permalink / raw)
To: GCC Patches
Hello,
this trivial patch fixes a bootstrap issue on LLP64 hosts.
ChangeLog
2012-11-29 Kai Tietz
PR target/53912
* prefix.c (lookup_key): Explicit cast return-type of xmalloc/xrealloc
to char *.
Tested for i686-w64-mingw32, x86_64-w64-mingw32, and
x86_64-unknown-gnu-linux. Ok for apply?
Regards,
Kai
Index: prefix.c
===================================================================
--- prefix.c (Revision 193925)
+++ prefix.c (Arbeitskopie)
@@ -157,12 +157,12 @@ lookup_key (char *key)
}
size = 32;
- dst = xmalloc (size);
+ dst = (char *) xmalloc (size);
res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
if (res == ERROR_MORE_DATA && type == REG_SZ)
{
- dst = xrealloc (dst, size);
+ dst = (char *) xrealloc (dst, size);
res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32
2012-11-29 12:09 [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32 Kai Tietz
@ 2012-11-29 18:18 ` Ian Lance Taylor
2012-11-29 18:28 ` Kai Tietz
0 siblings, 1 reply; 4+ messages in thread
From: Ian Lance Taylor @ 2012-11-29 18:18 UTC (permalink / raw)
To: Kai Tietz; +Cc: GCC Patches
On Thu, Nov 29, 2012 at 4:09 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>
> ChangeLog
>
> 2012-11-29 Kai Tietz
>
> PR target/53912
> * prefix.c (lookup_key): Explicit cast return-type of xmalloc/xrealloc
> to char *.
>
> Tested for i686-w64-mingw32, x86_64-w64-mingw32, and
> x86_64-unknown-gnu-linux. Ok for apply?
>
> Regards,
> Kai
>
> Index: prefix.c
> ===================================================================
> --- prefix.c (Revision 193925)
> +++ prefix.c (Arbeitskopie)
> @@ -157,12 +157,12 @@ lookup_key (char *key)
> }
>
> size = 32;
> - dst = xmalloc (size);
> + dst = (char *) xmalloc (size);
>
> res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
> if (res == ERROR_MORE_DATA && type == REG_SZ)
> {
> - dst = xrealloc (dst, size);
> + dst = (char *) xrealloc (dst, size);
> res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
> }
This code should be using the XNEWVEC and XRESIZEVEC macros.
Ian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32
2012-11-29 18:18 ` Ian Lance Taylor
@ 2012-11-29 18:28 ` Kai Tietz
2012-11-29 18:33 ` Ian Lance Taylor
0 siblings, 1 reply; 4+ messages in thread
From: Kai Tietz @ 2012-11-29 18:28 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: GCC Patches
Fine. Tested patch using XNEWVEC/XRESIZEVEC for this. Ok for apply?
Kai
Index: prefix.c
===================================================================
--- prefix.c (Revision 193939)
+++ prefix.c (Arbeitskopie)
@@ -157,12 +157,12 @@ lookup_key (char *key)
}
size = 32;
- dst = xmalloc (size);
+ dst = XNEWVEC (char, size);
res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
if (res == ERROR_MORE_DATA && type == REG_SZ)
{
- dst = xrealloc (dst, size);
+ dst = XRESIZEVEC (char, dst, size);
res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32
2012-11-29 18:28 ` Kai Tietz
@ 2012-11-29 18:33 ` Ian Lance Taylor
0 siblings, 0 replies; 4+ messages in thread
From: Ian Lance Taylor @ 2012-11-29 18:33 UTC (permalink / raw)
To: Kai Tietz; +Cc: GCC Patches
On Thu, Nov 29, 2012 at 10:27 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> Fine. Tested patch using XNEWVEC/XRESIZEVEC for this. Ok for apply?
This is OK with a ChangeLog entry.
Thanks.
Ian
> Index: prefix.c
> ===================================================================
> --- prefix.c (Revision 193939)
> +++ prefix.c (Arbeitskopie)
> @@ -157,12 +157,12 @@ lookup_key (char *key)
> }
>
> size = 32;
> - dst = xmalloc (size);
> + dst = XNEWVEC (char, size);
>
> res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
> if (res == ERROR_MORE_DATA && type == REG_SZ)
> {
> - dst = xrealloc (dst, size);
> + dst = XRESIZEVEC (char, dst, size);
> res = RegQueryValueExA (reg_key, key, 0, &type, (LPBYTE) dst, &size);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-29 18:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-29 12:09 [patch prefix.c]: 4 of 7 Fix of PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32 Kai Tietz
2012-11-29 18:18 ` Ian Lance Taylor
2012-11-29 18:28 ` Kai Tietz
2012-11-29 18:33 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).