From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67732 invoked by alias); 2 May 2017 10:40:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67705 invoked by uid 89); 2 May 2017 10:40:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=kai, H*f:sk:WpsVuMR, H*f:sk:PM7g@ma X-HELO: mail-vk0-f68.google.com Received: from mail-vk0-f68.google.com (HELO mail-vk0-f68.google.com) (209.85.213.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 10:40:12 +0000 Received: by mail-vk0-f68.google.com with SMTP id e15so9703250vkd.1 for ; Tue, 02 May 2017 03:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xdIl5kU7Ug+xLMtEZeQFZxtq2VyYLxSt4mQt18XL3Xs=; b=k4ViLoOG1MnYIbHurUD+NEhnpQfAQy/fyUQGsCPX41eUE/VLW7M2RJ3x3/+qT3Cvb7 vl0s8KRJu4NHl8RVaBHw+69hgH+k796nP9QlXp/ZqkoCfkm/9zDNNF8WzD5itCKGiIFc xw7sOWvH1sg0VAEz8Igppj05XrdTWNaHAZJ7Gz/QOx8gxVOpQO9/gZP8TaG7fWGS1VLB Z7Q5VI5iK/bPdvU6fs6nEY00XvMkq9n3csNwh4LDekNL9/q+cibhucG2NYEkuuFY+Alc pcPpSREb2SSn1cYdA0IZSzjFZAeKrhOEcmGHA97t1JWH266lyVlFvNfyFisCJyb9/LZn GUKw== X-Gm-Message-State: AN3rC/7MH4Dl89xTq/y1PLUyIEuj86HHhw3GrvUaubCAKeofD89D9kEQ aQTn50npNjUjq0M0IwMnCNigDe8hdw== X-Received: by 10.31.107.211 with SMTP id k80mr543374vki.64.1493721613298; Tue, 02 May 2017 03:40:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.18.218 with HTTP; Tue, 2 May 2017 03:40:12 -0700 (PDT) In-Reply-To: References: <49e81c0b-07a4-22df-d7c3-2439177ac7cf@pobox.com> From: Kai Tietz Date: Tue, 02 May 2017 10:45:00 -0000 Message-ID: Subject: Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues To: JonY <10walls@gmail.com> Cc: Uros Bizjak , Daniel Santos , gcc-patches , Jan Hubicka Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00081.txt.bz2 2017-05-02 12:21 GMT+02:00 JonY <10walls@gmail.com>: > On 05/01/2017 11:31 AM, Uros Bizjak wrote: >> On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos wrote: >>> All of patches are concerned with 64-bit Microsoft ABI functions that call >>> System V ABI function which clobbers RSI, RDI and XMM6-15 and are aimed at >>> improving performance and .text size of Wine 64. I had previously submitted >>> these as separate patch sets, but have combined them for simplicity. (Does >>> this make the ChangeLogs too big? Please let me know if you want me to break >>> these back apart.) Below are the included patchsets and a summary of changes >>> since the previous post(s): >> >> Well, the ChangeLog is acceptable. >> >> I have comments on how new RTX patterns are generated and checked >> (patches 9/12 and 11/12). Other patches look good to me, so after >> issues with 9/12 and 11/12 are resolved, I think the patch set is >> ready to go. >> >> After the above issue is addressed, I propose to move forward by >> committing the patchset, and resolve any possible issues later. There >> are just too many code paths in the stack frame construction and >> teardown to notice all possible interactions between new and old code. >> It looks that existing code won't be affected without activating new >> option, so we can be a bit less cautious with the patchset. An >> important part is thus a comprehensive added test suite, which seems >> to pass. >> >> I also assume that Cygwin and MinGW people agree with the patch and >> the functionality itself. >> >> Uros. >> > > Cygwin and MinGW does not use SysV/MS transitions directly in their own > code, changes should be OK. > > > Right, and Wine people will tell, if something doesn't work for them. So ok for me too. Kai