From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13779 invoked by alias); 11 Jul 2014 18:30:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13723 invoked by uid 89); 11 Jul 2014 18:30:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f47.google.com Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Jul 2014 18:29:58 +0000 Received: by mail-oa0-f47.google.com with SMTP id g18so1623514oah.6 for ; Fri, 11 Jul 2014 11:29:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=gML/cL/GR/oNPx4HDgw8zM1cYTWGusCLEr4MoWUyjVE=; b=Kgu8e8HqOvOL8DnfeBR/UBi1U0aKhGILOcQUVdT448rwxfmc750ouKG97LLOFAb5g4 Dag8vMdWC0h/RuJM2TyFkPtv5Hj8aNkmaS3TZcK5S37kBPEWc02B613AZo/kIVLoKXF5 xuH7dbVaTaRsIsYmv/GY3U0WOpQAA08RAAnU2bObtGH1U6ohxYbvva3sdA/ib0i06+NE BBK8P1s5F0IdcLGIHsprRBvnBCfZgBI9hp/TuGgobqLHdMFRl3VUE/bwLbsuV1COjAGJ NDeB+QkbtzeJEMSmz4797ckXxrfs1Wz5z4Xoc9Zu7kCVNKrX+oijR/fL1vANXwOPhmeo JKkw== X-Gm-Message-State: ALoCoQkzk7QQNOC/ub5PsjA37Sd2o1VvzVSku8r+NCduEz/gsuN9SOGHsusdqNfaUE/ieirZRpcO MIME-Version: 1.0 X-Received: by 10.60.42.132 with SMTP id o4mr846174oel.66.1405103396397; Fri, 11 Jul 2014 11:29:56 -0700 (PDT) Received: by 10.182.44.198 with HTTP; Fri, 11 Jul 2014 11:29:56 -0700 (PDT) In-Reply-To: References: <20140415213850.GA23141@atrey.karlin.mff.cuni.cz> <20140417033448.GC3157@kam.mff.cuni.cz> <20140711154426.GX31640@tucnak.redhat.com> Date: Fri, 11 Jul 2014 18:30:00 -0000 Message-ID: Subject: Re: [PATCH] offline gcda profile processing tool From: Rong Xu To: Xinliang David Li Cc: Jakub Jelinek , Richard Biener , Jan Hubicka , GCC Patches , Xinliang David Li , Teresa Johnson , Dehao Chen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00853.txt.bz2 Richard, I looked at my patch again. I already add -Wno-error to libgcov-util.o compilation: In line 200 of gcc/Makefile.in libgcov-util.o-warn =3D -Wno-error In my test, I used gcc-4.6 as the host compiler. I got warning like this: In file included from ../../gcc/gcc/../libgcc/libgcov-util.c:30:0: ../../gcc/gcc/../libgcc/libgcov.h:184:30: warning: ISO C++ forbids zero-size array =E2=80=98ctrs=E2=80=99 [-pedantic] Can you check your buildlog to see if -Wno-error is added to the command li= ne? Thanks, -Rong On Fri, Jul 11, 2014 at 9:47 AM, Rong Xu wrote: > I did see the warning in the bootstrap, but it did not exit the build. > I thought it was ok. > > I'll have a patch for this and send for review. > > -Rong > > On Fri, Jul 11, 2014 at 9:13 AM, Xinliang David Li w= rote: >> right. >> >> Rong, the fix would be just change ctr array size to 1. For each >> function, there should be at least one kind of counters -- see the >> assertion in build_fn_info_type. There are some code that do >> 'sizeof(gcov_fn_info)' when computing heap size -- they can be >> adjusted or leave it as it is (if not doing memcpy for the whole >> array). >> >> David >> >> On Fri, Jul 11, 2014 at 8:44 AM, Jakub Jelinek wrote: >>> On Fri, Jul 11, 2014 at 08:42:27AM -0700, Xinliang David Li wrote: >>>> I wonder why. The struct definition for gcov_fn_info has not changed >>>> in this patch. >>> >>> Perhaps it has been used only in C until now? >>> >>> Jakub