From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 4D77A3858C52 for ; Thu, 29 Feb 2024 18:10:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D77A3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D77A3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709230203; cv=none; b=ZOPsqy1wtLnXczwhXPLtB0kGh1yvd/q3gGmK+/8cdZQyF2gIBae/5ffSNr5xyO2973q843X4VeDmRQX/7Grosd//dUVVZkZWMh5LdfbeCysbsJ2yVIxGk0iTBh+SAKH69lzDX28JG0nS9KuyOa5FhWhyQO2yqP1AOiQaonL9HUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709230203; c=relaxed/simple; bh=FwsL3F9Z9EE7CCF01XmPPDE+Ezy4AqHaYGW5JfzWg98=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=BewkazIxNPOhu8/z1ugM1wDKydY+I5EMh/0PqrZ0jxxKh8DbKX+omwWh3IGBJ7Uut0xMlgQhp6sWwVTHOdJ04IKCuyjBCl8bwX5gAT/W9dVXA7eWlmVspOnJCTBJjItyTC76l4DsaxHpecNB5xPGLes4ghGjnsmDyZpGLOtMRyY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a44282a09bdso195902166b.1 for ; Thu, 29 Feb 2024 10:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709230198; x=1709834998; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ylk+I2bCd1doj940LnPyniEYGAuFhuhhdsYggO7vJ/o=; b=X//iQegbysA8XaYHSOUMlW+kjJzK81/GsqoT2k+rkkVItI4d6cyiygKogH/QWMcvcZ TgYZHB2TRh7h3OJsUj8mZ/DhIWQhNK8HgCklbKUzjujMwqaF9pWBVDBymTrsx+H7Flhu 27FtXW96CcLVNPXKQHQbWke3xpjZACMcAPC3hbDJhteJf4IOb8pRzAuB4kHanrXHW8zy hmFLM/W4JTu8dvI+KrlDInDltkD5VEcuijCMb6+6JioDaWHisvtyqfxn6O5Go8/rQesJ FMW9FUtevnpTn6k932pCRo64tzSF5i2T7eUigUQzaI1RYLLzSK8MkA+gqW2P2oWgDJYe 9KXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709230198; x=1709834998; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ylk+I2bCd1doj940LnPyniEYGAuFhuhhdsYggO7vJ/o=; b=PUTweEVg3kTmEEii+sFhdcFma4Xfi1Jn0RZcPb1YC9uG0ngbyhc9anuUfOqkfHnrTo mWKPzreoKnYiMoYo3yzqOGpPFWqGQobdZngvx0CnPy/rwOaJk7Y029VGZQughQttacA8 46NrbC9PAnF6lnUQgrKbaxtD/buMqCslAAxzdChZl1XOGEbEO8FOJfoPoXyCX+dse/xr IubAqUHsH/LXEQ5Jj0/fZvtPccxidP2yaaI6z9yFul4gUJd0XpUi3MXS/JutRRtsgCJ+ /AMUuLsb25yD3Mf9SvLK6LqCsDC0ReD2q5aRJS0HqEakpf8MWthYWFO2vP02fhbbejgd ZrWw== X-Gm-Message-State: AOJu0YyGjM3RgSd6nc0FQCpyBqDdXJZBG3uUqQVXHj6PilMPq+B07LUi VZQ5mugfxNo+oxxFzP/7UPXLx2OZx+IW3Dm/1nxpbcHQouvEqwXCOsfsk+EDZYFkS3cvv+3zJL+ Z2dRL3k8WaFT9LraogAcHd2iWx0U= X-Google-Smtp-Source: AGHT+IF9um39lI4BQlux9z57ZTW865uRH9ZkVwp8fwer0Fo5tH8PHWwHyn2Lkguuq9KJl1omfeOkIkEP/GE1QPOno+M= X-Received: by 2002:a17:906:c30a:b0:a43:552a:9572 with SMTP id s10-20020a170906c30a00b00a43552a9572mr2157276ejz.30.1709230198293; Thu, 29 Feb 2024 10:09:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: NightStrike Date: Thu, 29 Feb 2024 13:09:47 -0500 Message-ID: Subject: Re: [PATCH v1 00/13] Add aarch64-w64-mingw32 target To: Evgeny Karpov Cc: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" , "10walls@gmail.com" <10walls@gmail.com>, Maxim Kuvyrkov , "mark@harmstone.com" , Zac Walker , Ron Riddle , Radek Barton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 29, 2024 at 11:26=E2=80=AFAM Evgeny Karpov wrote: > > Monday, February 26, 2024 2:30 AM > NightStrike wrote: > > > To be clear, because of the refactoring, it will affect x86/x64 Windows= targets. > > Can you do a testsuite run before and after and see that it doesn't get= worse? > > The full testsuite for all languages for Windows isn't in great shape, = but it's not > > awful. Some languages, like Rust and Fortran, have ~10 FAILs. C and C= ++ have > > several thousand. > > > > In particular, there are quite a few testsuite test FAILs regarding MS = ABI that > > hopefully do not get worse. > > > > Thank you for bringing it up! Our CI will be extended to test the x64 > mingw target and calculate a delta, starting from patch series v2. Thanks. You should probably include x86 also, at least for all the areas that overlap. I would like to compare my own test results with yours when you have that ready. You can send test results to the gcc mailing list setup for this purpose: https://gcc.gnu.org/mailman/listinfo/gcc-testresults, and there are scripts in contrib/ to help automate the process. I personally stopped, because the clusters I used had their mail sending capabilities cut off, but I'm working on fixing that. > > Lastly, I don't think I see in the current patch series where you add n= ew > > testsuite coverage for aarch64-specific bits. I probably missed it, so= feel free to > > helpfully correct me there :) I'd be curious to see how the tests were= written to > > take into account target differences (using for example the dejagnu fea= ture > > procs) and other nuances. > > Tests have not been added yet. This does not mean they do not exist > or are not used. They are implemented and used in our CI, and will be > contributed to the aarch64-w64-mingw32 target in the next patch > series. > https://github.com/Windows-on-ARM-Experiments/mingw-woarm64-build/tree/ma= in/tests Awesome! These tests look like they are handled by your own custom test harness, so hopefully it won't be too difficult to convert it all to dejagnu. Honestly, the sooner you do that, the better, because the task is going to balloon. You'll find that Deja offers all kinds of neat and useful features that allow you to test all kinds of things, so it'll result in better coverage in the end.