From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id A58663858C83 for ; Wed, 11 Jan 2023 10:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A58663858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32d.google.com with SMTP id m6-20020a9d7e86000000b0066ec505ae93so8524931otp.9 for ; Wed, 11 Jan 2023 02:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=G0EwYiF5OumShSVkq0Kbranub1g7ufrW5wKlXAYQKvM=; b=OF/r3/1MJJpHXgIw7N7YO1zt8PwP5aj7GSIiowvxRubYQTs9xLQEXFm9oULNDYlPA6 7d4LgyteAoR64iyM9jVqjFOaihSWiuukkWmCmZbR+pmPDffdfo56FwpabvxCML33SpxT U8ZEZ0psQMW+c2zZF8UdsHKB9LuR4FVXh0+5dKI+vPut3B0WgclDqF6eriEvydxdWnr1 ab7MHsPzhgGKThX3lJzDBr2Xf7s3QArPBfLHKV6GUnkLYoxUwVdZUl04IGsQ2jnRifo/ sWtNGJCJRHksrRYBqRZOJjv+R3Xk8Ed2+RX7yiZjbWnY0FAydmed67AMky5KxRaLsSKE x0Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G0EwYiF5OumShSVkq0Kbranub1g7ufrW5wKlXAYQKvM=; b=MsfS1aoMJSBHAFaJqq5IVfN5zNpw2wa7zTa6Oeh2VAHf8dNY0y/oI1OjenGySz27Wq YvMRhPNNjMAhuT8KCzGyZCVIjDrEYsedkoUQH3JV3U74p2YSi816+fwAdrQCluzfG2Zy KafEuFgh3eMy3y/VZe/IcmCnv9E5zmIQK90BtnXpLwX7cUFzG5a+he/Ddk0WfSC8NNXt HGn6UF64XAquivG6sSSNYyyudNw8HaTOSaneTMKaS5SbbANn1ZNKSGMSArgqDw5g7xbt bl8fZmnDIwJLpGdaTFU4CT6gh3G9FpWUC9UeoWk8WE+vmT+mM3HD7NjmLB6WLJxkMgCz PdRg== X-Gm-Message-State: AFqh2krtTQYeREPlBou0puOi8jM/nFFJvVjX752+T5CKKZZYD1JHv26c vkYZNAjf6n8cvYaiadnbkZLs/5wSSEx+mYjPO16IUfNI5PI= X-Google-Smtp-Source: AMrXdXv1CfL3bQRfbNylgOuMnalYcpEdeNkyFBuBFb52Xd0qrBXCoPaz/pXlOpOTG2f1FJ9MpgxD6wSEV2hmJe+xP8k= X-Received: by 2002:a05:6830:2049:b0:672:6b44:379c with SMTP id f9-20020a056830204900b006726b44379cmr4661817otp.169.1673431864940; Wed, 11 Jan 2023 02:11:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: NightStrike Date: Wed, 11 Jan 2023 05:10:50 -0500 Message-ID: Subject: Re: [committed] testsuite: Add testcases from PR108292 and PR108308 To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 11, 2023 at 4:43 AM Jakub Jelinek wrote: > > On Wed, Jan 11, 2023 at 04:27:11AM -0500, NightStrike wrote: > > On Wed, Jan 11, 2023 at 4:07 AM Jakub Jelinek wrote: > > > > > > On Wed, Jan 11, 2023 at 03:58:40AM -0500, NightStrike wrote: > > > > On Fri, Jan 6, 2023 at 4:56 AM Jakub Jelinek via Gcc-patches > > > > wrote: > > > > > --- gcc/testsuite/gcc.dg/pr108308.c.jj 2023-01-06 10:43:45.793009294 +0100 > > > > > +++ gcc/testsuite/gcc.dg/pr108308.c 2023-01-06 10:43:40.218090375 +0100 > > > > > @@ -0,0 +1,39 @@ > > > > > +/* PR target/108308 */ > > > > > +/* { dg-do run { target { ilp32 || lp64 } } } */ > > > > > > > > This test passes on Windows, and I don't see anything in the test that > > > > jumps out at me as being affected by storing pointers in longs. Is > > > > there something I'm missing about why this would be disabled on LLP64? > > > > > > Maybe the test just needs int32, it didn't look important enough to me. > > > ilp32 || lp64 covers most of important targets. > > > > Could you change to int32plus, then? > > I think int32plus would be wrong, the testcase has some overlarge constant > and I doubt it would work correctly on the hypothetical target with 64-bit > ints where the overlarge constant would fit into int. Ok, then: /* { dg-do run { target { { ilp32 || lp64 } || llp64 } } } */ or even: /* { dg-do run { target { ! int16 } } } */ Though I'd point out that in your original message, you only cared about the "important targets". I don't think nonexistent ones where sizeof(int) == 8 qualifies :)