From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 324543858D1E for ; Mon, 26 Feb 2024 01:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 324543858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 324543858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708911720; cv=none; b=H7GyhhXI5RRyB6P/D5xdjzx8qrlEagLrsOACxxrpO2S4hqb+hZFjwqdKxfDcFcb6qA3CoUlf61JHyrAAfPJH/57yQHYnblZn0dum6u2lwm/xza9wnGvtXfPz2nHle6jjE8ULV+FREIUdQckvfnzCzA70caZtm154hrxeJurkO7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708911720; c=relaxed/simple; bh=HNUMN/0+wQRgd+POATKsurk0d8M/cc6gj0TGUlKnCwk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=iKHUFMKg4cBa3UWes8Oj0quvxIBi8jBaWi37qzdu9oSly78jhcgdzZedBpmnum5apQpKS7wT+bVmj2viPgmC0L5Ni7OFpNza4qXZD6l0Un26XaWx5AtZ1hJSfYA9QGHSGqcb6Ruo/yaYk+yIPdERhF07RxSRY47nF2NpoEMkXUU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-564372fb762so3644621a12.0 for ; Sun, 25 Feb 2024 17:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708911717; x=1709516517; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HNUMN/0+wQRgd+POATKsurk0d8M/cc6gj0TGUlKnCwk=; b=TcnxEBH7nq2y03GWn6Xdk5i5QuONz/I3jJcItapd2kr2ZTKu77r3aXvPFLz64+nINT fn8+C0qEJzRXa6qXYhGgrzFboWPn4fPvZgVoA9XiNoVZQE0Q4+SquqnUMhbGUMidhnAy zRVE2s3wEK8r7soEX6o7L6izSQ5krj0L9j2+g7Oq98cZ0EkLuIJwzdy+Ht+QsuKphIIS aovmOybAuRvwW0/g29xKCw2eOO2m2dtcOZN+pVw8aYda7e1gLiOXvU4gwMYhgUrkD3CH q09oWwomLgo1MC/4lBbJPPiECe1e1rOvGVoCAKDiQ+6KxtKWO+yIy1NSDNePhsrzFXtF YKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708911717; x=1709516517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HNUMN/0+wQRgd+POATKsurk0d8M/cc6gj0TGUlKnCwk=; b=EBEJJlSYxIALs25HLK1YUxANDhFej1ek5HeYUctAK3fs4PXcYJJB3/1+fO66ByRmRs dIlXBX4jTxESf+vFhiI66vld4xQeubdk47fX//h8hzjSAFvIQZa7Li0PXKdve96Py4os xnc0EUtRm4A2tY+Fsl6iCu6D2J7gPOeittE2BRhsWwS76KBapneGFbwridHvvEX0d+0Q s/kBHf9sff7Pm/T5jTdyQrUvrXXHHUVRnhY7id4TLL3bCVhu5n/yXfG63bGBZ4SBGeB5 TMDOz/BQoUZOg8JcMWp0qBqT8lfbEPga3Sdxnuy4zt+rRMLCZmwHCpIvZLI+TaNttPRa rM4Q== X-Forwarded-Encrypted: i=1; AJvYcCUFE5sGE+0CmESSZteqE7Snp6S0smZW4iX7wgr6soXfSENtDIratLa4nRHvFM4+Mstd/JGKfx0vNukA/KqQks5WcWhfanzNgg== X-Gm-Message-State: AOJu0Yz1IUXyv+ZEosg+v0UCpSKBbsG7RHyLtiOa1lNJaeXnkQYMCWxi mhgX4sHI6dB91HH3TcEUMTx+xuXSPLEdfFJaPwdxk1C+HsvgyqOvteqAK+aVghBQ6urSeYghoSY Lji77ALesVWzsvghIyS392gQbqhw= X-Google-Smtp-Source: AGHT+IHjLbnCGBG2iBOhyhI8gCxp8CMTwOy931CS/FI13H4RfFR4c2LTkY3vFKvlvaMpuk9mqSMvLeNrWWMq0AZK5IE= X-Received: by 2002:a17:906:e204:b0:a3f:7d84:4d2e with SMTP id gf4-20020a170906e20400b00a3f7d844d2emr3870879ejb.30.1708911716836; Sun, 25 Feb 2024 17:41:56 -0800 (PST) MIME-Version: 1.0 References: <20240117115144.50181-1-matteo@mitalia.net> <6e99ca24-96b1-400b-8df7-3329b71b7dbc@mitalia.net> <5ae51fe8-3e30-4535-b272-e540bf62ab3a@126.com> <413f8fb6-6af3-48ab-9a9b-33e3ac9d46f7@mitalia.net> <82b90a96-99ce-4e9e-b4cc-11166b700327@gmail.com> <09006431-9e72-4573-98a5-123584c8526f@mitalia.net> In-Reply-To: <09006431-9e72-4573-98a5-123584c8526f@mitalia.net> From: NightStrike Date: Sun, 25 Feb 2024 20:41:45 -0500 Message-ID: Subject: Re: Ping: Re: [PATCH] libgcc: fix SEH C++ rethrow semantics [PR113337] To: Matteo Italia Cc: Jonathan Yong <10walls@gmail.com>, LIU Hao , GCC Patches , tristan.gingold@cern.ch Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 7, 2024 at 4:23=E2=80=AFAM Matteo Italia w= rote: > > Il 06/02/24 10:17, Jonathan Yong ha scritto: > > On 2/6/24 05:31, NightStrike wrote: > >> On Mon, Feb 5, 2024, 06:53 Matteo Italia wrote: > >> > >>> Il 31/01/24 04:24, LIU Hao ha scritto: > >>>> =E5=9C=A8 2024-01-31 08:08, Jonathan Yong =E5=86=99=E9=81=93: > >>>>> On 1/24/24 15:17, Matteo Italia wrote: > >>>>>> Ping! That's a one-line fix, and you can find all the details in t= he > >>>>>> bugzilla entry. Also, I can provide executables built with the > >>>>>> affected toolchains, demonstrating the problem and the fix. > >>>>>> > >>>>>> Thanks, > >>>>>> Matteo > >>>>>> > >>>>> > >>>>> I was away last week. LH, care to comment? Changes look fine to me. > >>>>> > >>>> > >>>> The change looks good to me, too. > >>>> > >>>> I haven't tested it though. According to a similar construction arou= nd > >>>> 'libgcc/unwind.inc:265' it should be that way. > >>> > >>> Hello, > >>> > >>> thank you for the replies, is there anything else I can do to help pu= sh > >>> this forward? > >>> > >> > >> Remember to mention the pr with the right syntax in the ChangeLog so t= he > >> bot adds a comment field. I didn't see it in yours, but I might have > >> missed > >> it. > >> > >>> > >> > > > > Thanks all, pushed to master branch. > > Thanks all :-) do you think this warrants backports? On one hand this is > a pretty niche feature, and I am probably the first to notice the > problem in ~12 years since that code was written, OTOH Win64/SEH was not > super widespread for a long time, and seems like a safe enough change. It's mostly up to you whether you want to make the patch and test it. > Also: should I explicitly mark PR113337 as resolved? The bot added the > reference to the commit, but the PR is still marked as "UNCONFIRMED". Looks like Jon did that a few days ago.