From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=VXWK=5R=gmail.com=nightstrike@sourceware.org>
Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b])
	by sourceware.org (Postfix) with ESMTPS id 353BE3858D20
	for <gcc-patches@gcc.gnu.org>; Fri, 20 Jan 2023 18:49:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 353BE3858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1442977d77dso7236425fac.6
        for <gcc-patches@gcc.gnu.org>; Fri, 20 Jan 2023 10:49:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=eehY082N9BlOsA02tnjklZwR2pXFBIVjH0UPMBG/37A=;
        b=B8Eiy8OHOFp15nusThQpgzR9HbqTS68JIJpxqaNgagAJ7oSiM5IPWwOd/UcmuncU5z
         bY0kqNBj8vkQIDd5Uut9WVMmoTBNSrfGVD/PxC+FCs8TwI9l9Zdcqe6XABH7rd9U9M9C
         801yrT7x5NtYqP7OXCp4nNhwA4dnL7pQxfAEuuPlRDaVNH1ADL412+jV98W/lJYCC6Th
         43pe3fY6KtRr0FU5NnACUBtkV0eKHYTu+mzXLm1Zkl7ccByjE9BaKgW5yJzJip0atcep
         0wINzohijD1qgrqmxlCIpk6A57TvZMwArdhg7Mk2WMV/cU/rLU6V4W+s3hItnjuSIn8B
         nklQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=eehY082N9BlOsA02tnjklZwR2pXFBIVjH0UPMBG/37A=;
        b=yAnvEJGGA0AK7jYM9KVDsAxRrt1URC55eylVubdiSuzhEdHw4DKYtaozUOPFEC9MS9
         lh0okVg0VsCogs3imaAbKMzBf9rmcJNa91j3/1/HcQPA7jE4GL1XUfJQ/m6ckqezUJVC
         YCQRCtwtknQ939dquvcyJx32aV+xnyzl34WWOmYABQFgdNIpvHSI3FGIxF1fob9EoPCK
         a/PZk+9y7NE4lEfTd3T+8cDzIKS1FF2ofikY5jy/xeZmWyK8QZPkJoplWy5N8O38t3Om
         9lYH66c0TnoWElgCL93mSdvtb0/DPXjAMmkUa4HEwK1aI70iG6a0JeYaiRImFzmSyBbz
         X26Q==
X-Gm-Message-State: AFqh2krxo+eVjzuSYeg3SfS23wDsLcaNkRlrn/ut4WjyXxfbIxo52j2E
	1O+946V9ipDFYlnb22QjbhkDh+QWMwuVS9PSEas=
X-Google-Smtp-Source: AMrXdXucajwl5HiJ3JrDTkJVe4i6cpBQZs3uSlH9yCXhcLVwVJaYrCTkGZRWLtVpGw2qdcJ6UZChmk92laUbcK2oBJw=
X-Received: by 2002:a05:6870:a708:b0:15e:d2ac:3185 with SMTP id
 g8-20020a056870a70800b0015ed2ac3185mr1261388oam.152.1674240544263; Fri, 20
 Jan 2023 10:49:04 -0800 (PST)
MIME-Version: 1.0
References: <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com> <87zgad82zn.fsf@debian>
In-Reply-To: <87zgad82zn.fsf@debian>
From: NightStrike <nightstrike@gmail.com>
Date: Fri, 20 Jan 2023 13:49:04 -0500
Message-ID: <CAF1jjLtaY0a16H7+VKbhBLoJQFAFD6FXyz1V9EHO57__5ar6yQ@mail.gmail.com>
Subject: Re: [PATCH] modula2/108144 - Fix multilib install of libgm2
To: Gaius Mulley <gaiusmod2@gmail.com>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Fri, Jan 20, 2023 at 1:40 PM Gaius Mulley via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Richard Biener <rguenther@suse.de> writes:
>
> > The following adjusts libgm2 to properly use the multilib build
> > infrastructure, thereby fixing the install with
> > --enable-version-specific-runtime-libs
> >
> > In particular config-ml.pl needs to be applied to generated Makefiles
> > as documented in the manual and we have to avoid clobbering the
> > variables via make arguments.  The explicit install rules used different
> > ways to construct the multilib dir which isn't necessary and breaks
> > when MUTLIDIR is now finally set correctly.  Instead use
> > $(toolexeclibdir).
> >
> > This results in some dead variables in the Makefile.am (and there were
> > some before), I refrained from doing even more changes here.
> >
> > Verified with an install with and without --enable-version-specific-runtime-libs
> > and checking the result.
> >
> > OK?
> >
> > Thanks,
> > Richard.
>
> Many thanks for this fix - and the deep magic AC_FOREACH config-ml.in
> recursion rhunes.  LGTM
>
> regards,
> Gaius

AC_FOREACH is obsolete and shouldn't be used in new code.  It's been
replaced with m4_foreach_w:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html