From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id DC5FD3858CDA for ; Wed, 11 Jan 2023 09:27:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC5FD3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-15027746720so14886206fac.13 for ; Wed, 11 Jan 2023 01:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3+8xkOcziuwMpIjEtfRZZYw+xz/Q7icIVp7lXzO1FSk=; b=m+5gIjxCZFzeDUgjKoRHystl63V0aFe+LeiyWe7C4BW+xhpMEzxPTaZpQ2AWKapA0e jiXOCCeIKXPrWSnrfEpJP774TkM25lsK23BShfS6gqNRS7bfjtuCP85S/NhZJxnoN7oH G6M8lAmZnmc+2mgkhvUQJDBm7Bfch0PUXkbkjyoU1huNjl857koZdZ07a3PZQkiM+EU+ wizQxuor/w2WTLzPF0LY0+pPd2j698v8xn9nfLseNz+JpA9yfAkF4TAkuu2LWRRqEacU L5Yr1svmr84fcDCJAyYchFIBQkBfSbxDnIbvbgwKN1hqUr2BGNFbynnqzrs9UXD+TKOe kDeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3+8xkOcziuwMpIjEtfRZZYw+xz/Q7icIVp7lXzO1FSk=; b=dJ6JsPKDKeg43LvGsjPBgsAJE8m7oMeovak1S5iNj7tWP4GqKrUmcdmvWEXdFl0B8A n9LA1Lz86N7MvXEixUW8RX/J9EFaDuDRus8AW8+m2/fSbcDmuCekMQcvtWwHrlm2oT8k Qeg1M5GqK9+tBwhUjKcUnsuil69b6X3kdxbU1mJRJz/q0TxIgIDKYBuvvGC/w9gUDmSm ZBLviQrUP/K6MqTKtKxju/+1ot9Eyfyj52zr4PKfhh/5j9kpshaoflwkvVzLVQxP556q eC/vXzJnpRcwgIsK5Td8ObkjSDC2+liajEBDc4+iL+AvQDbyiUwklxu7kAWntP4pi5KS e4aA== X-Gm-Message-State: AFqh2kpWGw5OjPj88iEETcIqRAUFNcCe7pBAq3tuEIP5dqKhIO5b21Du 0gH5aguMNkYTayWN7pvgV+ZO0+yYaqkS3wLwvxo= X-Google-Smtp-Source: AMrXdXurLFFHicwkxOlRECqubkhpoioYKXmzydD561qn1on4QpjgVvbhPp+8W0py0bKD/VpYJw/xuMtmSLjse2et6co= X-Received: by 2002:a05:6870:578f:b0:14f:ac78:ac7f with SMTP id i15-20020a056870578f00b0014fac78ac7fmr3932655oap.112.1673429245256; Wed, 11 Jan 2023 01:27:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: NightStrike Date: Wed, 11 Jan 2023 04:27:11 -0500 Message-ID: Subject: Re: [committed] testsuite: Add testcases from PR108292 and PR108308 To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 11, 2023 at 4:07 AM Jakub Jelinek wrote: > > On Wed, Jan 11, 2023 at 03:58:40AM -0500, NightStrike wrote: > > On Fri, Jan 6, 2023 at 4:56 AM Jakub Jelinek via Gcc-patches > > wrote: > > > --- gcc/testsuite/gcc.dg/pr108308.c.jj 2023-01-06 10:43:45.793009294 +0100 > > > +++ gcc/testsuite/gcc.dg/pr108308.c 2023-01-06 10:43:40.218090375 +0100 > > > @@ -0,0 +1,39 @@ > > > +/* PR target/108308 */ > > > +/* { dg-do run { target { ilp32 || lp64 } } } */ > > > > This test passes on Windows, and I don't see anything in the test that > > jumps out at me as being affected by storing pointers in longs. Is > > there something I'm missing about why this would be disabled on LLP64? > > Maybe the test just needs int32, it didn't look important enough to me. > ilp32 || lp64 covers most of important targets. Could you change to int32plus, then? -/* { dg-do run { target { ilp32 || lp64 } } } */ +/* { dg-do run { target { int32plus } } } */ Windows is still a secondary platform, so it'd be nice to keep as many tests working (and supported) as possible. I don't know what qualifies as "important targets", but this is an easy win (pun intended!)