From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 3A5913857835 for ; Fri, 17 Feb 2023 08:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A5913857835 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-170c8a8e206so598044fac.10 for ; Fri, 17 Feb 2023 00:56:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BqYSNSKspN01b9QRYF/AJWEUzJIPClW4eTEEGepmitA=; b=Kc1IP98xQjYkixSnwAqW53Yag3Mwle4q4JF0N9ShrIC35iQ/czyGyV/kNkcHmzpIhe cWEsrBBfheVy+c2KV4zXUC0435+6I9SWz+Q9dbwK5vEULY9977fffk9tOUT21mN9DA3i ir8VBqFQ7zNTjNlKt0uZ4+sR7Fpxj8B6sUYBPZkLsK6dZXpXUsUm1TLJDxF/qklN03Vf MFD/F85aXrlZcNoVSo0qUz75S0CzuxhJnMEC/QKpIotaY8l3rjnRZOUYoMXeTq2uv+oh UGftn7YNquewmQ+HP5GF5YpvkEvT7BqTKJOcoAkGnXIFfXsmBq5cJfHqfpvebw25DJfl 0SGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BqYSNSKspN01b9QRYF/AJWEUzJIPClW4eTEEGepmitA=; b=GOt/rsY5FqtY7CxRq2umO9orOAulbc1vppGVJRLG5GIrucuufjtG47KEC9uJhE3zqq bj8PxXCNpU4SvMEYNkekANBkJ9cLi/q4i9lDhhsIHPj1rBAmKPBp3JhVFGL2HqYfebL9 Wa2rNu3ZFzvuBrv7b1qKOZ+g/D9ccM1C/ko/oaoIxKWwMFuH6AANy/ivH7yXCWs6Vaio sg2biYIMEHlCXyF0QSHVGEmWvTx1dHpmXZnZ2BiwAQKw8IxRjDBKH83ky/UV/5mGAgyW mNtC1TJn7uddEzsEF359OqSjiX1ewz20y6PYCPIho0+FyEsdOE7+Kp65fh0dSFDa83aP qEFg== X-Gm-Message-State: AO0yUKUV/SaLjRmbN4uyvnQUTaN6JRtrd4iKKQ86za6t++YTBK6tAVaD QrqJlxNh06lO90OaXDEtg59FbY9dRubRuEhaltmU+aUE0WE= X-Google-Smtp-Source: AK7set8wzX9OCuinwBxT7u6mj7N4KIX2/Lgh4cThqY3A6n83tcgepn3twBFN+S+P3qw/NJDTUZoqOr4w0BQdWfskIvc= X-Received: by 2002:a05:6870:4b48:b0:16f:26df:64f3 with SMTP id ls8-20020a0568704b4800b0016f26df64f3mr141721oab.152.1676624188520; Fri, 17 Feb 2023 00:56:28 -0800 (PST) MIME-Version: 1.0 References: <8221231.NyiUUSuA9g@fomalhaut> <5906630.lOV4Wx5bFT@fomalhaut> In-Reply-To: <5906630.lOV4Wx5bFT@fomalhaut> From: NightStrike Date: Fri, 17 Feb 2023 03:56:18 -0500 Message-ID: Subject: Re: [PATCH] Fix PR target/90458 To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 16, 2023 at 3:16 AM Eric Botcazou wrote: > > > This fixes dg.exp/stack-check-2.c, -7, 8, and -16.c, which is great! > > Try the attached patch. Well... that patch just marks all of the tests as unsupported. But for example, the ones quoted above run, work, and pass. And when they didn't pass, they highlighted the ICE that you fixed. So running the test despite the nature of stack protection on Windows still has value. It is useful to ensure for example that stack protection continues to work even if options are passed to disable it. But the tests that remain are looking for rtl patterns that (I assume) shouldn't exist. So it's perhaps useful to modify the test to say that on windows, the scan-rtl-dump-times check should have zero hits. If it found a match, that would be an error. Is there a way to say that the test results should be inverted on a particular platform (instead of purely unsupported)?