public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][GCC] arm: Add Cortex-R52+ multilib
@ 2021-09-22  8:46 Przemyslaw Wirkus
  2021-09-22  9:46 ` Richard Earnshaw
  0 siblings, 1 reply; 5+ messages in thread
From: Przemyslaw Wirkus @ 2021-09-22  8:46 UTC (permalink / raw)
  To: gcc-patches; +Cc: Richard Earnshaw, Ramana Radhakrishnan, Kyrylo Tkachov, nickc

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Patch is adding multilib entries for `cortex-r52plus` CPU.

See: https://www.arm.com/products/silicon-ip-cpu/cortex-r/cortex-r52-plus

OK for master?

gcc/ChangeLog:

2021-09-16  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>

	* config/arm/t-rtems: Add "-mthumb -mcpu=cortex-r52plus
	-mfloat-abi=hard" multilib.

[-- Attachment #2: rb14858.patch --]
[-- Type: application/octet-stream, Size: 1405 bytes --]

diff --git a/gcc/config/arm/t-rtems b/gcc/config/arm/t-rtems
index b2fcf572bca92a712e2caa847f22da8346f0db67..37a38019fca3ec815010a45f3c054d0230d2d48d 100644
--- a/gcc/config/arm/t-rtems
+++ b/gcc/config/arm/t-rtems
@@ -17,7 +17,7 @@ MULTILIB_DIRNAMES	+= eb
 MULTILIB_OPTIONS	+= mthumb
 MULTILIB_DIRNAMES	+= thumb
 
-MULTILIB_OPTIONS	+= march=armv5te+fp/march=armv6-m/march=armv7-a/march=armv7-a+simd/march=armv7-r/march=armv7-r+fp/mcpu=cortex-r52/mcpu=cortex-m3/mcpu=cortex-m4/mcpu=cortex-m4+nofp/mcpu=cortex-m7
+MULTILIB_OPTIONS	+= march=armv5te+fp/march=armv6-m/march=armv7-a/march=armv7-a+simd/march=armv7-r/march=armv7-r+fp/mcpu=cortex-r52/mcpu=cortex-r52plus/mcpu=cortex-m3/mcpu=cortex-m4/mcpu=cortex-m4+nofp/mcpu=cortex-m7
 MULTILIB_DIRNAMES	+= armv5te+fp       armv6-m       armv7-a       armv7-a+simd       armv7-r       armv7-r+fp       cortex-r52      cortex-m3      cortex-m4      cortex-m4+nofp      cortex-m7
 
 MULTILIB_OPTIONS	+= mfloat-abi=hard
@@ -32,6 +32,7 @@ MULTILIB_REQUIRED	+= mthumb/march=armv7-a
 MULTILIB_REQUIRED	+= mthumb/march=armv7-r+fp/mfloat-abi=hard
 MULTILIB_REQUIRED	+= mthumb/march=armv7-r
 MULTILIB_REQUIRED	+= mthumb/mcpu=cortex-r52/mfloat-abi=hard
+MULTILIB_REQUIRED	+= mthumb/mcpu=cortex-r52plus/mfloat-abi=hard
 MULTILIB_REQUIRED	+= mthumb/mcpu=cortex-m3
 MULTILIB_REQUIRED	+= mthumb/mcpu=cortex-m4/mfloat-abi=hard
 MULTILIB_REQUIRED	+= mthumb/mcpu=cortex-m4+nofp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][GCC] arm: Add Cortex-R52+ multilib
  2021-09-22  8:46 [PATCH][GCC] arm: Add Cortex-R52+ multilib Przemyslaw Wirkus
@ 2021-09-22  9:46 ` Richard Earnshaw
  2021-09-30 20:37   ` Przemyslaw Wirkus
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Earnshaw @ 2021-09-22  9:46 UTC (permalink / raw)
  To: Przemyslaw Wirkus, gcc-patches
  Cc: Richard Earnshaw, Ramana Radhakrishnan, Joel Sherrill

I think the RTEMS multilibs are based on the products that RTEMS 
supports, so this is really the RTEMS maintainers' call.

Joel?

On 22/09/2021 09:46, Przemyslaw Wirkus via Gcc-patches wrote:
> Patch is adding multilib entries for `cortex-r52plus` CPU.
> 
> See: https://www.arm.com/products/silicon-ip-cpu/cortex-r/cortex-r52-plus
> 
> OK for master?
> 
> gcc/ChangeLog:
> 
> 2021-09-16  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> 
> 	* config/arm/t-rtems: Add "-mthumb -mcpu=cortex-r52plus
> 	-mfloat-abi=hard" multilib.
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH][GCC] arm: Add Cortex-R52+ multilib
  2021-09-22  9:46 ` Richard Earnshaw
@ 2021-09-30 20:37   ` Przemyslaw Wirkus
  2021-09-30 21:54     ` Joel Sherrill
  0 siblings, 1 reply; 5+ messages in thread
From: Przemyslaw Wirkus @ 2021-09-30 20:37 UTC (permalink / raw)
  To: gcc-patches, Joel Sherrill
  Cc: Richard Earnshaw, Ramana Radhakrishnan, Richard Earnshaw

> Subject: Re: [PATCH][GCC] arm: Add Cortex-R52+ multilib
> 
> I think the RTEMS multilibs are based on the products that RTEMS supports,
> so this is really the RTEMS maintainers' call.
> 
> Joel?

Ping :)

> On 22/09/2021 09:46, Przemyslaw Wirkus via Gcc-patches wrote:
> > Patch is adding multilib entries for `cortex-r52plus` CPU.
> >
> > See:
> > https://www.arm.com/products/silicon-ip-cpu/cortex-r/cortex-r52-plus
> >
> > OK for master?
> >
> > gcc/ChangeLog:
> >
> > 2021-09-16  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> >
> > 	* config/arm/t-rtems: Add "-mthumb -mcpu=cortex-r52plus
> > 	-mfloat-abi=hard" multilib.
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][GCC] arm: Add Cortex-R52+ multilib
  2021-09-30 20:37   ` Przemyslaw Wirkus
@ 2021-09-30 21:54     ` Joel Sherrill
  2021-10-04  9:26       ` Przemyslaw Wirkus
  0 siblings, 1 reply; 5+ messages in thread
From: Joel Sherrill @ 2021-09-30 21:54 UTC (permalink / raw)
  To: Przemyslaw Wirkus
  Cc: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan, Richard Earnshaw

On Thu, Sep 30, 2021, 3:37 PM Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com>
wrote:

> > Subject: Re: [PATCH][GCC] arm: Add Cortex-R52+ multilib
> >
> > I think the RTEMS multilibs are based on the products that RTEMS
> supports,
> > so this is really the RTEMS maintainers' call.
> >
> > Joel?
>
> Ping :)
>

I'm ok deferring it since Sebastian doesn't think there is a user right
now. But I'm actually rather ambivalent. If it makes it easier to maintain
versus the other embedded arm targets then I'm all for it. Maintaining
these configurations are a pain.

--joel


> > On 22/09/2021 09:46, Przemyslaw Wirkus via Gcc-patches wrote:
> > > Patch is adding multilib entries for `cortex-r52plus` CPU.
> > >
> > > See:
> > > https://www.arm.com/products/silicon-ip-cpu/cortex-r/cortex-r52-plus
> > >
> > > OK for master?
> > >
> > > gcc/ChangeLog:
> > >
> > > 2021-09-16  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> > >
> > >     * config/arm/t-rtems: Add "-mthumb -mcpu=cortex-r52plus
> > >     -mfloat-abi=hard" multilib.
> > >
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH][GCC] arm: Add Cortex-R52+ multilib
  2021-09-30 21:54     ` Joel Sherrill
@ 2021-10-04  9:26       ` Przemyslaw Wirkus
  0 siblings, 0 replies; 5+ messages in thread
From: Przemyslaw Wirkus @ 2021-10-04  9:26 UTC (permalink / raw)
  To: joel
  Cc: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan, Richard Earnshaw

> > On Thu, Sep 30, 2021, 3:37 PM Przemyslaw Wirkus <mailto:Przemyslaw.Wirkus@arm.com> wrote:
> > Subject: Re: [PATCH][GCC] arm: Add Cortex-R52+ multilib
> >
> > I think the RTEMS multilibs are based on the products that RTEMS supports,
> > so this is really the RTEMS maintainers' call.
> > 
> > Joel?

> > > Ping :)

> I'm ok deferring it since Sebastian doesn't think there is a user right now. But I'm actually rather ambivalent. If it makes it easier to maintain versus the other embedded arm targets then I'm all for it. Maintaining these configurations are a pain.

OK, let's discard this patch as there is no consensus it's useful.

Cheers!

/Przemyslaw

> --joel

> On 22/09/2021 09:46, Przemyslaw Wirkus via Gcc-patches wrote:
> > Patch is adding multilib entries for `cortex-r52plus` CPU.
> >
> > See:
> > https://www.arm.com/products/silicon-ip-cpu/cortex-r/cortex-r52-plus
> >
> > OK for master?
> >
> > gcc/ChangeLog:
> >
> > 2021-09-16  Przemyslaw Wirkus  <mailto:przemyslaw.wirkus@arm.com>
> >
> >     * config/arm/t-rtems: Add "-mthumb -mcpu=cortex-r52plus
> >     -mfloat-abi=hard" multilib.
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-04  9:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22  8:46 [PATCH][GCC] arm: Add Cortex-R52+ multilib Przemyslaw Wirkus
2021-09-22  9:46 ` Richard Earnshaw
2021-09-30 20:37   ` Przemyslaw Wirkus
2021-09-30 21:54     ` Joel Sherrill
2021-10-04  9:26       ` Przemyslaw Wirkus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).