From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id 63DB93858D28 for ; Tue, 5 Sep 2023 20:53:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63DB93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-414ba610766so105561cf.0 for ; Tue, 05 Sep 2023 13:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693947220; x=1694552020; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2DUz+U6Kp5NHSYfiGC5tFlP3hAcAJh+XuHOd9W1hb4s=; b=Q3UBuVf2sXFRAuK1NOX8ITBgvVLQChcS8ZZcOsKB2+o1eJ9Po3qytPII2Xk3zNpGAa UfAvtNGysFh730LuPYb4WapgwHMFExjJYfRlHcMG8+gpdv4r8pU0KhzifDdIslngwh6E 9BgiiAg1J1+RSJH/OpAjZkyfv+pKhQz7OSPBI4GOHWuhBHJpW0fMj8RyLGnyXG2qthpq sXgDB/HU1AjFk506vUTT1lx05JV/QLEGCjBoh74fagafIvTwRynkCTvTlhKi2Bnwp2yU yh+2ABnkj3EISV7R+TweAbcjhsNqe/58DbjEOS/MneVUZVn7VljgPz0JElOEtXkAKp2t Yxow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693947220; x=1694552020; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2DUz+U6Kp5NHSYfiGC5tFlP3hAcAJh+XuHOd9W1hb4s=; b=YAk4GEEPPqeypR5NOJnAKBea1W0G1LK0hSEPSab7e6cQcYeA82zhk1DUs7zWyHA1/m 095IRyvPqi7TXIEU0JzWa95/2QyvwTG1UWj1TZGeXa4OEJ93NdPFc5NiFecfQ7MVumhO a9IATgk+jxIrItJrL9mGP1qInhYivoL6hBYX/U2wjPhZ2D5iqtk6FStnPop8hv7f0Bbc R4TaM8wt57MG4zextFDMufZO376DhCLmuEoZJd1y/+NtdEiB7rj3zWSIwwTiC9kPTec/ zebI1OmM94qVpAzhZs9yXqMPGAypWD72LIFQJPU185XPCnUDNnvd5ECtDOn9YL0J1rGG 7Prw== X-Gm-Message-State: AOJu0Yyvy5z4CsuHRuZSDho5O3E5u8xfrIhBMK7s3tylTbZTWBkIbe8+ 2cvXl94l4BpXGLG3rBFYrqy80brdvncFFh+SbMY1M75B92fc5brz2rCx0Q== X-Google-Smtp-Source: AGHT+IHQyGr+7zrZckaS41ksDCb+rKXZM5BYG1gNuWA02SlMCzvFpVLEEYAyHWP2jhfC+CHJZAWTxyz0y/enFUMS1Gw= X-Received: by 2002:a05:622a:1a96:b0:412:16f:c44f with SMTP id s22-20020a05622a1a9600b00412016fc44fmr79009qtc.6.1693947220523; Tue, 05 Sep 2023 13:53:40 -0700 (PDT) MIME-Version: 1.0 References: <20230831090547.71737-1-kito.cheng@sifive.com> In-Reply-To: From: Fangrui Song Date: Tue, 5 Sep 2023 13:53:29 -0700 Message-ID: Subject: Re: [PATCH] RISC-V: Emit .note.GNU-stack for non-linux target as well To: Kito Cheng Cc: Jeff Law , Kito Cheng , gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000005959770604a2d20c" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000005959770604a2d20c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 5, 2023 at 5:14=E2=80=AFAM Kito Cheng via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > committed, thanks :) > > On Tue, Sep 5, 2023 at 3:18=E2=80=AFPM Jeff Law via Gcc-patches > wrote: > > > > > > > > On 8/31/23 03:05, Kito Cheng wrote: > > > We only emit that on linux target before, that not problem before, > > > however Qemu has fix a bug to make qemu user mode honor > PT_GNU_STACK[1], > > > that will cause problem when we test baremetal with qemu. > > > > > > So the straightforward is enable that as well for non-linux toolchian, > > > the price is that will increase few bytes for each binary. > > > > > > [1] > https://github.com/qemu/qemu/commit/872f3d046f2381e3f416519e82df96bd60818= 311 > > > > > > gcc/ChangeLog: > > > > > > * config/riscv/linux.h (TARGET_ASM_FILE_END): Move ... > > > * config/riscv/riscv.cc (TARGET_ASM_FILE_END): to here. > > OK. > > jeff > Does https://github.com/qemu/qemu/commit/872f3d046f2381e3f416519e82df96bd60818311 use #define EXSTACK_DEFAULT true for riscv? --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF --0000000000005959770604a2d20c--