From: Fangrui Song <maskray@google.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: gcc-patches@gcc.gnu.org, Florian Weimer <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, Jan Hubicka <hubicka@ucw.cz>,
Michael Matz <matz@suse.de>, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH v3] i386: Allow -mlarge-data-threshold with -mcmodel=large
Date: Fri, 23 Jun 2023 19:29:33 -0700 [thread overview]
Message-ID: <CAFP8O3JZenrfK1CEJ7w19zvP0s4LWhhyQ74i9dUDo8yushSQTg@mail.gmail.com> (raw)
In-Reply-To: <CAFP8O3KaNxnESaPBw3RzejU38JbLCyhoaf=mWmJ3RNbziCNrYg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Tue, Jun 13, 2023 at 2:49 PM Fangrui Song <maskray@google.com> wrote:
> On Mon, Jun 12, 2023 at 11:16 PM Jan Beulich <jbeulich@suse.com> wrote:
>
>> On 13.06.2023 05:28, Fangrui Song wrote:
>> > --- /dev/null
>> > +++ b/gcc/testsuite/gcc.target/i386/large-data.c
>> > @@ -0,0 +1,13 @@
>> > +/* { dg-do compile } */
>> > +/* { dg-require-effective-target lp64 } */
>> > +/* { dg-options "-O2 -mcmodel=large -mlarge-data-threshold=4" } */
>> > +/* { dg-final { scan-assembler ".lbss" } } */
>> > +/* { dg-final { scan-assembler ".bss" } } */
>> > +/* { dg-final { scan-assembler ".ldata" } } */
>> > +/* { dg-final { scan-assembler ".data" } } */
>> > +/* { dg-final { scan-assembler ".lrodata" } } */
>> > +/* { dg-final { scan-assembler ".rodata" } } */
>>
>> Aren't these regex-es, and hence the dots all need escaping or enclosing
>> in square brackets?
>>
>> Jan
>>
>
> Good catch! I am not familiar with dg-* directives... I can send a v4, but
> I'd like to know whether there are other comments.
> (I don't have git write permission for gcc.)
>
>
> --
> 宋方睿
>
Ping. Do people have other suggestions?
--
宋方睿
prev parent reply other threads:[~2023-06-24 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 3:28 Fangrui Song
2023-06-13 6:16 ` Jan Beulich
2023-06-13 21:49 ` Fangrui Song
2023-06-24 2:29 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFP8O3JZenrfK1CEJ7w19zvP0s4LWhhyQ74i9dUDo8yushSQTg@mail.gmail.com \
--to=maskray@google.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=jbeulich@suse.com \
--cc=matz@suse.de \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).