From: Fangrui Song <maskray@google.com>
To: FX Coudert <fxcoudert@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Iain Sandoe <iain@sandoe.co.uk>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] i386, testsuite: adjust asm patterns
Date: Mon, 12 Feb 2024 09:56:18 -0800 [thread overview]
Message-ID: <CAFP8O3JeeJWeexRmUDWjNMyfsf4ByZajuww-VCviwduOZqdN2Q@mail.gmail.com> (raw)
In-Reply-To: <D57AB569-4CDE-424F-ADB9-776B8952B126@comcast.net>
On Sun, Feb 11, 2024 at 11:12 AM Mike Stump <mikestump@comcast.net> wrote:
>
> On Feb 10, 2024, at 10:07 AM, FX Coudert <fxcoudert@gmail.com> wrote:
> >
> > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is partly because symbols are prefixed with underscore, and also because the order of operands in the addition is reversed (but I think it’s valid still). The code generated is this:
> >
> > _func:
> > LFB0:
> > pushq %rbp
> > LCFI0:
> > movq %rsp, %rbp
> > LCFI1:
> > # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
> > @ _func
> > # 0 "" 2
> > # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbol.c" 1
> > @ 4+_var
> > # 0 "" 2
> > nop
> > popq %rbp
> > LCFI2:
> > ret
> >
> >
> >
> > I’m adjusting the pattern accordingly.
> > OK to push?
>
> Ok.
Thanks for commit bbf05e3753c0fd49f1a3bf23897fa96d052ddae9!
--
宋方睿
prev parent reply other threads:[~2024-02-12 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 18:07 FX Coudert
2024-02-11 19:12 ` Mike Stump
2024-02-12 17:56 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFP8O3JeeJWeexRmUDWjNMyfsf4ByZajuww-VCviwduOZqdN2Q@mail.gmail.com \
--to=maskray@google.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).