From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id CA4A13858C2F for ; Mon, 12 Feb 2024 17:56:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA4A13858C2F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA4A13858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707760595; cv=none; b=uz/a21ozicMZR7uuT9O2sm3hhCZl3v3XuZDWpXcK6Yz6QvaNjg7dx1h8MSuetQ3+A/tYQ8YfgX8ZPsTrZ8a2Ped9Yv/xuQ/xSKV4jIeiwl3SIr03jAgB6Az4v/RzxTFpPLFIWoN3glRGBB14vQ+cjeCdpHC//bdgwO3fQTyYPP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707760595; c=relaxed/simple; bh=TGe/CsJGzExXe7zWQrWUvD755wIUelHBRhIjYJ0w47k=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=mQozocplCVZ6nK90yWkGZxjbWDsStFjPej/MSQHT/HvOg6hLHKDeUK5wgBWL0lLlli41m9LxAsgrXHM1HEX7JT1r6ZqUG3Hy4xNlssdgkiBgLakv/+MruNTkUpxDn8IiBha3q4NvqtUz071u8LP+pt3qngtMKyZ5R2x/EhKqcLE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-56101dee221so144a12.1 for ; Mon, 12 Feb 2024 09:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707760592; x=1708365392; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=38jrn3LGPZebJL98usQU2mM3cVF1PHyDKTziLcDGtQ0=; b=stk3ECjmL9qALaXHogdEcfv7T9r5bqe9T0R+pOIsngy//HaNlIXwNx5Cp585No/05a de8Ylnm8psPY/BFe57S+bQKMWL2KamzOgVFoSPyVE8a2NVsp7UDCAWEZRBzTd2ev+fmW ovluRd9RBe6jlP3D3wEp01776Yr5aiQlJukl00QH0xhfRcxT7mi1izQ3lx1UFf00thP5 agfqK9ClUcFlCcfRmgtgqUuJkKhPaAMx9FV2JVjaxFFYNiePMgHTqW5f9KmZa9GVJZSr f5uNZzGEhWvSS7lQCbPajfnSkC1NPxKyVAqGq2apO1ae/UqWbQ+MBpQ2c9s5viLZAffa USYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707760592; x=1708365392; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=38jrn3LGPZebJL98usQU2mM3cVF1PHyDKTziLcDGtQ0=; b=t2+8H5pAOnFRzlhZCujffeRyz9GbOdjYbOPBiDNjWMQBcu2Hhy/XzvDutPMfmrWCB6 3zRv/z6gwKhvyTTH0xkke+RBnAa6idGrmoWpy9k1GZqxKC/U+aQ9ks8grLCpZSmcqyuN D+f4iPlLbLXGGoK4hgK1YmqzrxeBr/PobFYgsCR0Hmp7n1DqD4djI9kJgptrpbSw5CSN P1hSmRtkrLtO1VX5uDs2YRN5azX0FbUOjol1ljj8fOvXA8hWaKOZ2avhVJNK03FQ8MjA c0uuJqWB9OGV4YrpKRtIZ3OmgfPWS0ujNuxkbFPBruVRtyClpLHLE8t1gX59h6iOjVZH wNCw== X-Gm-Message-State: AOJu0Yzkj5igh8dna/cPCCOQzDeZKQ46pNiHoi1q9632tNxY0CdSo8KW gyqalxZ6q40z9PezytwRuo5HQx6CQ+1PxNbAaYiN0bnMTsJObUCDi6RVSN+gqHPHJs4vzAjTU/m gXcUQphgABh6Q+5V0+ThP7fskAKLFSKwEQN3G X-Google-Smtp-Source: AGHT+IEszyOWWVNUX6K3hQrqW5+N5mf1+CYHN//pIh77txvoFLoxuAu7SL/vW8MpsG6ZdthGKQ18EmPBMu9ytOVrxT8= X-Received: by 2002:a50:8d53:0:b0:55f:9918:dadd with SMTP id t19-20020a508d53000000b0055f9918daddmr228573edt.2.1707760592341; Mon, 12 Feb 2024 09:56:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Fangrui Song Date: Mon, 12 Feb 2024 09:56:18 -0800 Message-ID: Subject: Re: [PATCH] i386, testsuite: adjust asm patterns To: FX Coudert Cc: GCC Patches , Iain Sandoe , Mike Stump Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Feb 11, 2024 at 11:12=E2=80=AFAM Mike Stump = wrote: > > On Feb 10, 2024, at 10:07 AM, FX Coudert wrote: > > > > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This= is partly because symbols are prefixed with underscore, and also because t= he order of operands in the addition is reversed (but I think it=E2=80=99s = valid still). The code generated is this: > > > > _func: > > LFB0: > > pushq %rbp > > LCFI0: > > movq %rsp, %rbp > > LCFI1: > > # 8 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbo= l.c" 1 > > @ _func > > # 0 "" 2 > > # 9 "/Users/fx/gcc-upstream/gcc/testsuite/gcc.target/i386/asm-raw-symbo= l.c" 1 > > @ 4+_var > > # 0 "" 2 > > nop > > popq %rbp > > LCFI2: > > ret > > > > > > > > I=E2=80=99m adjusting the pattern accordingly. > > OK to push? > > Ok. Thanks for commit bbf05e3753c0fd49f1a3bf23897fa96d052ddae9! --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF