From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 58C653858D1E for ; Mon, 6 May 2024 23:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58C653858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58C653858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715037011; cv=none; b=KsjpB5M+eEr8bLaxajzzDeEqQN0QTJlmx9rZhrKGcI85mr26IzV0KRYxhDSjZP6d3x23tUcBvzXaiV9S3FJZv7AzSMmUI213gw3FAyFHRZqoFrFBZ3b0Ml90+QEyxmYfiGnKyUAPwNGKb3hDakMTfkquECpznurMoJ8qZBLWQ1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715037011; c=relaxed/simple; bh=PTsDkhLRqfd/DmaGzeAR4UbbhUIA9OT1A7isyqkV9kk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Ld8i+I4kztt7PjQGnQiDupX9pbzNoysUem4JdiNqWmWdoieCBpNQLjD51+bQ/XjK0+hiKbxc7URteoQ0FfCXqk3FCbdR1KsGpexUVFMOAmb4GUVIa2JtKM9QsrcRPv+9B89KCI9drsvg8pIRv7lQbuiTJ3gnJ9OSm3bmtFf+KtM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5724736770cso2213a12.1 for ; Mon, 06 May 2024 16:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715037007; x=1715641807; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yF+VjDZGt6iFtjEr5IM2xnkQ6WQDi/AvhRVQp1TZ/Kw=; b=ZkDwIupgWwSQ6/x2Sp17AW+egiO3mlUSdmmhpaFL5woCI+z2rqH/Ffd9ma05xLDVSa EQFlj+3LA7zHbbYdMx1vHSQp3Mpr1HVEYRhl/NjgjpnCzviee84v9JGpxNzKCT5m5mhM qPxkaLCtiVeSnybHKrYgQvZBOF6H0IBXYP0h91VXBETzcx/oEcZVnNxZH2DqHxUibqXH 9gp9jjpIsSffkExwwpBE6FeIhffTiODqh10cphFfSflBzLMEAFXhagv/gaAE0jk5ng7x seALkVcCbRxt9IeEfSEnqVP5M+z+GiRDnuVAQ551DXTNS40XOB0sV5dRq6+jdYmoNEfv pYgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715037007; x=1715641807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yF+VjDZGt6iFtjEr5IM2xnkQ6WQDi/AvhRVQp1TZ/Kw=; b=adC7sa1+jbJAxMeAYsQb8yPphQFo1Ri+pMTLwoVyfOEnQitfbQanSGfKU6CdTnVaw3 TUuEL2AbCWI91PGrDQ+fjBQeTkEK+uQ2wwLvQ2sj19NKkfc2h3G9pm35gqGwUxDkyAtY RFjyrZzuVM4NwHrfLqtA63YeSaom/ptbK7InAHr60d3MMIW/x74a7rR64Dl5NWDyoNaP 7ZNMjUn9Ekdqw5w1bXyLbAhyHPe0gIO8etMt+8CTkQZChKmjYwhL7e+rabiabmRHyock j954NMxkhT3D5E/Hn05sLsgNChTvCrEce5PlGwTFL/Gk2JfrFYvBjlzrCsehbd4pEcpx DDCA== X-Gm-Message-State: AOJu0YxKXbgLsYXDNcl9XtshaSbAE4xp4xKVbdSZQOKA6e+uMPFImGjx Q/fAQM/gqVBOcemFKxdyZG8cP6nA0LzRUVR/yqx+0wa1a9gaOHnRNeVYghxe5YfTsyH5UIWw+uD v1A3Mh4AeMilalBFK8zEFJd6fUob6SwbN6NOv X-Google-Smtp-Source: AGHT+IHlckv5JsCJ0tE3IPXUXedG6x0vPXoHNgpv7KRPSXUGo/qJ/dxmUAqsMzaB6rIZGt8uDNytkVsYqV9EuGm/Gyk= X-Received: by 2002:a05:6402:34ce:b0:573:1366:d196 with SMTP id 4fb4d7f45d1cf-5731366d350mr36651a12.1.1715037006675; Mon, 06 May 2024 16:10:06 -0700 (PDT) MIME-Version: 1.0 References: <20240224033354.3767291-1-maskray@google.com> <30f1b722-7227-4bee-80e5-c8b790c3d1bd@arm.com> In-Reply-To: <30f1b722-7227-4bee-80e5-c8b790c3d1bd@arm.com> From: Fangrui Song Date: Mon, 6 May 2024 16:09:53 -0700 Message-ID: Subject: Re: [PATCH] arm: Support -mfdpic for more targets To: "Richard Earnshaw (lists)" Cc: GCC Patches , Christophe Lyon , Szabolcs Nagy , Fangrui Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-23.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 6, 2024 at 1:54=E2=80=AFAM Richard Earnshaw (lists) wrote: > > On 06/03/2024 05:07, Fangrui Song wrote: > > On Fri, Feb 23, 2024 at 7:33=E2=80=AFPM Fangrui Song wrote: > >> > >> From: Fangrui Song > >> > >> Targets that are not arm*-*-uclinuxfdpiceabi can use -S -mfdpic, but -= c > >> -mfdpic does not pass --fdpic to gas. This is an unnecessary > >> restriction. Just define the ASM_SPEC in bpabi.h. > >> > >> Additionally, use armelf[b]_linux_fdpiceabi emulations for -mfdpic in > >> linux-eabi.h. This will allow a future musl fdpic port to use the > >> desired BFD emulation. > >> > >> gcc/ChangeLog: > >> > >> * config/arm/bpabi.h (TARGET_FDPIC_ASM_SPEC): Transform -mfdpi= c. > >> * config/arm/linux-eabi.h (TARGET_FDPIC_LINKER_EMULATION): Def= ine. > >> (SUBTARGET_EXTRA_LINK_SPEC): Use TARGET_FDPIC_LINKER_EMULATION > >> if -mfdpic. > >> --- > >> gcc/config/arm/bpabi.h | 2 +- > >> gcc/config/arm/linux-eabi.h | 5 ++++- > >> 2 files changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/gcc/config/arm/bpabi.h b/gcc/config/arm/bpabi.h > >> index 7a279f3ed3c..6778be1a8bf 100644 > >> --- a/gcc/config/arm/bpabi.h > >> +++ b/gcc/config/arm/bpabi.h > >> @@ -55,7 +55,7 @@ > >> #define TARGET_FIX_V4BX_SPEC " %{mcpu=3Darm8|mcpu=3Darm810|mcpu=3Dstr= ongarm*"\ > >> "|march=3Darmv4|mcpu=3Dfa526|mcpu=3Dfa626:--fix-v4bx}" > >> > >> -#define TARGET_FDPIC_ASM_SPEC "" > >> +#define TARGET_FDPIC_ASM_SPEC "%{mfdpic: --fdpic}" > >> > >> #define BE8_LINK_SPEC = \ > >> "%{!r:%{!mbe32:%:be8_linkopt(%{mlittle-endian:little}" = \ > >> diff --git a/gcc/config/arm/linux-eabi.h b/gcc/config/arm/linux-eabi.h > >> index eef791f6a02..0c5c58e4928 100644 > >> --- a/gcc/config/arm/linux-eabi.h > >> +++ b/gcc/config/arm/linux-eabi.h > >> @@ -46,12 +46,15 @@ > >> #undef TARGET_LINKER_EMULATION > >> #if TARGET_BIG_ENDIAN_DEFAULT > >> #define TARGET_LINKER_EMULATION "armelfb_linux_eabi" > >> +#define TARGET_FDPIC_LINKER_EMULATION "armelfb_linux_fdpiceabi" > >> #else > >> #define TARGET_LINKER_EMULATION "armelf_linux_eabi" > >> +#define TARGET_FDPIC_LINKER_EMULATION "armelf_linux_fdpiceabi" > >> #endif > >> > >> #undef SUBTARGET_EXTRA_LINK_SPEC > >> -#define SUBTARGET_EXTRA_LINK_SPEC " -m " TARGET_LINKER_EMULATION > >> +#define SUBTARGET_EXTRA_LINK_SPEC " -m %{mfdpic: " \ > >> + TARGET_FDPIC_LINKER_EMULATION ";:" TARGET_LINKER_EMULATION "}" > >> > >> /* GNU/Linux on ARM currently supports three dynamic linkers: > >> - ld-linux.so.2 - for the legacy ABI > >> -- > >> 2.44.0.rc1.240.g4c46232300-goog > >> > > > > Ping:) > > > > We're in stage4 at present and this is new material. I'll look at it aft= er the branch has been cut. > > R. refs/heads/releases/gcc-14 has been cut :) --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF